which was accidentally removed by b5e9d97bdf8a63a542f8cbb3c1d0821ee731f796.
Signed-off-by: Fabian Ebner
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 8b9c40d..e768072 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/
When the virt-viewer file is downloaded we already set
a file name in Android, so the file type may be
recognized. Also doing this in Chrome (and Chromium
based browsers) allows users to "alyways open files of
this type". So the browser automatically opens the
console window without user interactio
On 22.04.21 08:39, Dominik Csapak wrote:
> we want to use spice for vms more than xtermjs if both are available
> (since spice must be chosen as display in that case)
> so the resulting order of preference for vms is:
> spice
> xtermjs
> novnc
>
> since all methods work for containers always
On 21.04.21 13:59, Lorenz Stechauner wrote:
> On file upload, the check for CSRF tokens was already skipped
> when performing user authentication.This now happens for API
> tokens also.
>
> Signed-off-by: Lorenz Stechauner
> ---
> PVE/HTTPServer.pm | 34 +-
> 1 fi
On April 21, 2021 1:59 pm, Lorenz Stechauner wrote:
> On file upload, the check for CSRF tokens was already skipped
> when performing user authentication.This now happens for API
> tokens also.
>
> Signed-off-by: Lorenz Stechauner
> ---
> PVE/HTTPServer.pm | 34 +-
On 21.04.21 23:49, Alexandre Derumier wrote:
> - fix broken evpn tests since last commit
> https://lists.proxmox.com/pipermail/pve-devel/2021-April/047521.html
>
> - add ebgp-multihop option
> (replace
> https://lists.proxmox.com/pipermail/pve-devel/2021-April/047547.html)
>
>
> Changelog
On 22.04.21 10:05, Fabian Grünbichler wrote:
> On April 21, 2021 1:59 pm, Lorenz Stechauner wrote:
>> On file upload, the check for CSRF tokens was already skipped
>> when performing user authentication.This now happens for API
>> tokens also.
>>
>> Signed-off-by: Lorenz Stechauner
>> ---
>> PVE/
On 4/22/21 10:02, Thomas Lamprecht wrote:
On 22.04.21 08:39, Dominik Csapak wrote:
we want to use spice for vms more than xtermjs if both are available
(since spice must be chosen as display in that case)
so the resulting order of preference for vms is:
spice
xtermjs
novnc
since all me
Signed-off-by: Stefan Reiter
---
As discussed off-list, the vzdump section in general seems a bit misorganized,
and is certainly missing some references to PBS. Dylan agreed to take a look at
it, thanks again for that!
vzdump.adoc | 28
1 file changed, 28 insertions
Signed-off-by: Stefan Reiter
---
vzdump.adoc | 24
1 file changed, 24 insertions(+)
diff --git a/vzdump.adoc b/vzdump.adoc
index 0577a97..c6063ad 100644
--- a/vzdump.adoc
+++ b/vzdump.adoc
@@ -365,6 +365,30 @@ amount of data is required for initial operation, e.g. web
s
On April 20, 2021 3:14 pm, Dylan Whyte wrote:
> Fixes an issue in which a VM/CT fails to automatically restart after a
> failed stop-mode backup.
>
> Also fixes a minor typo in a comment
>
> Signed-off-by: Dylan Whyte
Reviewed-by: Fabian Grünbichler
> ---
>
> Note:
>
> v1->v2:
> - Fix the i
Do not check any csrf tokens for auth with api tokens.
Signed-off-by: Lorenz Stechauner
---
PVE/HTTPServer.pm | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/PVE/HTTPServer.pm b/PVE/HTTPServer.pm
index bfb753eb..7a3bf72b 100755
--- a/PVE/HTTPServer.pm
+++ b/PVE/H
On 22.04.21 10:46, Lorenz Stechauner wrote:
> Do not check any csrf tokens for auth with api tokens.
>
> Signed-off-by: Lorenz Stechauner
> ---
> PVE/HTTPServer.pm | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
applied, thanks! Added an actual comment explaining this
On 20.04.21 15:14, Dylan Whyte wrote:
> Fixes an issue in which a VM/CT fails to automatically restart after a
> failed stop-mode backup.
>
> Also fixes a minor typo in a comment
>
> Signed-off-by: Dylan Whyte
> ---
>
> Note:
>
> v1->v2:
> - Fix the issue from within PVE::VZDump::QemuServer, r
On 22.04.21 08:57, Fabian Ebner wrote:
> which was accidentally removed by b5e9d97bdf8a63a542f8cbb3c1d0821ee731f796.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
On 3/23/21 13:27, Dominik Csapak wrote:
Signed-off-by: Dominik Csapak
---
www/manager6/Parser.js | 5 +
1 file changed, 5 insertions(+)
diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js
index b83a5d46..1a5fe1c2 100644
--- a/www/manager6/Parser.js
+++ b/www/manager6/Parser.js
@
On 23.03.21 13:27, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak
> ---
> www/manager6/Parser.js | 5 +
> 1 file changed, 5 insertions(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.co
Hi,
I just made some very minor suggestions inline, but overall it's good (i
had to search extra-hard for issues) :)
Reviewed-by: Dylan Whyte
On 4/22/21 10:25 AM, Stefan Reiter wrote:
Signed-off-by: Stefan Reiter
---
As discussed off-list, the vzdump section in general seems a bit misorga
Hi,
Have even less notes for this one. Just some little things sounded off
to me.
Reviewed-by: Dylan Whyte
On 4/22/21 10:25 AM, Stefan Reiter wrote:
Signed-off-by: Stefan Reiter
---
vzdump.adoc | 24
1 file changed, 24 insertions(+)
diff --git a/vzdump.adoc b/v
On Wed, Apr 21, 2021 at 01:15:29PM +0200, Stefan Reiter wrote:
> Implements the necessary API for allowing single file restore via the PVE web
> GUI.
Restoring a couple of small text files and folders with textfiles from
containers worked really well for me. For VMs I could also restore some text
This is mostly in preparation for renaming pve-efiboot-uuids into
proxmox-boot-uuids, but can help in general (since each duplicate uuid
causes excessive disk i/o upon kernel upgrades).
Signed-off-by: Stoiko Ivanov
---
bin/proxmox-boot-tool | 4
1 file changed, 4 insertions(+)
diff --git a
the pve-kernel-meta patches were prepared on top of the pve-kernel-5.4 branch
rfc->v1:
* Thanks to Fabian's great feedback this version handles a few cases I did not
think of for the RFC (e.g. an update to grub which runs grub-install and
removes the core.img/stage0 pointing to the ESP (instead
proxmox-boot-tool now supports configuring grub to boot from the ESPs
the installer creates on all (bootable) disks - use this approach
for zfs installs.
Signed-off-by: Stoiko Ivanov
---
best viewed with `git show -w`
proxinstall | 26 +-
1 file changed, 13 insertions(+),
if a (legacy) system is booted with proxmox-boot-tool, running
`grub-install` without being aware of the fact can render the system
unbootable (e.g. when letting the early stage point to an incompatible
zpool instead of the ESP).
To prevent this we add a dpkg-diversion [0], which simply checks if
This patch adds support for booting non-uefi/legacy/bios-boot ZFS
installs, by using proxmox-boot-tool to copy the kernels to the ESP
and then generate a fitting grub config for booting from the vfat ESP:
* grub is installed onto the ESP and the MBR points to the ESP
* after copying/deleting the k
currently simply checking if $ESP_LIST exists, and indicating via
the exit status if proxmox-boot-tool is used for booting the system.
Signed-off-by: Stoiko Ivanov
---
bin/proxmox-boot-tool | 20
1 file changed, 20 insertions(+)
diff --git a/bin/proxmox-boot-tool b/bin/prox
We will be using the mechanics also for ZFS systems booting with BIOS
legacy boot, and the tool is used also in PMG and PBS.
A symlink is kept in place for compatibility reasons
Signed-off-by: Stoiko Ivanov
---
Makefile | 2 +-
bin/Makefile
in order to be consistent with the renaming of pve-efiboot-tool to
proxmox-boot-tool.
Sending as separate patch, since it changes and removes a file in
'/etc', which could be considered part of the external 'api' of
proxmox-boot-tool
Signed-off-by: Stoiko Ivanov
---
debian/pve-kernel-helper.pos
If the system seems to be booted using proxmox-boot, write a header at
the beginning of the grub.cfg generated when running `update-grub`
Additionally print a warning in case the script is run interactively.
This is determined by checking for DPKG_VERSION, which is set when
running as post-inst ta
On 22/04/2021 12:33, Dominic Jäger wrote:
On Wed, Apr 21, 2021 at 01:15:29PM +0200, Stefan Reiter wrote:
Implements the necessary API for allowing single file restore via the PVE web
GUI.
Restoring a couple of small text files and folders with textfiles from
containers worked really well for m
Signed-off-by: Stefan Reiter
Reviewed-by: Dylan Whyte
---
v2:
* Incorporate Dylan's review + R-b
vzdump.adoc | 24
1 file changed, 24 insertions(+)
diff --git a/vzdump.adoc b/vzdump.adoc
index b8ea081..0937fe2 100644
--- a/vzdump.adoc
+++ b/vzdump.adoc
@@ -365,6 +365,3
Signed-off-by: Stefan Reiter
Reviewed-by: Dylan Whyte
---
v2:
* Incorporate Dylan's review + R-b
Agreed with all suggestions, for both patches :)
vzdump.adoc | 28
1 file changed, 28 insertions(+)
diff --git a/vzdump.adoc b/vzdump.adoc
index 9453684..b8ea081 10064
iptables-restore has a buffer limit of 1024 for paramters [0].
If users end up adding a long list of IPs in the source or dest field
they might reach this limit. The result is that the rule will not be
applied and pve-firewall will show some error in the syslog which will
be "hidden" for most user
Limiting the length of the source and dest paramters helps to avoid
problems with iptables-restore which would not apply a rule if a
parameter is larger than the parameter buffer (1024)[0]. As the API is
already limiting this, we should also reflect that in the GUI and give
people a hint that IP se
On April 22, 2021 1:17 pm, Stoiko Ivanov wrote:
> We will be using the mechanics also for ZFS systems booting with BIOS
> legacy boot, and the tool is used also in PMG and PBS.
>
> A symlink is kept in place for compatibility reasons
>
> Signed-off-by: Stoiko Ivanov
> ---
> Makefile
On April 22, 2021 1:17 pm, Stoiko Ivanov wrote:
> currently simply checking if $ESP_LIST exists, and indicating via
> the exit status if proxmox-boot-tool is used for booting the system.
>
> Signed-off-by: Stoiko Ivanov
> ---
> bin/proxmox-boot-tool | 20
> 1 file changed, 2
Signed-off-by: Stefan Reiter
---
new in v2
src/bin/proxmox-file-restore.rs | 22 +---
src/bin/proxmox_file_restore/block_driver.rs | 1 +
src/bin/proxmox_file_restore/qemu_helper.rs | 9 ++--
3 files changed, 27 insertions(+), 5 deletions(-)
diff --git a/src
More helpful for a user to know what they're missing.
Suggested-by: Dominic Jäger
Signed-off-by: Stefan Reiter
---
new in v2
src/PVE/PBSClient.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
index 857cff0..16f7765 100644
--- a
Signed-off-by: Stefan Reiter
---
v2:
* one line per param
src/PVE/PBSClient.pm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
index 16f7765..8e4deca 100644
--- a/src/PVE/PBSClient.pm
+++ b/src/PVE/PBSClient.pm
@@ -335,4 +335,15 @@ su
If an error is received upon expanding a node, chances are the rest of
the tree is still valid (i.e. opening a partition fails because it
doesn't contain a supported filesystem). Only show an error box for the
user, but don't mask the component in that case. Additionally, disable
the download butto
Allow specifying a filepath for stream=1 instead of either a path or fh
with stream=1.
With this in place, we can also just return the path to the proxy in
case we want to stream a response back, and let it read from the file
itself. This way, the pvedaemon is cut out of the transfer pipe.
Signed
*_prepare creates a fifo for streaming data back to clients directly,
filefile_restore_extract blocks and should be called from a background
worker - while it is running outcoming data can be read from the FIFO.
Signed-off-by: Stefan Reiter
---
v2:
* don't use "startcmd", just pass "opts" direct
Use an explicit AnyEvent::Handle similar to websocket proxying.
Needs some special care to make sure we apply backpressure correctly to
avoid caching too much data. Note that because of AnyEvent restrictions,
specifying a "fh" to point to a file or a packet-based socket may result
in unwanted beha
It is valid to not set it, in case the server has a valid certificate.
Signed-off-by: Stefan Reiter
---
new in v2
src/bin/proxmox_file_restore/qemu_helper.rs | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/bin/proxmox_file_restore/qemu_helper.rs
b/src/bin/proxmox_file_restore/qemu_h
same functionality as crypto_parameters, except it keeps the file
descriptor passed as "keyfd" open (and seeks to the beginning after
reading), if one is given.
Signed-off-by: Stefan Reiter
---
new in v2
src/bin/proxmox_client_tools/key_source.rs | 17 +++--
1 file changed, 15 inse
Includes list and restore calls.
Requires VM.Backup and Datastore.Audit permissions, for the accessed
VM/CT and containing datastore respectively.
Signed-off-by: Stefan Reiter
---
Requires updated pve-common, pve-http-server.
v2:
* use same permissions as regular backup access, check with chec
Implements the necessary API for allowing single file restore via the PVE web
GUI.
This requires some adaptations of the HTTP server, to allow data streaming
without buffering - otherwise bigger restores would a) use up too much memory b)
get slowed down by the pvedaemon->pveproxy->client return p
Necessary for accessing encrypted backups.
Signed-off-by: Stefan Reiter
---
new in v2
src/PVE/PBSClient.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
index e96f20d..537fd83 100644
--- a/src/PVE/PBSClient.pm
+++ b/src/PVE/PBSClient.pm
@@ -1
Denotes objects like disks ".img.fidx" files, which shouldn't be
downloadable, but should still approximate a directory entry.
Signed-off-by: Stefan Reiter
---
new in v2
src/window/FileBrowser.js | 4
1 file changed, 4 insertions(+)
diff --git a/src/window/FileBrowser.js b/src/window/Fil
Call a function to decide if we want to mask the component. If the
callback returns true, we assume it has already handled the error (i.e.
shown a messagebox or similar) and skip masking.
Signed-off-by: Stefan Reiter
---
new in v2
src/Utils.js | 6 --
1 file changed, 4 insertions(+), 2 del
Adds it for both BackupViews, on VM view and storage view.
Signed-off-by: Stefan Reiter
---
Forgot to resend this one for v2, it didn't change though AFAIR.
www/manager6/grid/BackupView.js| 23 +++
www/manager6/storage/BackupView.js | 19 +++
2 files cha
Signed-off-by: Stefan Reiter
---
new in v2
www/manager6/Utils.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 7fcda854..4b5dc189 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1791,6 +1791,7 @@ Ext.define('PVE.Utils'
On 22.04.21 14:30, Aaron Lauterer wrote:
> iptables-restore has a buffer limit of 1024 for paramters [0].
>
> If users end up adding a long list of IPs in the source or dest field
> they might reach this limit. The result is that the rule will not be
> applied and pve-firewall will show some error
On 22.04.21 17:34, Stefan Reiter wrote:
> It is valid to not set it, in case the server has a valid certificate.
>
> Signed-off-by: Stefan Reiter
> ---
>
> new in v2
>
> src/bin/proxmox_file_restore/qemu_helper.rs | 3 ---
> 1 file changed, 3 deletions(-)
>
>
applied, thanks!
_
On 22.04.21 17:34, Stefan Reiter wrote:
> same functionality as crypto_parameters, except it keeps the file
> descriptor passed as "keyfd" open (and seeks to the beginning after
> reading), if one is given.
>
> Signed-off-by: Stefan Reiter
> ---
>
> new in v2
>
> src/bin/proxmox_client_tools/k
On 22.04.21 17:34, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter
> ---
>
> new in v2
>
> src/bin/proxmox-file-restore.rs | 22 +---
> src/bin/proxmox_file_restore/block_driver.rs | 1 +
> src/bin/proxmox_file_restore/qemu_helper.rs | 9 ++--
> 3 files c
On 19.04.21 13:00, Dominik Csapak wrote:
> with 2 minor fixups:
> * one lint error
> * binding of the 'updateValues' function in the event
> (we want to avoid breaking this when used in a context where
> a controller exists, in that case using a string will only look in
> the controller and n
On 22.04.21 17:34, Stefan Reiter wrote:
> Denotes objects like disks ".img.fidx" files, which shouldn't be
> downloadable, but should still approximate a directory entry.
>
> Signed-off-by: Stefan Reiter
> ---
>
> new in v2
>
> src/window/FileBrowser.js | 4
> 1 file changed, 4 insertions
On 22.04.21 17:34, Stefan Reiter wrote:
> If an error is received upon expanding a node, chances are the rest of
> the tree is still valid (i.e. opening a partition fails because it
> doesn't contain a supported filesystem). Only show an error box for the
> user, but don't mask the component in tha
On 19.04.21 13:00, Dominik Csapak wrote:
> manager needs a depends on a bumped widget-toolkit ofc
>
> proxmox-widget-toolkit:
>
> Dominik Csapak (4):
> Utils: add several render functions from PVE
> bring over some icons from PVE
> Utils: refactor updateColumns from pve-manager
> panel: a
On 22.04.21 17:34, Stefan Reiter wrote:
> Call a function to decide if we want to mask the component. If the
> callback returns true, we assume it has already handled the error (i.e.
> shown a messagebox or similar) and skip masking.
>
> Signed-off-by: Stefan Reiter
> ---
>
> new in v2
>
> src
On 19.04.21 15:14, Fabian Ebner wrote:
> by allowing generic additional items for the SafeDestroy window in
> widget-toolkit and deriving a SafeDestroyGuest child class from it.
>
> Also switch over the other SafeDestroy users in PVE.
>
>
> proxmox-widget-toolkit:
>
> Fabian Ebner (2):
> safe
On 22.04.21 17:34, Stefan Reiter wrote:
> Necessary for accessing encrypted backups.
>
> Signed-off-by: Stefan Reiter
> ---
>
> new in v2
>
> src/PVE/PBSClient.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
> index e96f20d..537fd83 10
On 22.04.21 14:30, Aaron Lauterer wrote:
> Limiting the length of the source and dest paramters helps to avoid
> problems with iptables-restore which would not apply a rule if a
> parameter is larger than the parameter buffer (1024)[0]. As the API is
> already limiting this, we should also reflect
On 19.04.21 20:11, Stoiko Ivanov wrote:
> Currently the check for used ports for bonds and bridges happens while
> rendering '/etc/network/interfaces.new' in PVE::Inotify (pve-common).
> However at that stage the new/updated interface is already merged with
> the old settings, making it impossible
On 28.09.20 10:33, Alexandre Derumier wrote:
> Following pve-network
>
>
> Alexandre Derumier (5):
> add sdn/subnets.cfg
> add sdn/ipams.cfg
> add priv/ipam.db
> add sdn/dns.cfg
> rename sdn/.version to sdn/.running-config
>
> data/PVE/Cluster.pm | 6 +-
> data/src/status.c | 6
On 01.10.20 10:53, Fabian Grünbichler wrote:
> noticed while debugging the (as it turns out) missing lock issue that
> qb_log is not thread-safe by default, this patch series switches to
> threaded, non-blocking logging.
>
> Fabian Grünbichler (3):
> pmxcfs: switch log domain to enum
> pmxcfs:
On 29.01.21 08:54, Dylan Whyte wrote:
> Add commands for creating, modifying, listing, and deleting resource
> pools.
>
> Signed-off-by: Dylan Whyte
> ---
> v1->v2: remove command aliases
>
> PVE/CLI/pveum.pm | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>
applied, thanks!
On 01.02.21 15:47, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
> ---
> data/PVE/CLI/pvecm.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmo
On 08.02.21 14:08, Fabian Grünbichler wrote:
> similar to the existing encryption key handling, but without
> auto-generation since we only have the public part here.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> v2: only use master key for backup command
>
> PVE/API2/Storage/Co
On 08.03.21 14:43, Dominik Csapak wrote:
> Previously, we ever only had a single boot *disk*, while possibly
> having multiple cdroms/nics in the boot order
>
> e.g. the config:
>
> boot: dnc
> bootdisk: scsi0
> ide0: media=cdrom,none
> scsi0: xxx
> net0: ...
>
> would return the size of sc
On 12.04.21 12:08, Dominic Jäger wrote:
> Extend qm importdisk/importovf functionality to the API.
>
> Co-authored-by: Fabian Grünbichler
> Signed-off-by: Dominic Jäger
> ---
> v8:
> - Fabian moved the import functions into the existing create_vm /
> update_vm_api
> - Dropped the separate API e
72 matches
Mail list logo
