Re: [pve-devel] Fwd: Bug#986371: Indeed this should work (also adding trivial test-case)

2021-04-07 Thread Thomas Lamprecht
Hi, On 06.04.21 20:48, Chris Hofstaedtler wrote: > I believe you'll find Debian bug #986371 of interest. In Kernels > 5.10+ the "guest time" accounting appears to be broken, in both > Debian and Ubuntu. See https://bugs.debian.org/986371 for further > details. > Thanks for sharing, appreciated!

[pve-devel] [PATCH pve-cluster 1/2] Close #1295: Add notify_updates to datacenter schema

2021-04-07 Thread Dominic Jäger
To store user preference for if they want to receive notifications from pveupdate or not. Signed-off-by: Dominic Jäger --- data/PVE/DataCenterConfig.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm index 24ebf3f..d20292f 100

[pve-devel] [PATCH manager 2/2] Close #1295: Make apt notifications configurable

2021-04-07 Thread Dominic Jäger
This way all users, including subscription users, can decide if they want to receive notifications mails from pveupdate or not. Disabling notifications is desirable if available updates are monitored externally, for example. Signed-off-by: Dominic Jäger --- bin/pveupdate | 4 +---

Re: [pve-devel] [PATCH manager 2/2] Close #1295: Make apt notifications configurable

2021-04-07 Thread Thomas Lamprecht
On 07.04.21 10:30, Dominic Jäger wrote: > This way all users, including subscription users, can decide if they want to > receive notifications mails from pveupdate or not. Disabling notifications is > desirable if available updates are monitored externally, for example. > > Signed-off-by: Dominic

[pve-devel] [PATCH storage 1/2] plugin: subdir files: backup: don't match for vmid against the full path

2021-04-07 Thread Fabian Ebner
Only match against the file name to avoid false positives with directory names containing "-$vmid-". Signed-off-by: Fabian Ebner --- Found while trying to debug/reproduce a forum thread[0], but the path there should not be affected by this... [0]: https://forum.proxmox.com/threads/vzdump-removi

[pve-devel] [PATCH storage 2/2] prune backups: make vmid filtering more robust

2021-04-07 Thread Fabian Ebner
by relying on archive_info's vmid first. archive_info is already used to determine if it's a standard name, and in that case the vmid is certainly set. Also add asserts to make sure we got what we expected. Signed-off-by: Fabian Ebner --- continuing from previous patch: ...but it really seems t

[pve-devel] [PATCH v2 storage 0/3] ceph: add namespace support

2021-04-07 Thread Aaron Lauterer
This series introduces namespace support for Ceph RBD on the PVE side. The first patch reworks the RBD storage plugin to use one central sub to create the RBD paths for /. With this patch applied, adding support for namespaces involves very little changes to the RBD plugin. v1 -> v2: * new patch

[pve-devel] [PATCH v2 storage 1/3] rbd: centralize rbd path concatenation

2021-04-07 Thread Aaron Lauterer
The / paths are needed in quite a lot of places. Having one single place where they are created helps to reduce duplicate code and makes it easier to introduce new features. The 'add_pool_to_disk' sub was already doing that but the name was not really fitting. This commit renames it to the more ge

[pve-devel] [PATCH v2 storage 2/3] rbd: fix #3286 add namespace support

2021-04-07 Thread Aaron Lauterer
This patch introduces support for Cephs RBD namespaces. A new storage config parameter 'namespace' defines the namespace to be used for the RBD storage. The namespace must already exist in the Ceph cluster as it is not automatically created. The main intention is to use this for external Ceph cl

[pve-devel] [PATCH v2 storage 3/3] rbd: add integration test for namespace handling

2021-04-07 Thread Aaron Lauterer
This test is intended to be run on a hyperconverged PVE cluster to test the most common operations of VMs using a namespaced Ceph RBD pool. Signed-off-by: Aaron Lauterer --- v1 -> v2: reworked the test from the feedback I got [0]. * tests are now defined in deeper hashes/arrays and can contain t

[pve-devel] [PATCH pve-manager] fix #3369: auto-start vms after failed pbs backup

2021-04-07 Thread Dylan Whyte
Fixes an issue in which a VM fails to automatically restart after a failed stop-mode backup to pbs. Signed-off-by: Dylan Whyte --- PVE/VZDump.pm | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) Notes: 1. The 1sec time delay was needed, as the check to see if the VM is runni

Re: [pve-devel] [PATCH pve-manager] fix #3369: auto-start vms after failed pbs backup

2021-04-07 Thread Fabian Grünbichler
On April 7, 2021 4:23 pm, Dylan Whyte wrote: > Fixes an issue in which a VM fails to automatically restart after a > failed stop-mode backup to pbs. > > Signed-off-by: Dylan Whyte > --- > PVE/VZDump.pm | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > Notes: > 1. The 1