[pve-devel] [PATCH v2 manager 11/11] ui: restore: add live-restore checkbox

2021-03-03 Thread Stefan Reiter
Add 'isPBS' parameter for Restore window so we can detect when to show the 'live-restore' checkbox. Includes a warning about this feature being experimental for now. Signed-off-by: Stefan Reiter --- v2: * unchanged www/manager6/grid/BackupView.js| 6 - www/manager6/storage/BackupView

[pve-devel] [PATCH v2 qemu-server 09/11] extract register_qmeventd_handle to QemuServer.pm

2021-03-03 Thread Stefan Reiter
...to be reused by live-restore. Signed-off-by: Stefan Reiter --- v2: * unchanged PVE/QemuServer.pm| 28 PVE/VZDump/QemuServer.pm | 32 ++-- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE

[pve-devel] [PATCH v2 proxmox-backup-qemu 05/11] access: use bigger cache and LRU chunk reader

2021-03-03 Thread Stefan Reiter
Values chosen by fair dice roll, seems to be a good sweet spot on my machine where any less causes performance degradation but any more doesn't really make it go any faster. Keep in mind that those values are per drive in an actual restore. Signed-off-by: Stefan Reiter --- Depends on new proxmo

[pve-devel] [PATCH v2 qemu-server 07/11] cfg2cmd: allow PBS snapshots as backing files for drives

2021-03-03 Thread Stefan Reiter
Uses the custom 'alloc-track' filter node to redirect writes to the original drives target, while unwritten blocks will be read from the specified PBS snapshot. Signed-off-by: Stefan Reiter --- v2: * build logic directly into print_drive_commandline_full, instead of string replacements in conf

[pve-devel] [PATCH v2 pve-qemu 03/11] add alloc-track block driver patch

2021-03-03 Thread Stefan Reiter
See added patches for more info, overview: 0044: slightly increase PBS performance by reducing allocations 0045: slightly increase block-stream performance for Ceph 0046: don't crash with block-stream on RBD 0047: add alloc-track driver for live restore Signed-off-by: Stefan Reiter --- works bes

[pve-devel] [PATCH v2 proxmox-backup 04/11] RemoteChunkReader: add LRU cached variant

2021-03-03 Thread Stefan Reiter
Retain the old constructor for compatibility, most use cases don't need an LRU cache anyway. For now convert the 'mount' API to use the new variant, as the same set of chunks might be accessed multiple times in a random pattern there. Signed-off-by: Stefan Reiter --- v2: * unchanged src/bin/p

[pve-devel] [PATCH v2 00/11] live-restore for PBS snapshots

2021-03-03 Thread Stefan Reiter
First two patches are unrelated cleanups to QEMU patches-in-patches, patch 3 depends on them though. v2: * incorporated review feedback on qemu-server patches * updated and rebased QEMU patches for 5.2 * fixed live-restore to ceph RBD - note that restoring to user-space Ceph is still rather slow

[pve-devel] [PATCH v2 qemu-server 10/11] live-restore: register qmeventd handle

2021-03-03 Thread Stefan Reiter
Similar to backups, prevent QEMU from being killed by qmeventd during the live-restore, so a guest can shut itself down without aborting the restore operation. Note that the 'close' is only to be explicit, the handle will also be closed in case an operation errors (i.e. when the 'eval' is left).

[pve-devel] [PATCH v2 qemu-server 06/11] make qemu_drive_mirror_monitor more generic

2021-03-03 Thread Stefan Reiter
...so it works with other block jobs as well. Intended use case is block-stream, which also requires a new "auto" (wait only) completion mode, since it finishes automatically anyway. Signed-off-by: Stefan Reiter --- v2: * don't rename function, only add $op to the end and default to "mirror" P

[pve-devel] [PATCH v2 qemu-server 08/11] enable live-restore for PBS

2021-03-03 Thread Stefan Reiter
Enables live-restore functionality using the 'alloc-track' QEMU driver. This allows starting a VM immediately when restoring from a PBS snapshot. The snapshot is mounted into the VM, so it can boot from that, while guest reads and a 'block-stream' job handle the restore in the background. If an er

[pve-devel] [PATCH v2 pve-qemu 02/11] move bitmap-mirror patches to seperate folder

2021-03-03 Thread Stefan Reiter
...instead of having them in the middle of the backup related patches. These might (hopefully) become upstream at some point as well. Signed-off-by: Stefan Reiter --- Unrelated to rest of series. ...-support-for-sync-bitmap-mode-never.patch} | 30 +++--- ...support-for-conditional-and-

[pve-devel] [PATCH v2 pve-qemu 01/11] clean up pve/ patches by merging

2021-03-03 Thread Stefan Reiter
No functional change intended. Signed-off-by: Stefan Reiter --- Unrelated to rest of series. ...ckup-proxmox-backup-patches-for-qemu.patch | 665 ++--- ...estore-new-command-to-restore-from-p.patch | 18 +- ...-coroutines-to-fix-AIO-freeze-cleanu.patch | 914 -- ...-su

Re: [pve-devel] [PATCH RFC storage] rbd: fix #3286 add namespace support

2021-03-03 Thread aderumier
Hi, I wasn't aware about namespace support in ceph rbd, that's great :) Is they any plan on the roadmap to generalize namespace, but at vm level ? I'm still looking for easy cross-cluster vm migration  with shared storage. I was thinking about something simple like /etc/pve//qemu-server// with

[pve-devel] [PATCH qemu-server 2/4] config: parse: also warn about invalid lines

2021-03-03 Thread Fabian Ebner
as we already do for containers. Signed-off-by: Fabian Ebner --- PVE/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 43d7c6b..4a17a37 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2215,6 +2215,8 @@ sub parse_vm_config {

[pve-devel] [PATCH container 3/4] vmstatus: make boolean value explicit

2021-03-03 Thread Fabian Ebner
as otherwise the empty string is printed with 'pct status --verbose' when it's not a template. Signed-off-by: Fabian Ebner --- src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index bae236b..23a7b06 100644 --- a/src/PVE/LXC.pm ++

[pve-devel] [PATCH-SERIES] small improvements for parsing and printing

2021-03-03 Thread Fabian Ebner
Explicitly show 'template: 0' instead of 'template: ' for the verbose status calls, and handle empty '-list' values for LXC configs. qemu-server: Fabian Ebner (2): vmstatus: make boolean value explicit config: parse: also warn about invalid lines PVE/QemuServer.pm | 4 +++- 1 file changed,

[pve-devel] [PATCH qemu-server 1/4] vmstatus: make boolean value explicit

2021-03-03 Thread Fabian Ebner
as otherwise the empty string is printed with 'qm status --verbose' when it's not a template. Signed-off-by: Fabian Ebner --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a498444..43d7c6b 100644 --- a/PVE/QemuS

[pve-devel] [PATCH container 4/4] config: parse: also allow empty values

2021-03-03 Thread Fabian Ebner
because they are valid for '-list' formats and it makes the behavior match with what we do for VM configs. The new pattern is the same that is used for VM configs. Because it is a non-greedy pattern, trailing whitespaces will not be included in the value anymore. This /should/ cause no problems and

[pve-devel] [PATCH v2 guest-common 1/3] mention prune behavior for the remove parameter

2021-03-03 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- First version here (it's been a while): https://lists.proxmox.com/pipermail/pve-devel/2020-October/045585.html Changes from v1: * Space lines more evenly to get below 80 char limit. PVE/VZDump/Common.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[pve-devel] [PATCH v2 manager 3/3] fix #2745: ui: backup: allow users to specify remove=1

2021-03-03 Thread Fabian Ebner
A user with Datastore.AllocateSpace, VM.Audit, VM.Backup can already remove backups from the GUI manually, so it shouldn't be a problem if they can set the remove flag when starting a manual backup in the GUI. Signed-off-by: Fabian Ebner --- Changes from v1: * Rebase on current master. *

[pve-devel] [PATCH v2 manager 2/3] partially fix #2745: vzdump: use default for remove parameter

2021-03-03 Thread Fabian Ebner
The initial default from the $confdesc is 1 anyways, and like this changing the default in /etc/vzdump.conf to 0 actually works. Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 0345d2f3..02858d8e 100644 --- a/

Re: [pve-devel] [PATCH RFC storage] rbd: fix #3286 add namespace support

2021-03-03 Thread Fabian Grünbichler
On March 3, 2021 11:10 am, aderum...@odiso.com wrote: > Is they any plan on the roadmap to generalize namespace, but at vm > level ? > > I'm still looking for easy cross-cluster vm migration  with shared > storage. I recently picked up the remote migration feature, FWIW ;) > > I was thinking ab

[pve-devel] applied: [PATCH v2 pve-qemu 01/11] clean up pve/ patches by merging

2021-03-03 Thread Thomas Lamprecht
On 03.03.21 10:56, Stefan Reiter wrote: > No functional change intended. > > Signed-off-by: Stefan Reiter > --- > > Unrelated to rest of series. > > ...ckup-proxmox-backup-patches-for-qemu.patch | 665 ++--- > ...estore-new-command-to-restore-from-p.patch | 18 +- > ...-coroutines-to-

[pve-devel] applied: [PATCH v2 pve-qemu 02/11] move bitmap-mirror patches to seperate folder

2021-03-03 Thread Thomas Lamprecht
On 03.03.21 10:56, Stefan Reiter wrote: > ...instead of having them in the middle of the backup related patches. > These might (hopefully) become upstream at some point as well. > > Signed-off-by: Stefan Reiter > --- > > Unrelated to rest of series. > > ...-support-for-sync-bitmap-mode-never.p

[pve-devel] applied: [PATCH qemu-server 2/4] config: parse: also warn about invalid lines

2021-03-03 Thread Thomas Lamprecht
On 03.03.21 12:01, Fabian Ebner wrote: > as we already do for containers. > > Signed-off-by: Fabian Ebner > --- > PVE/QemuServer.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.co

Re: [pve-devel] [PATCH qemu-server 1/4] vmstatus: make boolean value explicit

2021-03-03 Thread Thomas Lamprecht
On 03.03.21 12:01, Fabian Ebner wrote: > as otherwise the empty string is printed with 'qm status --verbose' when > it's not a template. > > Signed-off-by: Fabian Ebner > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/QemuServer.pm b/PVE/Qe

Re: [pve-devel] [PATCH container 3/4] vmstatus: make boolean value explicit

2021-03-03 Thread Thomas Lamprecht
On 03.03.21 12:01, Fabian Ebner wrote: > as otherwise the empty string is printed with 'pct status --verbose' when > it's not a template. > > Signed-off-by: Fabian Ebner > --- > src/PVE/LXC.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC