I'm going to try and come up with a v2 that re-uses the more complete
'email' pattern from pve-common.
On 12.02.21 13:23, Fabian Ebner wrote:
to make it more compatible to what we had previously. In pve-manger,
split_list() is called on the parameter, so any whitespaces and even stand-alone
','
hi,
thanks for responding!
On Wed, Feb 10, 2021 at 05:20:59PM +0100, Stoiko Ivanov wrote:
> Thanks for looking into this!
>
> On Wed, 10 Feb 2021 17:01:42 +0100
> Oguz Bektas wrote:
>
> > default to 0.0.0.0 to preserve backwards behavior
> >
> > Signed-off-by: Oguz Bektas
> > ---
> > PVE/Se
To be used for the mailto vzdump parameter.
Signed-off-by: Fabian Ebner
---
New in v2.
src/PVE/JSONSchema.pm | 12
1 file changed, 12 insertions(+)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 5870b69..20d72b3 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/J
to re-use a line here and with the next patch.
Signed-off-by: Fabian Ebner
---
New in v2.
PVE/VZDump/Common.pm | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm
index af141de..eceea7f 100644
--- a/PVE/VZDump/Common.pm
+++ b/P
as it now also includes tests for new() with non-retention options.
Signed-off-by: Fabian Ebner
---
No changes from v1.
test/Makefile | 8
test/{vzdump_new_retention_test.pl => vzdump_new_test.pl} | 0
2 files changed, 4 insertions(+), 4 del
Signed-off-by: Fabian Ebner
---
No changes from v1.
PVE/API2/VZDump.pm | 11 +--
PVE/VZDump.pm | 21 +
2 files changed, 22 insertions(+), 10 deletions(-)
diff --git a/PVE/API2/VZDump.pm b/PVE/API2/VZDump.pm
index 806ac7fd..44376106 100644
--- a/PVE/API2/VZDump.
especially regarding the whitespace-agnostic behavior. And while we're at it,
also use the more complete email regex from pve-common.
Changes from v1:
* re-use the email regex from pve-common
* improve printing out mailto parameters to the cron file
common:
Fabian Ebner (2):
sendmail:
In addition to relying on shellquote(), it's still nice to avoid printing out
unnecessary whitespaces, especially newlines.
Signed-off-by: Fabian Ebner
---
New in v2.
PVE/VZDump/Common.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm
index ecee
Shellquote is needed for '~', and while it doesn't help with '-', there should
be no problem, because options are separated from mailto since commit
216a3f4f131693dc4bbad5e06e96a61baef5f5e9.
Signed-off-by: Fabian Ebner
---
New in v2.
Since JSONSchema already uses Tools, the pattern has to live
because it is a more complete pattern. Also, 'mailto' was a '-list' format in
PVE 6.2 and earlier, so this also fixes whitespace-related backwards
compatibility. In particular, this fixes creating a backup job in the GUI
without setting an address, which passes along ''.
For example,
> vzdump 153
Re-use the existing code, by allowing special kinds of 'tests' that just set
the options that are tested for.
Signed-off-by: Fabian Ebner
---
No changes from v1.
Dependency bump for pve-guest-common is needed.
test/vzdump_new_retention_test.pl | 174 +-
1 file chan
Bump in case this has been missed. :)
The patches should still apply fine. (just tested)
On 12/15/20 1:48 PM, Aaron Lauterer wrote:
This series implements a new feature which allows users to easily
reassign disks between VMs. Currently this is only possible with one of
the following manual step
This patch series adds the GUI to the recent patch series [0] which
enables the reassignment of disks between VMs.
For this to work, the backend patch series [0] needs to be applied and
installed.
v4 -> v5:
* rebased
* removed whitespace patch as these issues have been addressed in the
meantime
Signed-off-by: Aaron Lauterer
---
v3 -> v4i -> v5: rebased
v2 -> v3: nothing changed
v1 -> v2: fixed linter errors
www/manager6/Utils.js | 13 +
1 file changed, 13 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 7a1a7fb6..a298aac0 100644
--- a/www/man
Sometimes the reset button does not make sense and the isCreate option
does not fit as well because with it, the submit button will be enabled
right away instead of waiting for the form to be valid.
Signed-off-by: Aaron Lauterer
---
v1 -> v2 -> v3 -> v4 -> v5: nothing changed
This helps to reus
Adds a new button to the hardware panel labeled 'Reassign disk' and
enables a user to reassign a disk to another VM.
Signed-off-by: Aaron Lauterer
---
v4 -> v5: rebased
v3 -> v4:
* added check to not show template VMs in dropdown
* renamed disk parameter to `drive_name`
v2 -> v3:
* fixed check
On 12.02.21 18:28, Stoiko Ivanov wrote:
> Signed-off-by: Stoiko Ivanov
> ---
> did a quick test on my zfs storage-replication testcluster:
> * both systems failed to import their zfs pools upon boot (I'm quite sure
> it's related to upstream commit 642d86af0d91b2bf88d5ea34cb6888b03c39c459)
> * b
17 matches
Mail list logo
