[pve-devel] [PATCH docs] qm: fix hookscript example

Signed-off-by: Aaron Lauterer --- qm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 333b2e6..e0cce2b 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1333,7 +1333,7 @@ Hookscripts You can add a hook script to VMs with the config property `hookscript`.

[pve-devel] [PATCH ha-manager] ha-simulator: add xauth dependency

The xauth package is needed for the example in the docs to access the ha-simulator via ssh with x11 forwarding. On systems with a desktop environment the xauth package is usually already installed, but on a clean PVE installation it is missing. Signed-off-by: Aaron Lauterer --- I am not sure if

Re: [pve-devel] [PATCH ha-manager] ha-simulator: add xauth dependency

On 01.02.21 11:18, Aaron Lauterer wrote: > The xauth package is needed for the example in the docs to access the > ha-simulator via ssh with x11 forwarding. then the client needs it, and the client does not installs the ha-sim if it's used over ssh anyway? Even if required for the server side in

Re: [pve-devel] [PATCH docs] qm: fix hookscript example

but this is a style fix only, or? As a single minus always works for options in CLIHandler based executables (we have no short-opts there). On 01.02.21 11:06, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > qm.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [pve-devel] [PATCH docs] qm: fix hookscript example

On 2/1/21 11:47 AM, Thomas Lamprecht wrote: but this is a style fix only, or? As a single minus always works for options in CLIHandler based executables (we have no short-opts there). yes it is basically a style fix. It works with one dash. What does not work with one dash though (tested q

[pve-devel] [PATCH manager 2/7] ui: qemu/HardwareView: eslint: enforce "max-len" rule

Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 51c77246..fa72d9d3 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manag

[pve-devel] [PATCH manager 0/7] ui: qemu/HardwareView: fix GUI permission checks and make eslint happier

This series fixes two permission checks in the HardwareView panel: * Add -> EFI Disk button * Edit button for CDROM drives to only show them as enabled if the necessary permissions are available. Additionally it contains a few patches to make eslint happy. Aaron Lauterer (7): ui: qemu/Hardwar

[pve-devel] [PATCH manager 6/7] ui: qemu/HardwareView: check EFI Disk button permissions

Make sure that the `Add EFI Disk` button is disabled if the user does not have the needed permissions. Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/

[pve-devel] [PATCH manager 3/7] ui: qemu/HardwareView: eslint: enforce "no-useless-concat" rule

Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index fa72d9d3..cc707a2a 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6

[pve-devel] [PATCH manager 4/7] ui: qemu/HardwareView: eslint: enforce "no-shadow" rule

`confid` is overwritten in each step anyways, so it should be no problem to use it in the outer scope. Let's play it safe for `sm` and rename it in the function. Signed-off-by: Aaron Lauterer --- Not sure if my solutions are okay or if another approach is preferable. Didn't find any patches in

[pve-devel] [PATCH manager 1/7] ui: qemu/HardwareView: eslint: enforce "no-mixed-operators" rule

Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 116ab32f..51c77246 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/mana

[pve-devel] [PATCH manager 5/7] ui: qemu/HardwareView: change heuristic perms to const

Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 213a946f..80d6eec1 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/ma

[pve-devel] [PATCH manager 7/7] ui: qemu/HardwareView: add CDROM permission check to edit button

Add CDROM permission check to disable the Edit button if they are not present. Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index

[pve-devel] [PATCH cluster] pvecm: fix typo in description for 'updatecerts'

Signed-off-by: Oguz Bektas --- data/PVE/CLI/pvecm.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm index 107c4cb..5ac9ed3 100755 --- a/data/PVE/CLI/pvecm.pm +++ b/data/PVE/CLI/pvecm.pm @@ -551,7 +551,7 @@ __PACKAGE__->register_me

Re: [pve-devel] [PATCH qemu-server] cloudinit: add sshdeletehostkeys option

Le mercredi 27 janvier 2021 à 17:56 +0100, Mira Limbeck a écrit : > Thank you for the patch. > > It doesn't apply on the latest qemu-server master. Looks like your > Cloudinit.pm file already contained changes which are not part of the > patch. > > Was it just the previous patch you sent? > Hi,