Re: [pve-devel] [PATCH v2 qemu-server 1/2] tests: mock storage locking for migration tests

2021-01-12 Thread Fabian Ebner
I didn't notice yesterday, but it's actually strange that volume_is_base_and_used uses a storage lock. Its callers that plan to change volumes on the storage based on the check need to hold the lock instead. Otherwise it can happen that: 1. volume_is_base_and_used is called and the result is use

Re: [pve-devel] [PATCH 00/11] live-restore for PBS snapshots

2021-01-12 Thread aderumier
>>What's planned is a fully featured file-restore, including a GUI in PVE  >>(similar to what's already available for CTs in the PBS interface). Wonderful !  Thanks about the "proxmox-backup-client map", I'll try it. Le lundi 11 janvier 2021 à 17:42 +0100, Stefan Reiter a écrit : > On 1/11/21 4:

[pve-devel] sdn: looking to unify .cfg files, need opinions about config format

2021-01-12 Thread aderumier
Hi, I'm looking to unify sdn .cfg files with only 1 file, with something different than section config format. We have relationship like zones->vnets->subnets, so I was thinking about something like this: [zone myzone] type: vxlan option1: xxx option2: xxx [[vnet myvnet]] option1:

Re: [pve-devel] [PATCH qemu 02/11] PVE: block/pbs: fast-path reads without allocation if possible

2021-01-12 Thread Wolfgang Bumiller
On Mon, Jan 11, 2021 at 12:14:00PM +0100, Stefan Reiter wrote: > ...and switch over to g_malloc/g_free while at it to align with other > QEMU code. > > Tracing shows the fast-path is taken almost all the time, though not > 100% so the slow one is still necessary. I wonder if vectored reads could

[pve-devel] [PATCH qemu-server] api: qemu: make resize_vm async close #2315

2021-01-12 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- Resizing is now done asynchronous in a task. PVE/API2/Qemu.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index e8de4ea..379f34a 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3730,7 +3730

[pve-devel] [PATCH manager v3 04/10] ceph: add get api call for single pool

2021-01-12 Thread Alwin Antreich
Information of a single pool can be queried. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/Pools.pm | 99 ++ PVE/CLI/pveceph.pm | 4 ++ 2 files changed, 103 insertions(+) diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm index 24562456..

[pve-devel] [PATCH manager v3 03/10] ceph: add titles to ceph_pool_common_options

2021-01-12 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/Pools.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm index b9e295f5..24562456 100644 --- a/PVE/API2/Ceph/Pools.pm +++ b/PVE/API2/Ceph/Pools.pm @@ -112,10 +112,12 @@ my $ceph_pool_common_

[pve-devel] [PATCH manager v3 00/10] ceph: allow pools settings to be changed

2021-01-12 Thread Alwin Antreich
This set allows to edit pools via GUI & CLI. This should make it easier for users to adjust pool settings, since they don't have to go the ceph tool route. v1 -> v2: - move pools endpoint to a subclass - add pg autsocale status and settings - rework and flatten the grid view of ceph po

[pve-devel] [PATCH manager v3 06/10] ceph: gui: add autoscale & flatten pool view

2021-01-12 Thread Alwin Antreich
Letting the columns flex needs a flat column head structure. Signed-off-by: Alwin Antreich --- www/manager6/ceph/Pool.js | 138 ++ 1 file changed, 82 insertions(+), 56 deletions(-) diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index 271dc

[pve-devel] [PATCH manager v3 10/10] fix: ceph: always set pool size first

2021-01-12 Thread Alwin Antreich
Since Ceph Nautilus 14.2.10 and Octopus 15.2.2 the min_size of a pool is calculated by the size (round(size / 2)). When size is applied after min_size to the pool, the manual specified min_size will be overwritten. Signed-off-by: Alwin Antreich --- PVE/Ceph/Tools.pm | 61

[pve-devel] [PATCH manager v3 02/10] ceph: setpool, use parameter extraction instead

2021-01-12 Thread Alwin Antreich
of the unneeded ref copy for params. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/Pools.pm | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm index fac21301..b9e295f5 100644 --- a/PVE/API2/Ceph/Pools.pm +++ b/PVE/API2

[pve-devel] [PATCH manager v3 09/10] ceph: gui: add min num of PG

2021-01-12 Thread Alwin Antreich
this is used to fine-tune the ceph autoscaler Signed-off-by: Alwin Antreich --- www/manager6/ceph/Pool.js | 18 ++ 1 file changed, 18 insertions(+) diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index bd395956..9b8b68dd 100644 --- a/www/manager6/ceph/Pool.js

[pve-devel] [PATCH manager v3 07/10] ceph: set allowed minimal pg_num down to 1

2021-01-12 Thread Alwin Antreich
In Ceph Octopus the device_health_metrics pool is auto-created with 1 PG. Since Ceph has the ability to split/merge PGs, hitting the wrong PG count is now less of an issue anyhow. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/Pools.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[pve-devel] [PATCH manager v3 05/10] ceph: add autoscale_status to api calls

2021-01-12 Thread Alwin Antreich
the properties target_size_ratio, target_size_bytes and pg_num_min are used to fine-tune the pg_autoscaler and are set on a pool. The updated pool list shows now autoscale settings & status. Including the new (optimal) target PGs. To make it easier for new users to get/set the correct amount of PGs

[pve-devel] [PATCH manager v3 08/10] ceph: gui: rework pool input panel

2021-01-12 Thread Alwin Antreich
* add the ability to edit an existing pool * allow adjustment of autoscale settings * warn if user specifies min_size 1 * disallow min_size 1 on pool create * calculate min_size replica by size Signed-off-by: Alwin Antreich --- www/manager6/ceph/Pool.js | 249 +---

[pve-devel] [PATCH manager v3 01/10] api: ceph: subclass pools

2021-01-12 Thread Alwin Antreich
for better handling and since the pool endpoints got more entries. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/Makefile | 1 + PVE/API2/Ceph.pm | 378 +-- PVE/API2/Ceph/Pools.pm | 395 + PVE/CLI/pveceph.pm

Re: [pve-devel] [pbs-devel] [PATCH 00/11] live-restore for PBS snapshots

2021-01-12 Thread Thomas Lamprecht
On 11.01.21 16:50, aderum...@odiso.com wrote: > if we could make some kind of qemu-nbd + mount loop of the backup > volume for example. That is already possible through qemu-nbd tool (we have a PBS block driver backend), see: https://lists.proxmox.com/pipermail/pve-user/2020-July/171883.html Or

[pve-devel] applied-series: [PATCH i18n v2] Update German translations

2021-01-12 Thread Thomas Lamprecht
On 07.01.21 09:32, Dominic Jäger wrote: > Signed-off-by: Dominic Jäger > --- > Thank you, Stoiko! > > 1. Make unwanted translations empty => Removed in following patches > 2. Replace Abbild with Image > > de.po | 443 -- > 1 file changed,

[pve-devel] applied: [PATCH manager] ui: add netdevice: fix #3203: Use OS default model

2021-01-12 Thread Thomas Lamprecht
On 07.01.21 11:04, Dominic Jäger wrote: > In the VM create wizard we automatically set e1000 for Windows and virtio for > Linux. We should also do this when adding a network device in the hardware > view. > > OSDefaults.generic.networkCard (=e1000) is always available. Hence, leave > this > as

Re: [pve-devel] [PATCH qemu 03/11] block: add alloc-track driver

2021-01-12 Thread Wolfgang Bumiller
one inline comment, otherwise lgtm On Mon, Jan 11, 2021 at 12:14:01PM +0100, Stefan Reiter wrote: > Add a new filter node 'alloc-track', which seperates reads and writes to > different children, thus allowing to put a backing image behind any > blockdev (regardless of driver support). Since we can

[pve-devel] applied: [PATCH qemu-server] tests: mock storage locking for migration tests

2021-01-12 Thread Thomas Lamprecht
On 11.01.21 13:34, Fabian Ebner wrote: > by doing it in a local directory instead of /var/lock/pve-manager, which is > used by the installed/non-test PVE code. This also covers the shared case, > which will become relevant after fixing #3229 (currently migration doesn't > touch disks on shared stor

Re: [pve-devel] [PATCH v2 qemu-server 1/2] tests: mock storage locking for migration tests

2021-01-12 Thread Thomas Lamprecht
first, I overlooked your v2 due to lack of reply to Stefans comment there I did not actually thought there would come one, but my followup seems mostly in line with your patch here, so no real harm done.. On 12.01.21 09:03, Fabian Ebner wrote: > I didn't notice yesterday, but it's actually strange

[pve-devel] [PATCH v2 qemu-server] api: qemu: make resize_vm async close #2315

2021-01-12 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- Resize is now done in a task. v1 -> v2: pass code that should be executed correctly to fork_worker PVE/API2/Qemu.pm | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index e8de4ea..0c5d50c 100644 ---

Re: [pve-devel] [PATCH v2 qemu-server] api: qemu: make resize_vm async close #2315

2021-01-12 Thread Oguz Bektas
hi, thanks for the fix :) Tested-by: Oguz Bektas On Tue, Jan 12, 2021 at 12:07:54PM +0100, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > Resize is now done in a task. > > v1 -> v2: pass code that should be executed correctly to fork_worker > > PVE/API2/Qemu.pm | 9 + >

Re: [pve-devel] [PATCH qemu-server] api: qemu: make resize_vm async close #2315

2021-01-12 Thread Thomas Lamprecht
On 12.01.21 10:44, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > Resizing is now done asynchronous in a task. seems like an API change, doesn't it? Maybe (did not checked) we could add an "async" boolean param and make the return type a optional string, can you please check if that

Re: [pve-devel] [pbs-devel] [PATCH 00/11] live-restore for PBS snapshots

2021-01-12 Thread Thomas Lamprecht
On 12.01.21 11:31, Thomas Lamprecht wrote: > On 11.01.21 16:50, aderum...@odiso.com wrote: >> if we could make some kind of qemu-nbd + mount loop of the backup >> volume for example. > > That is already possible through qemu-nbd tool (we have a PBS block driver > backend), > see: https://lists.pr

Re: [pve-devel] [PATCH v2 qemu-server] api: qemu: make resize_vm async close #2315

2021-01-12 Thread Thomas Lamprecht
On 12.01.21 12:07, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > Resize is now done in a task. > > v1 -> v2: pass code that should be executed correctly to fork_worker yeah that looked weird in the v1, did not checked it and assumed you tested the version you actually send at least

Re: [pve-devel] [PATCH qemu 03/11] block: add alloc-track driver

2021-01-12 Thread Stefan Reiter
On 12/01/2021 11:54, Wolfgang Bumiller wrote: one inline comment, otherwise lgtm On Mon, Jan 11, 2021 at 12:14:01PM +0100, Stefan Reiter wrote: Add a new filter node 'alloc-track', which seperates reads and writes to different children, thus allowing to put a backing image behind any blockdev (

Re: [pve-devel] [pbs-devel] [PATCH qemu 01/11] PVE: explicitly add libuuid as linking dependency

2021-01-12 Thread Thomas Lamprecht
On 11.01.21 12:13, Stefan Reiter wrote: > This previously only worked since linking against glusterfs pulls in > libuuid as well. Make it more explicit and allow debug builds without > glusterfs. > > Signed-off-by: Stefan Reiter > --- > > Unrelated to rest of series, just annoyed me. can you se

[pve-devel] applied-series: [PATCH-SERIES] add none audio backend

2021-01-12 Thread Thomas Lamprecht
On 07.01.21 18:02, Gilles Pietri wrote: > Add the 'none' audio backend as an option for qemu-server: it behaves > the same as the spice one (id=,driver=), and simply discards audio. > Add the option in the Web UI for audio configuration. applied series, much thanks for your contribution! __

Re: [pve-devel] [PATCH qemu-server 06/11] make qemu_drive_mirror_monitor more generic

2021-01-12 Thread Wolfgang Bumiller
On Mon, Jan 11, 2021 at 12:14:04PM +0100, Stefan Reiter wrote: > ...so it works with other block jobs as well. Intended use case is > block-stream, which also requires a new "auto" (wait only) completion > mode, since it finishes automatically anyway. > > Signed-off-by: Stefan Reiter > --- > PVE

[pve-devel] [PATCH docs] Revert "Document that active-backup is recommended for corosync"

2021-01-12 Thread Aaron Lauterer
This reverts commit 649098a64ecaffc7215ec0556e76787595b38e88. This seems to be related to the use of multicast in older corosync versions. Since corosync v3 is using unicast we can drop this --- pve-network.adoc | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/pve-network.

[pve-devel] [PATCH docs] qm: update section about audio devices

2021-01-12 Thread Aaron Lauterer
With the ability to configure the `none` backend, the audio section needs an update. Signed-off-by: Aaron Lauterer --- qm.adoc | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/qm.adoc b/qm.adoc index 9c54903..d72798c 100644 --- a/qm.adoc +++ b/qm.adoc @@ -79

[pve-devel] [PATCH manager] ui: qemu/audio: enable help button

2021-01-12 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/AudioEdit.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/www/manager6/qemu/AudioEdit.js b/www/manager6/qemu/AudioEdit.js index 2029bae1..0c74bfd8 100644 --- a/www/manager6/qemu/AudioEdit.js +++ b/www/manager6/qemu/Audio

Re: [pve-devel] [PATCH qemu 03/11] block: add alloc-track driver

2021-01-12 Thread Wolfgang Bumiller
On Tue, Jan 12, 2021 at 12:29:05PM +0100, Stefan Reiter wrote: > On 12/01/2021 11:54, Wolfgang Bumiller wrote: > > one inline comment, otherwise lgtm > > > > On Mon, Jan 11, 2021 at 12:14:01PM +0100, Stefan Reiter wrote: > > > Add a new filter node 'alloc-track', which seperates reads and writes t

Re: [pve-devel] [PATCH docs] qm: update section about audio devices

2021-01-12 Thread Stefan Reiter
On 12/01/2021 14:39, Aaron Lauterer wrote: With the ability to configure the `none` backend, the audio section needs an update. Signed-off-by: Aaron Lauterer --- qm.adoc | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/qm.adoc b/qm.adoc index 9c54903..d7