[pve-devel] [PATCH container] restore: fix fw.conf restore for PBS

2020-12-07 Thread Fabian Grünbichler
the 'files' command returns a list of hashes, and the filename is 'fw.conf.blob' not 'fw.conf'. Signed-off-by: Fabian Grünbichler --- Tested with container with and without firewall config. src/PVE/LXC/Create.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Cre

[pve-devel] applied: [PATCH container] restore: fix fw.conf restore for PBS

2020-12-07 Thread Thomas Lamprecht
On 07.12.20 09:18, Fabian Grünbichler wrote: > the 'files' command returns a list of hashes, and the filename is > 'fw.conf.blob' not 'fw.conf'. > > Signed-off-by: Fabian Grünbichler > --- > Tested with container with and without firewall config. > > src/PVE/LXC/Create.pm | 2 +- > 1 file chang

[pve-devel] applied-series: [PATCH manager 1/2] vzdump: warn when both storage and dumpdir are defined in vzdump.conf

2020-12-07 Thread Thomas Lamprecht
On 04.12.20 10:15, Fabian Ebner wrote: > and prefer storage, because the storage configuration might contain more > settings. Warning is preferable over dying, because all backups would be > affected (even if they don't use the vzdump.conf parameters) and the settings > could've been compatible (i.

[pve-devel] [PATCH proxmox] correct email in changelog

2020-12-07 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- `E: librust-proxmox-dev: debian-changelog-file-contains-invalid-email-address root@elsa` prevented a proper install proxmox/debian/changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox/debian/changelog b/proxmox/debian/changelog in

Re: [pve-devel] [PATCH http-server v2 1/5] add debug print helper

2020-12-07 Thread Thomas Lamprecht
On 04.12.20 18:56, Stoiko Ivanov wrote: > Suggested-by: Thomas Lamprecht > Signed-off-by: Stoiko Ivanov > --- > PVE/APIServer/AnyEvent.pm | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm > index c55da7f..7916bdd 100644 >

Re: [pve-devel] [PATCH http-server v2 2/5] accept-phase: fix conn_count "leak"

2020-12-07 Thread Thomas Lamprecht
On 04.12.20 18:56, Stoiko Ivanov wrote: > When handling new connections in 'accept_connections' the number of > active connections got increased before the AnyEvent::Handle > registered the callback which would decrement it on error/eof. > > Any error/die beforehand would skip the decrement, and l

Re: [pve-devel] [PATCH http-server v2 3/5] accept-phase: shutdown socket on early error

2020-12-07 Thread Thomas Lamprecht
On 04.12.20 18:56, Stoiko Ivanov wrote: > if an error happens before AnyEvent::Handle registers the cleanup > callback, we should shutdown the socket, when handling it. > > Co-Authored-by: Dominik Csapak > Signed-off-by: Stoiko Ivanov > --- > PVE/APIServer/AnyEvent.pm | 18 -- >

[pve-devel] applied: [PATCH proxmox] correct email in changelog

2020-12-07 Thread Thomas Lamprecht
On 07.12.20 10:58, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > `E: librust-proxmox-dev: debian-changelog-file-contains-invalid-email-address > root@elsa` prevented a proper install > proxmox/debian/changelog | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, t

Re: [pve-devel] [PATCH http-server v2 4/5] add debug log for problems during accept

2020-12-07 Thread Thomas Lamprecht
On 04.12.20 18:56, Stoiko Ivanov wrote: > Signed-off-by: Stoiko Ivanov > --- > PVE/APIServer/AnyEvent.pm | 4 > 1 file changed, 4 insertions(+) > > diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm > index a679006..0165264 100644 > --- a/PVE/APIServer/AnyEvent.pm > +++ b/PV

[pve-devel] [PATCH qemu-server] clone_disk: fix offline clone of efidisk

2020-12-07 Thread Fabian Ebner
by partially reverting 4df98f2f14348d0ed57529c4c04a1b5ffb840055 and fixing the line-length issue differently. The commit didn't update two later usages of $size, breaking copying the efidisk. The other usage as a parameter to qemu_img_convert() is luckily only cosmetic, for progress output. Signed

Re: [pve-devel] Compiling PBS on arm64

2020-12-07 Thread Kamil Trzciński
Thank you Fabian :) I was looking for just that. I was able to remove `.cargo/config` and use `crates.io` to compile packages. I will post more results once it is done, but I got it rebuild at least on amd64, and waiting for arm64 to finish. Kamil On Mon, Dec 7, 2020 at 8:54 AM Fabian Grünbichl

Re: [pve-devel] [PATCH manager] api: metrics/server: test connection on add/update

2020-12-07 Thread Thomas Lamprecht
On 03.12.20 17:55, Thomas Lamprecht wrote: > On 25.11.20 13:56, Dominik Csapak wrote: >> just a basic check, but better than not checking at all >> > > so, just had an issue with the network (some test IPv6 LAN here) and had a > metric > server configured on that net, thus pvestatd spammed the lo

Re: [pve-devel] [PATCH manager] api: metrics/server: test connection on add/update

2020-12-07 Thread Dominik Csapak
On 12/7/20 3:30 PM, Thomas Lamprecht wrote: On 03.12.20 17:55, Thomas Lamprecht wrote: On 25.11.20 13:56, Dominik Csapak wrote: just a basic check, but better than not checking at all so, just had an issue with the network (some test IPv6 LAN here) and had a metric server configured on that

[pve-devel] [PATCH manager] status/plugin: do not test connection if disabled

2020-12-07 Thread Dominik Csapak
so that if one disables the plugin (e.g. because it is offline), it will work even when the server is not reachable Signed-off-by: Dominik Csapak --- if my other series is ok, i'll rebase either this, or my other series, depending what gets applied first ;) PVE/Status/Plugin.pm | 3 +++ 1 file

[pve-devel] applied: [PATCH storage 2/2] nfs and cifs: implement backup notes helper

2020-12-07 Thread Thomas Lamprecht
reuse the one from DirPlugin by directing the call to it, but with the actual $class. This should stay stable, as we provide an ABI and try to always use $class->helpers. Signed-off-by: Thomas Lamprecht --- PVE/Storage/CIFSPlugin.pm | 9 + PVE/Storage/NFSPlugin.pm | 9 + 2 files

[pve-devel] applied: [PATCH storage 1/2] api: content/backup: handle deletion of notes

2020-12-07 Thread Thomas Lamprecht
Previous to this we did not called the plugins update_volume_notes at all in the case where a user delted the textarea, which results to passing a falsy value (''). Also adapt the currently sole implementation to delete the notes field in the undef or '' value case. This can be done safely, as we

[pve-devel] applied: [PATCH manager] status/plugin: do not test connection if disabled

2020-12-07 Thread Thomas Lamprecht
On 07.12.20 15:37, Dominik Csapak wrote: > so that if one disables the plugin (e.g. because it is offline), > it will work even when the server is not reachable > > Signed-off-by: Dominik Csapak > --- > if my other series is ok, i'll rebase either this, or my other > series, depending what gets a