Re: [pve-devel] [PATCH common 1/1] tools: add extract_sensitive_params

2020-12-03 Thread Thomas Lamprecht
On 02.12.20 10:21, Dominik Csapak wrote: > moved and generalized from pve-storage, since we'll need it > in more places > > Signed-off-by: Dominik Csapak > --- > src/PVE/Tools.pm | 24 > 1 file changed, 24 insertions(+) > > diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.

[pve-devel] [PATCH qemu-server] fix backpu/restore with ipv6/ports for pbs

2020-12-03 Thread Dominik Csapak
by copying the 'get_server_with_port' from PVE::Storage::PBSPlugin here and using it for generating the server Signed-off-by: Dominik Csapak --- ideally we would make the get_server_with_port sub in pve-storage public and use it here (like we do e.g. in container with 'run_raw_client_cmd') or eve

Re: [pve-devel] [PATCH manager 1/7] api: cluster/metricserver: prevent simultaneosly setting and deleting of property

2020-12-03 Thread Thomas Lamprecht
On 02.12.20 10:21, Dominik Csapak wrote: > like we do in other apis of section configs (e.g. storage) > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Cluster/MetricServer.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/API2/Cluster/MetricServer.pm > b/PVE/API2/Cluster/Metr

Re: [pve-devel] [PATCH common 1/1] tools: add extract_sensitive_params

2020-12-03 Thread Wolfgang Bumiller
> On 12/03/2020 9:47 AM Thomas Lamprecht wrote: > > > On 02.12.20 10:21, Dominik Csapak wrote: > > moved and generalized from pve-storage, since we'll need it > > in more places > > > > Signed-off-by: Dominik Csapak > > --- > > src/PVE/Tools.pm | 24 > > 1 file cha

[pve-devel] [PATCH V2 pve-network 1/7] evpn: frr: use datacenter default profile (lower timeouts)

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/PVE/Network/SDN/Controllers/EvpnPlugin.pm index e59c142..b997cca 100644 --- a/PVE/Network/SDN/Controller

[pve-devel] [PATCH V2 pve-network 0/7] various cleanups

2020-12-03 Thread Alexandre Derumier
changelog v2: - add more bugfix Alexandre Derumier (7): evpn: frr: use datacenter default profile (lower timeouts) get_local_vnets: display vnet alias in comments use canonical ipv6 address (RFC 5952) everywhere ipam : pve: don't register hostname/description zones: evpn: fix exitnodes

[pve-devel] [PATCH V2 pve-network 2/7] get_local_vnets: display vnet alias in comments

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/Network/SDN.pm b/PVE/Network/SDN.pm index c0c5672..ed891de 100644 --- a/PVE/Network/SDN.pm +++ b/PVE/Network/SDN.pm @@ -188,6 +188,8 @@ sub get_local_vnets {

[pve-devel] [PATCH V2 pve-network 4/7] ipam : pve: don't register hostname/description

2020-12-03 Thread Alexandre Derumier
we already have this informations in vm/ct config, and we are limited in space in pmxcfs Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams/PVEPlugin.pm | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/PVE/Network/SDN/Ipams/PVEPlugin.pm b/PVE/Network/SDN/I

[pve-devel] [PATCH V2 pve-network 7/7] subnets: api : add missing param in on_update_hook for update

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Subnets.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Network/SDN/Subnets.pm b/PVE/API2/Network/SDN/Subnets.pm index a3bc10b..07ef2e1 100644 --- a/PVE/API2/Network/SDN/Subnets.pm +++ b/PVE/API2/Network/SD

[pve-devel] [PATCH V2 pve-network 5/7] zones: evpn: fix exitnodes for snat

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 3 ++- PVE/Network/SDN/Zones/EvpnPlugin.pm | 9 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/PVE/Network/SDN/Controllers/EvpnPlugin.pm i

[pve-devel] [PATCH V2 pve-network 3/7] use canonical ipv6 address (RFC 5952) everywhere

2020-12-03 Thread Alexandre Derumier
we want only 1 format for ipam database Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 3 +-- PVE/Network/SDN/Ipams/PVEPlugin.pm| 5 +++-- PVE/Network/SDN/Subnets.pm| 9 - 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/PVE/N

[pve-devel] [PATCH V2 pve-network 6/7] zones: plugin : readd encode/decode value

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 21 - PVE/Network/SDN/Zones/Plugin.pm | 28 2 files changed, 28 insertions(+), 21 deletions(-) diff --git a/PVE/Network/SDN.pm b/PVE/Network/SDN.pm index ed891de..256a7c8 1006

Re: [pve-devel] [PATCH qemu-server] fix backpu/restore with ipv6/ports for pbs

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 09:43, Dominik Csapak wrote: > by copying the 'get_server_with_port' from PVE::Storage::PBSPlugin > here and using it for generating the server > > Signed-off-by: Dominik Csapak > --- > ideally we would make the get_server_with_port sub in pve-storage > public and use it here (like we

Re: [pve-devel] [PATCH common 1/1] tools: add extract_sensitive_params

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 10:16, Wolfgang Bumiller wrote: >> On 12/03/2020 9:47 AM Thomas Lamprecht wrote: >> On 02.12.20 10:21, Dominik Csapak wrote: >>> +for my $opt (@$sensitive_list) { >>> + # First handle deletions as explicitly setting `undef`, afterwards new >>> values may override >>> + # it. >

Re: [pve-devel] [PATCH qemu-server] fix backpu/restore with ipv6/ports for pbs

2020-12-03 Thread Dominik Csapak
On 12/3/20 10:27 AM, Thomas Lamprecht wrote: On 03.12.20 09:43, Dominik Csapak wrote: by copying the 'get_server_with_port' from PVE::Storage::PBSPlugin here and using it for generating the server Signed-off-by: Dominik Csapak --- ideally we would make the get_server_with_port sub in pve-stora

Re: [pve-devel] [PATCH qemu-server] fix backpu/restore with ipv6/ports for pbs

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 10:40, Dominik Csapak wrote: >> >> a few lines below, just out of context we see the sole use for all this  >> extracting: >> >> my $repo = "$username\@$server:$datastore"; >> >> So how about adding a get_repo sub to storage, or the PBSClient in pve-common >> (if we have a documented da

[pve-devel] [PATCH v9 pve-manager 14/18] sdn: browser: add onlinehelp

2020-12-03 Thread Alexandre Derumier
(needed, or the panel don't load) Signed-off-by: Alexandre Derumier --- www/manager6/sdn/Browser.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/sdn/Browser.js b/www/manager6/sdn/Browser.js index 1415f966..e5ffc0e8 100644 --- a/www/manager6/sdn/Browser.js +++ b/www/manager6

[pve-devel] [PATCH v9 pve-manager 01/18] sdn: vnetedit: add subnets && remove ip/mac

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/VnetEdit.js | 29 +++-- www/manager6/sdn/VnetView.js | 18 +++--- 2 files changed, 6 insertions(+), 41 deletions(-) diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js index aa40b41f..

[pve-devel] [PATCH v9 pve-manager 10/18] subnets: move ipam/dns in advanced section, and use "pve" as default ipam

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Utils.js | 3 ++- www/manager6/sdn/SubnetEdit.js | 6 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 8c939536..5440b972 100644 --- a/www/manager6/Utils.js +++ b/w

[pve-devel] [PATCH v9 pve-manager 08/18] add vnet option to subnets and remove subnets list from vnet

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile| 1 + www/manager6/form/SDNVnetSelector.js | 68 www/manager6/sdn/SubnetEdit.js | 7 +++ www/manager6/sdn/SubnetView.js | 5 ++ www/manager6/sdn/VnetEdit.js | 8 +--- w

[pve-devel] [PATCH v9 pve-manager 03/18] add sdn ipams

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 5 + www/manager6/Utils.js | 25 + www/manager6/dc/Config.js | 8 ++ www/manager6/form/SDNIpamSelector.js | 52 ++ www/manager6/sdn/IpamView.js | 131 +

[pve-devel] [PATCH v9 pve-manager 09/18] add vnet panel with vnet + subnets split view

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 5 +-- www/manager6/dc/Config.js | 10 +- www/manager6/sdn/SubnetEdit.js | 13 +++ www/manager6/sdn/SubnetView.js | 62 ++ www/manager6/sdn/VnetPanel.js | 39 +

[pve-devel] [PATCH v9 pve-manager 06/18] add sdn dns

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile| 4 + www/manager6/Utils.js| 20 www/manager6/dc/Config.js| 8 ++ www/manager6/form/SDNDnsSelector.js | 52 +++ www/manager6/sdn/DnsView.js | 131 ++

[pve-devel] [PATCH v9 pve-manager 15/18] sdn: evpn improvments

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile| 1 + www/manager6/Utils.js| 5 ++ www/manager6/sdn/ControllerView.js | 9 www/manager6/sdn/controllers/BgpEdit.js | 62 www/manager6/sdn/controllers/EvpnEdi

[pve-devel] [PATCH v9 pve-manager 05/18] sdn: subnets: ipam is optional

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/SubnetEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/sdn/SubnetEdit.js b/www/manager6/sdn/SubnetEdit.js index c9c6475b..2afa1a27 100644 --- a/www/manager6/sdn/SubnetEdit.js +++ b/www/manager6/sdn/Subn

[pve-devel] [PATCH v9 pve-manager 04/18] sdn: add PVEIpam

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 5 www/manager6/sdn/ipams/PVEIpamEdit.js | 34 +++ 3 files changed, 40 insertions(+) create mode 100644 www/manager6/sdn/ipams/PVEIpamEdit.js

[pve-devel] [PATCH v9 pve-manager 00/18] sdn: add subnets management

2020-12-03 Thread Alexandre Derumier
Changelogv2: - add ipams gui Changelogv3: - add internal pve ipam form - ipam is optional for subnets Changelogv4: - add dns changelogv5: - move subnets to vnet split panel (like ipsets) - move controllers, ipams, dns to a new options panel changelogv6: - display pending grid - move dns/i

[pve-devel] [PATCH v9 pve-manager 02/18] add sdn subnets

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 2 + www/manager6/dc/Config.js | 8 +++ www/manager6/sdn/SubnetEdit.js | 95 + www/manager6/sdn/SubnetView.js | 107 + 4 files changed, 212 insertions(+) c

[pve-devel] [PATCH v9 pve-manager 07/18] subnets: add dns fields

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/SubnetEdit.js | 35 ++ 1 file changed, 35 insertions(+) diff --git a/www/manager6/sdn/SubnetEdit.js b/www/manager6/sdn/SubnetEdit.js index 2afa1a27..ac9a40ea 100644 --- a/www/manager6/sdn/SubnetEdit.js +++ b/w

[pve-devel] [PATCH v9 pve-manager 11/18] sdn: add options panel + move controller/ipam/dns view

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 24 +++-- www/manager6/sdn/ControllerView.js | 1 + www/manager6/sdn/DnsView.js| 1 + www/manager6/sdn/IpamView.js | 2 ++ www/manager6/sdn/OptionsPan

[pve-devel] [PATCH v9 pve-manager 16/18] sdn: update onlinehelp links

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/ControllerView.js | 2 +- www/manager6/sdn/OptionsPanel.js | 2 +- www/manager6/sdn/ZoneView.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/ControllerView.js b/www/manager6/sdn/ControllerVi

[pve-devel] [PATCH v9 pve-manager 17/18] sdn : zone content view: add alias && resize column

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/ZoneContentView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/ZoneContentView.js b/www/manager6/sdn/ZoneContentView.js index 20a5fe1e..7069e52a 100644 --- a/www/manager6/sdn/ZoneConten

[pve-devel] [PATCH v9 pve-manager 18/18] sdn: add pending state column with hover tip

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Utils.js | 71 +++--- www/manager6/sdn/ControllerView.js | 17 +++ www/manager6/sdn/SubnetView.js | 12 - www/manager6/sdn/VnetView.js | 8 www/manager6/sdn/ZoneView.js | 27 +++--

[pve-devel] [PATCH v9 pve-manager 13/18] move ipams && dns options to zone

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Utils.js| 4 +-- www/manager6/sdn/SubnetEdit.js | 39 +- www/manager6/sdn/SubnetView.js | 23 ++- www/manager6/sdn/VnetEdit.js | 10 ++- www/manager6/sdn/ZoneView.js

[pve-devel] [PATCH v9 pve-manager 12/18] sdn: display pending values

2020-12-03 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Utils.js | 29 ++ www/manager6/sdn/ControllerView.js | 39 +--- www/manager6/sdn/SubnetView.js | 49 +++--- www/manager6/sdn/VnetView.js | 31 +--

[pve-devel] [PATCH common/storage/qemu-server] refactor pbs repo url generation

2020-12-03 Thread Dominik Csapak
moves it to pve-commons PBSClient and change qemu-server and pve-storage to use it this fixes issues with ipv6/ports in qemu-server pbs backups/restores pve-common: Dominik Csapak (1): PBSClient: add get_repository to generate repository urls from configs src/PVE/PBSClient.pm | 36 ++

[pve-devel] [PATCH storage 1/1] PBSPlugin: use get_repository from PVE::PBSClient

2020-12-03 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- PVE/Storage/PBSPlugin.pm | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm index 43bd72f..4d00472 100644 --- a/PVE/Storage/PBSPlugin.pm +++ b/PVE/Storage/PBSPlugin.pm

[pve-devel] [PATCH common 1/1] PBSClient: add get_repository to generate repository urls from configs

2020-12-03 Thread Dominik Csapak
we can use this everywhere we need to have a repository url Signed-off-by: Dominik Csapak --- src/PVE/PBSClient.pm | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm index 44e3176..f05471c 100644 -

[pve-devel] [PATCH qemu-server 1/1] use get_repository from PVE::PBSClient

2020-12-03 Thread Dominik Csapak
this fixes the issue that we did not generate the correct repository url for pbs storages that contained an ipv6 address or a port Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm| 6 ++ PVE/VZDump/QemuServer.pm | 7 ++- 2 files changed, 4 insertions(+), 9 deletions(-) diff -

[pve-devel] [PATCH storage] pbs: fix token auth with PVE::APIClient

2020-12-03 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- PVE/Storage/PBSPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm index 43bd72f..bc777f5 100644 --- a/PVE/Storage/PBSPlugin.pm +++ b/PVE/Storage/PBSPlugin.pm @@ -624,7 +624,7 @@ my

[pve-devel] [PATCH manager] pvestatd: fix container cpuset scheduling

2020-12-03 Thread Dominik Csapak
Since pve-container commit c48a25452dccca37b3915e49b7618f6880aeafb1 the code to get the cpuset controller path lives in pve-commons PVE::CGroup. Use that and improve the logging in case some error happens in the future. Such an error will only be logged once per pvestatd run, so it does not spam

Re: [pve-devel] [PATCH manager] pvestatd: fix container cpuset scheduling

2020-12-03 Thread Aaron Lauterer
Tested-By: Aaron Lauterer On 12/3/20 4:01 PM, Dominik Csapak wrote: Since pve-container commit c48a25452dccca37b3915e49b7618f6880aeafb1 the code to get the cpuset controller path lives in pve-commons PVE::CGroup. Use that and improve the logging in case some error happens in the future. Such

[pve-devel] applied: [PATCH manager] pvestatd: fix container cpuset scheduling

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 16:01, Dominik Csapak wrote: > Since pve-container commit > > c48a25452dccca37b3915e49b7618f6880aeafb1 > > the code to get the cpuset controller path lives in pve-commons PVE::CGroup. > Use that and improve the logging in case some error happens in the future. > Such an error will onl

Re: [pve-devel] [PATCH manager] pvestatd: fix container cpuset scheduling

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 16:35, Aaron Lauterer wrote: > Tested-By: Aaron Lauterer saw this to late for adding it into the commit message, still thanks for the feedback though! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin

[pve-devel] applied: [PATCH common 1/1] PBSClient: add get_repository to generate repository urls from configs

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 12:43, Dominik Csapak wrote: > we can use this everywhere we need to have a repository url > > Signed-off-by: Dominik Csapak > --- > src/PVE/PBSClient.pm | 36 +++- > 1 file changed, 31 insertions(+), 5 deletions(-) > > applied, thanks! ___

[pve-devel] applied: [PATCH common 1/1] tools: add extract_sensitive_params

2020-12-03 Thread Thomas Lamprecht
On 02.12.20 10:21, Dominik Csapak wrote: > moved and generalized from pve-storage, since we'll need it > in more places > > Signed-off-by: Dominik Csapak > --- > src/PVE/Tools.pm | 24 > 1 file changed, 24 insertions(+) > > applied, with some followups for the stuff co

[pve-devel] applied: [PATCH storage 1/1] PBSPlugin: use get_repository from PVE::PBSClient

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 12:43, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/Storage/PBSPlugin.pm | 25 + > 1 file changed, 5 insertions(+), 20 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@li

[pve-devel] applied: [PATCH storage] pbs: fix token auth with PVE::APIClient

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 14:03, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > PVE/Storage/PBSPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https

Re: [pve-devel] [PATCH manager] api: metrics/server: test connection on add/update

2020-12-03 Thread Thomas Lamprecht
On 25.11.20 13:56, Dominik Csapak wrote: > just a basic check, but better than not checking at all > so, just had an issue with the network (some test IPv6 LAN here) and had a metric server configured on that net, thus pvestatd spammed the log with "network unreachable" messages, and all my reso

[pve-devel] applied: [PATCH qemu-server 1/1] use get_repository from PVE::PBSClient

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 12:43, Dominik Csapak wrote: > this fixes the issue that we did not generate the correct repository > URL for pbs storages that contained an ipv6 address or a port > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer.pm| 6 ++ > PVE/VZDump/QemuServer.pm | 7 ++- >

[pve-devel] [PATCH http-server 3/3] add debug log for problems during accept

2020-12-03 Thread Stoiko Ivanov
Co-Authored-by: Dominik Csapak Signed-off-by: Stoiko Ivanov --- PVE/APIServer/AnyEvent.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm index 7038b07..d33f6b0 100644 --- a/PVE/APIServer/AnyEvent.pm +++ b/PVE/APIServer/AnyEvent.

[pve-devel] [PATCH http-server 1/3] accept-phase: fix conn_count "leak"

2020-12-03 Thread Stoiko Ivanov
When handling new connections in 'accept_connections' the number of active connections got increased before the AnyEvent::Handle registered the callback which would decrement it on error. Any error/die beforehand would skip the decrement, and leave the process in an endless loop upon exiting in wa

[pve-devel] [PATCH http-server 2/3] accept-phase: shutdown socket on early error

2020-12-03 Thread Stoiko Ivanov
if an error happens before AnyEvent::Handle registers the cleanup callback, we should shutdown the socket, when handling it. Co-Authored-by: Dominik Csapak Signed-off-by: Stoiko Ivanov --- PVE/APIServer/AnyEvent.pm | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[pve-devel] [PATCH http-server 0/3] improve error handling in accept_connections

2020-12-03 Thread Stoiko Ivanov
This patchset is the result of investigating a report in our community forum: https://forum.proxmox.com/threads/pveproxy-eats-available-ram.79617/ The first patch fixes an issue where pveproxy worker processes would never exit (and eat quite a bit of ram+cpu) when 'getpeername' returned an error.

Re: [pve-devel] [PATCH http-server 3/3] add debug log for problems during accept

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 19:43, Stoiko Ivanov wrote: > Co-Authored-by: Dominik Csapak > Signed-off-by: Stoiko Ivanov > --- > PVE/APIServer/AnyEvent.pm | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm > index 7038b07..d33f6b0 100644 > ---

Re: [pve-devel] [PATCH http-server 1/3] accept-phase: fix conn_count "leak"

2020-12-03 Thread Thomas Lamprecht
On 03.12.20 19:43, Stoiko Ivanov wrote: > When handling new connections in 'accept_connections' the number of > active connections got increased before the AnyEvent::Handle > registered the callback which would decrement it on error. > > Any error/die beforehand would skip the decrement, and leave