Re: [pve-devel] [PATCH manager 2/4] gui: Hardware View: Add GUI for importdisk

2020-11-20 Thread Dominic Jäger
This is actually broken, sorry. I'm just fixing it. But clicking through the wizard should work. On Thu, Nov 19, 2020 at 10:46:18AM +0100, Dominic Jäger wrote: > Make importing single disks easier. > Required to import a whole VM via GUI. > > Signed-off-by: Dominic Jäger > --- > www/manager6/q

Re: [pve-devel] Improve container backup speed dramatically (factor 100-1000)

2020-11-20 Thread Dominik Csapak
hi, it seems there are some misunderstandings as how the backup actually works, i'll try to clear that up On 11/20/20 8:18 AM, Carsten Härle wrote: Yes, that is how the current variable sized chunking algorithm works. ... "zfs diff" does not provide the information needed for our deduplicati

Re: [pve-devel] Improve container backup speed dramatically (factor 100-1000)

2020-11-20 Thread Dominik Csapak
arg, of course i forgot the reference to the rolling hash info... here it is: 0: https://en.wikipedia.org/wiki/Rolling_hash ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 5/6 v2] importwizard: Move buttons from bottom bar into panel

2020-11-20 Thread Dominic Jäger
As we've dropped the idea of using a single tab for each disk --- v2: Added www/manager6/qemu/ImportWizard.js | 42 +-- www/manager6/qemu/MultiHDEdit.js | 27 ++-- www/manager6/window/Wizard.js | 14 --- 3 files changed, 26 insertions(+),

[pve-devel] [PATCH qemu-server 1/6 v2] Move importdisk from qm to API

2020-11-20 Thread Dominic Jäger
Required to create a GUI for importdisk. Add parameters that enable directly attaching the disk to a bus/device with all known disk options. This avoids intermediate steps as unused disk. We allow different places as source * Regular VM images on PVE storages (Normal users + root) * Other disk im

[pve-devel] [PATCH manager 4/6 v2] gui: Add import VM wizard

2020-11-20 Thread Dominic Jäger
Signed-off-by: Dominic Jäger --- v2: This patch is unchanged, but the lines are changed by patch 6. I'll rebase that soon. PVE/API2/Nodes.pm | 48 +++ www/manager6/Makefile | 2 + www/manager6/form/ControllerSelector.js | 26 +- www/manager6/qemu/HDEd

[pve-devel] [PATCH manager 3/6 v2] gui: Add button & cmdmenu

2020-11-20 Thread Dominic Jäger
--- v2: unchanged www/manager6/Workspace.js| 15 +++ www/manager6/node/CmdMenu.js | 12 2 files changed, 27 insertions(+) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 3d0f3fec..6ee7c957 100644 --- a/www/manager6/Workspace.js +++ b/www/mana

[pve-devel] [PATCH manager 6/6 v2] importdisk gui: Make storages selectable again

2020-11-20 Thread Dominic Jäger
And fix parameters for the API Signed-off-by: Dominic Jäger --- v2: Added www/manager6/qemu/HDEdit.js | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index f8e811e1..0c5603ab 100644 --- a/www/manager6/qemu/HDE

[pve-devel] [PATCH qemu-server 0/1 v2] Importwizard

2020-11-20 Thread Dominic Jäger
v2: The first patches are untouched, i added two commits - Importwizard: Add & remove disk buttons moved from bottom bar into the panel -- This I was just working on - fixed gui for importing a single disk; Thank you for the hint Oguz -- As this is relatively important fix Patch 4 (import vm) has

[pve-devel] [PATCH manager 2/6 v2] gui: Hardware View: Add GUI for importdisk

2020-11-20 Thread Dominic Jäger
Make importing single disks easier. Required to import a whole VM via GUI. Signed-off-by: Dominic Jäger --- v2: This patch is unchanged, but the lines are changed by some subsequent patches. I'll rebase that soon. www/manager6/qemu/HDEdit.js | 134 ++ www/mana

[pve-devel] [PATCH manager 4/4] ui: add MetricServerView to Datacenter

2020-11-20 Thread Dominik Csapak
adds ui support for configuring the External Metric servers. for now, influxdb and graphite edit windows do not share code, it would be ideal to do that once we add more plugins Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/dc/Config.js |

[pve-devel] [PATCH manager 2/4] Status/Plugin: add id to schema

2020-11-20 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- PVE/Status/Plugin.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/Status/Plugin.pm b/PVE/Status/Plugin.pm index 4476c5dd..baf670ae 100644 --- a/PVE/Status/Plugin.pm +++ b/PVE/Status/Plugin.pm @@ -16,6 +16,10 @@ cfs_register_file('status.cfg', my

[pve-devel] [PATCH manager 0/4] add UI support for editing metric servers

2020-11-20 Thread Dominik Csapak
Adds the typical sectionconfig api entry points, as well as a basic CRUD ui under Datacenter -> Metric Server the next step is to adapt the documentation to no refer to editing the config anymore, adding some more useful information, as well as adding a onlinehelp link to the ui Dominik Csapak (4

[pve-devel] [PATCH manager 3/4] api2/cluster: add 'metricserver' api endpoints

2020-11-20 Thread Dominik Csapak
modeled after our typical api endpoints for sectionschema configs Signed-off-by: Dominik Csapak --- PVE/API2/Cluster.pm| 7 + PVE/API2/Makefile | 1 + PVE/API2/MetricServerConfig.pm | 238 + 3 files changed, 246 insertions(+) create m

[pve-devel] [PATCH manager 1/4] Status/Plugin: fix jsonschema for MTU

2020-11-20 Thread Dominik Csapak
jsonschema wants 'minimum' not 'min' Signed-off-by: Dominik Csapak --- PVE/Status/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Status/Plugin.pm b/PVE/Status/Plugin.pm index 26ac177e..4476c5dd 100644 --- a/PVE/Status/Plugin.pm +++ b/PVE/Status/Plugin.pm @@ -37

[pve-devel] [PATCH access-control] change PAM service name

2020-11-20 Thread Wolfgang Bumiller
Instead of 'common-auth' use 'proxmox-ve-auth', this way users can override PAM authentication settings via `/etc/pam.d/proxmox-ve-auth`. If the file does not exist, pam will use `/etc/pam.d/other` which by default behaves like `common-auth`. Note that this *can* be different from directly using

[pve-devel] applied: [PATCH manager 1/4] Status/Plugin: fix jsonschema for MTU

2020-11-20 Thread Thomas Lamprecht
On 20.11.20 10:50, Dominik Csapak wrote: > jsonschema wants 'minimum' not 'min' > > Signed-off-by: Dominik Csapak > --- > PVE/Status/Plugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list p

[pve-devel] applied: [PATCH manager 2/4] Status/Plugin: add id to schema

2020-11-20 Thread Thomas Lamprecht
On 20.11.20 10:50, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/Status/Plugin.pm | 4 > 1 file changed, 4 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/c

Re: [pve-devel] [PATCH manager 3/4] api2/cluster: add 'metricserver' api endpoints

2020-11-20 Thread Thomas Lamprecht
On 20.11.20 10:50, Dominik Csapak wrote: > modeled after our typical api endpoints for sectionschema configs > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Cluster.pm| 7 + > PVE/API2/Makefile | 1 + > PVE/API2/MetricServerConfig.pm | 238

[pve-devel] [PATCH pve_flutter_frontend v2 0/3] Add first welcome screen

2020-11-20 Thread Aaron Lauterer
This patch series introduces a "first welcome screen" shown on first start. Additionally, a class that stores the proxmox corporate identity (CI) colors is introduced. Changes to v1: * rework welcome screens, mainly use buttons instead of text links * cleanup code * use async where needed * fix i

[pve-devel] [PATCH pve_flutter_frontend v2 1/3] add class for Proxmox corporate identity colors

2020-11-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- lib/main.dart | 3 ++- lib/utils/promox_colors.dart | 10 ++ lib/widgets/pve_guest_overview_header.dart | 3 ++- lib/widgets/pve_node_overview.dart | 3 ++- 4 files changed, 16 insertions(+), 3 deletio

[pve-devel] [PATCH pve_flutter_frontend v2 2/3] add Proxmox symbol logo white orange

2020-11-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v1 -> v2: fix size of the x3 logo to be actually x3, measured by the width .../2.0x/Proxmox-logo-symbol-white-orange.png | Bin 0 -> 18270 bytes .../3.0x/Proxmox-logo-symbol-white-orange.png | Bin 0 -> 50346 bytes .../images/Proxmox-logo-symbol-white-orange

[pve-devel] [PATCH pve_flutter_frontend v2 3/3] Add first welcome screen

2020-11-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- passing through the page controller to the DotIndicator class is necessary as it needs to be a listenable. v1 -> v2: * change welcome screens * no color change * buttons instead of text links * use async where needed * code cleanup in several places * use Sin

Re: [pve-devel] [PATCH manager 4/4] ui: add MetricServerView to Datacenter

2020-11-20 Thread Thomas Lamprecht
On 20.11.20 10:50, Dominik Csapak wrote: > adds ui support for configuring the External Metric servers. > for now, influxdb and graphite edit windows do not share code, > it would be ideal to do that once we add more plugins > > Signed-off-by: Dominik Csapak > --- > www/manager6/Makefile

[pve-devel] applied: [PATCH access-control] change PAM service name

2020-11-20 Thread Thomas Lamprecht
On 20.11.20 11:05, Wolfgang Bumiller wrote: > Instead of 'common-auth' use 'proxmox-ve-auth', this way > users can override PAM authentication settings via > `/etc/pam.d/proxmox-ve-auth`. > > If the file does not exist, pam will use `/etc/pam.d/other` > which by default behaves like `common-auth`.

[pve-devel] [PATCH manager v2 2/2] ui: add MetricServerView to Datacenter

2020-11-20 Thread Dominik Csapak
adds ui support for configuring the External Metric servers. for now, influxdb and graphite edit windows do not share code, it would be ideal to do that once we add more plugins Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/dc/Config.js |

[pve-devel] [PATCH manager v2 0/2] add UI support for editing metric servers

2020-11-20 Thread Dominik Csapak
Adds the typical sectionconfig api entry points, as well as a basic CRUD ui under Datacenter -> Metric Server the next step is to adapt the documentation to no refer to editing the config anymore, adding some more useful information, as well as adding a onlinehelp link to the ui changes from v1:

[pve-devel] [PATCH manager v2 1/2] api2/cluster: add 'metricserver' api endpoints

2020-11-20 Thread Dominik Csapak
modeled after our typical api endpoints for sectionschema configs Signed-off-by: Dominik Csapak --- PVE/API2/Cluster.pm| 7 + PVE/API2/Cluster/Makefile | 1 + PVE/API2/Cluster/MetricServerConfig.pm | 228 + 3 files changed, 236 inserti

[pve-devel] [PATCH manager] fix iteration over hash without keys

2020-11-20 Thread Dominik Csapak
without 'keys' we iterate also over the values and use them as keys Signed-off-by: Dominik Csapak --- PVE/API2/ReplicationConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/ReplicationConfig.pm b/PVE/API2/ReplicationConfig.pm index 63b9cfca..8af62621 100644 --

[pve-devel] [PATCH manager] ui: fix 'no iommu found' message for setups

2020-11-20 Thread Dominik Csapak
sometimes, the first device in the pci api call is not in a separate iommu group (see e.g. [0]), but it is active and should work instead of testing the first, test all, and only show the message if no device has a set iommu group Signed-off-by: Dominik Csapak --- www/manager6/qemu/PCIEdit.js |

[pve-devel] applied: [PATCH manager] fix iteration over hash without keys

2020-11-20 Thread Thomas Lamprecht
On 20.11.20 15:14, Dominik Csapak wrote: > without 'keys' we iterate also over the values and use them as keys > > Signed-off-by: Dominik Csapak > --- > PVE/API2/ReplicationConfig.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks!

[pve-devel] applied: [PATCH manager] ui: fix 'no iommu found' message for setups

2020-11-20 Thread Thomas Lamprecht
On 20.11.20 15:29, Dominik Csapak wrote: > sometimes, the first device in the pci api call is not in a separate > iommu group (see e.g. [0]), but it is active and should work > > instead of testing the first, test all, and only show the message > if no device has a set iommu group > > Signed-off-

[pve-devel] [PATCH-SERIES] unify vzdump exclude-path behavior

2020-11-20 Thread Fabian Ebner
across different modes and also with a pbs storage. For suspend mode relative patterns are already working. To not break that behavior, and because pxar and proxmox-backup-client also support relative patterns, allow them for the other modes as well. pve-guest-common: Fabian Ebner (1): vzdump:

[pve-devel] [PATCH container 5/5] vzdump: pass along exclude patterns to proxmox-backup-client

2020-11-20 Thread Fabian Ebner
to make the behavior consistent across modes. Previously vzdump's exclude-path option only had an effect for suspend mode backups, as then the exclusion already happens when rsync copies the data during an earlier stage in the backup. Signed-off-by: Fabian Ebner --- src/PVE/VZDump/LXC.pm | 1 +

[pve-devel] [PATCH container 3/5] vzdump: turn findexcl into its own variable

2020-11-20 Thread Fabian Ebner
for easier readability. Signed-off-by: Fabian Ebner --- src/PVE/VZDump/LXC.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index 05d8495..c02c6e1 100644 --- a/src/PVE/VZDump/LXC.pm +++ b/src/PVE/VZDump/LXC.pm @@ -369,6 +369,7

[pve-devel] [PATCH guest-common 1/5] vzdump: update exclude-path description

2020-11-20 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/VZDump/Common.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 63a4689..389473b 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE/VZDump/Common.pm @@ -128,7 +128,9 @@ my $confdesc = { },

[pve-devel] [PATCH docs 2/5] vdzump: extend examples to also cover relative patterns

2020-11-20 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- vzdump.adoc | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/vzdump.adoc b/vzdump.adoc index 1c39680..a9a7b2f 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -288,7 +288,16 @@ You can also manually specify (additional) exclude paths, f

[pve-devel] [PATCH container 4/5] vzdump: allow relative exclude patterns for snapshot and stop mode

2020-11-20 Thread Fabian Ebner
to make the behavior consistent across modes. For suspend mode, relative patterns worked for a long time, because the exclusion already happens when rsync copies the data during an earlier stage of the backup. For the other two methods, the way the patterns are passed to tar (after the '--anchore

Re: [pve-devel] [PATCH v4 qemu-server 1/4] disk reassign: add API endpoint

2020-11-20 Thread Fabian Grünbichler
On October 2, 2020 10:23 am, Aaron Lauterer wrote: > The goal of this new API endpoint is to provide an easy way to move a > disk between VMs as this was only possible with manual intervention > until now. Either by renaming the VM disk or by manually adding the > disks volid to the config of the o

Re: [pve-devel] [PATCH v4 storage 3/4] add disk reassign feature

2020-11-20 Thread Fabian Grünbichler
small nit inline, also order in series is wrong - this patch goes first, the rest depends on it.. ;) needs a rebase/fixup since APIAGE/VER were bumped in the meantime.. On October 2, 2020 10:23 am, Aaron Lauterer wrote: > Functionality has been added for the following storage types: > > * dir b