On Mon, Nov 16, 2020 at 06:12:37PM +0100, Thomas Lamprecht wrote:
>
> Or move out even more than just the format string generation out, so that it
> becomes a simple loop calling
>
> $text .= render_task_plain($vmid, $task);
>
> or something similar to that.
my $namelength = 20;
$text .= sprint
On 17.11.20 09:35, Dominic Jäger wrote:
> On Mon, Nov 16, 2020 at 06:12:37PM +0100, Thomas Lamprecht wrote:
>>
>> Or move out even more than just the format string generation out, so that it
>> becomes a simple loop calling
>>
>> $text .= render_task_plain($vmid, $task);
>>
>> or something similar
applied, thanks :)
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
some comments inline, looks good otherwise
On 11/2/20 3:01 PM, Aaron Lauterer wrote:
When scaling the browsers content either via the browser itself or
because the OS has a different scaling / DPI setting, it can happen that
not all columns have enough space next to each other and thus the last
Less lines exeeding the character limit, less nesting, less duplicate code,
more readable sprintf arguments.
Co-authored-by: Thomas Lamprecht
Signed-off-by: Dominic Jäger
---
Middle ground sounds good to me :) And separate lines for arguments look nice.
PVE/VZDump.pm | 36 +++---
>>What is wrong with setting it as module option?
Nothing wrong. in 2016, Dietmar wanted it in kernel. (don't remember,
maybe the module option didn't exist at this time)
>>above hunk for the submodule shouldn't be included in the patch, it refers to
>>a git object which is not in ubuntus tree,
add a section describing how SSH tunnels are used in conjunction
with PVE. (for #2829)
Signed-off-by: Oguz Bektas
---
pvecm.adoc | 35 +++
1 file changed, 35 insertions(+)
diff --git a/pvecm.adoc b/pvecm.adoc
index 3820c17..10de0a1 100644
--- a/pvecm.adoc
+++ b/p
Fixes vma restore when the target is an iSCSI storage which expects that
initiatorname. Also avoids the need to always explicitly set the initiatorname
in PVE code, thus fixing moving efidisks from and to such iSCSI storages.
Signed-off-by: Fabian Ebner
---
The obvious alternative is to add the
On 11/17/20 10:29 AM, Dominik Csapak wrote:
some comments inline, looks good otherwise
On 11/2/20 3:01 PM, Aaron Lauterer wrote:
When scaling the browsers content either via the browser itself or
because the OS has a different scaling / DPI setting, it can happen that
not all columns have eno
On 11/17/20 12:41 PM, Aaron Lauterer wrote:
On 11/17/20 10:29 AM, Dominik Csapak wrote:
some comments inline, looks good otherwise
On 11/2/20 3:01 PM, Aaron Lauterer wrote:
When scaling the browsers content either via the browser itself or
because the OS has a different scaling / DPI setting
On 11/17/20 1:05 PM, Dominik Csapak wrote:
On 11/17/20 12:41 PM, Aaron Lauterer wrote:
On 11/17/20 10:29 AM, Dominik Csapak wrote:
some comments inline, looks good otherwise
On 11/2/20 3:01 PM, Aaron Lauterer wrote:
When scaling the browsers content either via the browser itself or
[..
On 17.11.20 11:46, Dominic Jäger wrote:
> Less lines exeeding the character limit, less nesting, less duplicate code,
> more readable sprintf arguments.
>
> Co-authored-by: Thomas Lamprecht
> Signed-off-by: Dominic Jäger
> ---
> Middle ground sounds good to me :) And separate lines for arguments
`useFieldContainer` doesn't seem to be used anymore in any of our
products:
* PVE
* PMG
* PBS
it therefore can be considered dead code.
Signed-off-by: Aaron Lauterer
---
v3: added newly after discussing on the mailing list that this is
probably dead code [0]
[0] https://lists.proxmox.com/piperm
When scaling the browsers content either via the browser itself or
because the OS has a different scaling / DPI setting, it can happen that
not all columns have enough space next to each other and thus the last
column is moved further below.
This happens especially on chromium bases browsers (e.g.
Dear,
a backed up container, they was restored under a new container ID get
equal all the networks settings from the orginal backup!
When then the admin change only the IP and start then the container, the
container they restored, use the SAME MAC!
Proxmox start 2 containers with same MAC but
On 11/17/20 10:27 PM, Detlef Bracker wrote:
Dear,
a backed up container, they was restored under a new container ID get
equal all the networks settings from the orginal backup!
When then the admin change only the IP and start then the container, the
container they restored, use the SAME MAC!
16 matches
Mail list logo
