[pve-devel] [PATCH storage 2/2] fix #1452: also log stderr of remote command with insecure storage migration

2020-10-01 Thread Fabian Ebner
Commit 8fe00d99449b7c80e81ab3c9826625a4fcd89aa4 already introduced the necessary logging for the secure code path, so presumably the bug was already fixed for most people. Delay the potential die for the send command to be able to log the ouput+error from the receive command. Like this we also see

[pve-devel] [PATCH storage 1/2] avoid output of zfs get command on volume import

2020-10-01 Thread Fabian Ebner
quiet takes care of both the error and success case. Without this, there are lines like: myzpool/vm-4352-disk-0@__replicate_4352-7_1601538554__ name myzpool/vm-4352-disk-0@__replicate_4352-7_1601538554__ - in the log if the dataset exists, and this information is already present in more reada

[pve-devel] [PATCH cluster 2/3] pmxcfs: set log domain in more places

2020-10-01 Thread Fabian Grünbichler
so that we can default to the set log domain instead of 'unknown' in cfs_debug/message/critical. used log domain values are copied from old G_LOG_DOMAIN behaviour. Signed-off-by: Fabian Grünbichler --- data/src/cfs-utils.h | 6 +++--- data/src/cfs-plug-func.c | 2 ++ data/src/cfs-plug-li

[pve-devel] [PATCH cluster 3/3] pmxcfs: enable QB log thread

2020-10-01 Thread Fabian Grünbichler
since pmxcfs is a multi-threaded application, and `man qblog.h` explicitly states: Thread safe non-blocking logging. Logging is only thread safe when threaded logging is in use. If you plan on logging from multiple threads, you must initialize libqb's logger thread and use qb_log_filter_ctl t

[pve-devel] [PATCH cluster 0/3] logging improvements

2020-10-01 Thread Fabian Grünbichler
noticed while debugging the (as it turns out) missing lock issue that qb_log is not thread-safe by default, this patch series switches to threaded, non-blocking logging. Fabian Grünbichler (3): pmxcfs: switch log domain to enum pmxcfs: set log domain in more places pmxcfs: enable QB log thre

[pve-devel] [RFC cluster 1/3] pmxcfs: switch log domain to enum

2020-10-01 Thread Fabian Grünbichler
GQuarks does not work correctly across threads, which can cause misattribution to log domains, e.g. [status] notice: members: 1/2116, 2/2454111 [status] notice: starting data syncronisation [status] notice: members: 1/2116, 2/2454111 [status] notice: starting data syncronisation [dcdb] notice: rec

Re: [pve-devel] [PATCH proxmox-acme 1/1] Close the acme standalone connection after sending a response

2020-10-01 Thread Fabian Grünbichler
On September 30, 2020 4:09 pm, Daniel Berteaud wrote: > Without this, the first req get a response, but not the next ones as the > listeners stays busy > Fixes #3048 > > Signed-off-by: Daniel Berteaud > --- > src/PVE/ACME/StandAlone.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [pve-devel] [PATCH proxmox-acme 1/1] Close the acme standalone connection after sending a response

2020-10-01 Thread Daniel Berteaud
- Le 1 Oct 20, à 11:15, Fabian Grünbichler f.gruenbich...@proxmox.com a écrit : > On September 30, 2020 4:09 pm, Daniel Berteaud wrote: >> Without this, the first req get a response, but not the next ones as the >> listeners stays busy >> Fixes #3048 >> >> Signed-off-by: Daniel Berteaud >>

[pve-devel] [PATCH guest-common 4/4] cleanup storeid_list creation

2020-10-01 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Not sure if the expression for map{} is too cluttered here... PVE/Replication.pm | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 60cfc67..132e8bb 100644 --- a/PVE/Replication.pm +++ b/PVE/R

[pve-devel] [PATCH guest-common 2/4] also consider storages from replication state on full removal

2020-10-01 Thread Fabian Ebner
This prevents left-over volumes in the following situation: 1. previous replication with volumes from different storages A and B exists 2. remove all volumes from storage B from the guest configuration 3. schedule full removal before the next normal replication 4. replication target still has the v

[pve-devel] [PATCH guest-common 3/4] rely only on storeid_list from replication state on full removal

2020-10-01 Thread Fabian Ebner
Using the information from the replication state alone should be more correct. E.g. the configuration might contain a new, not yet replicated volume when the full removal happens, causing unneeded scanning on the target node. Signed-off-by: Fabian Ebner --- Could be squashed with the previous pa

[pve-devel] [PATCH manager 1/4] remove all stale replicated volumes

2020-10-01 Thread Fabian Ebner
Commit 0433b86df6dfdf1d64ee09322719a02a91690707 introduced a regression where only stale replicated volumes with a snapshot with an older timestamp would be cleaned up. This restores the previous behavior where all stale replicated volumes, i.e. those with a replication snapshot, but not present in

[pve-devel] [PATCH manager] fix typo

2020-10-01 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/CLI/pvesr.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index cb79e2bf..2b8ce7f1 100644 --- a/PVE/CLI/pvesr.pm +++ b/PVE/CLI/pvesr.pm @@ -64,7 +64,7 @@ __PACKAGE__->register_method ({

Re: [pve-devel] [PATCH proxmox-acme 1/1] Close the acme standalone connection after sending a response

2020-10-01 Thread Fabian Grünbichler
On October 1, 2020 12:55 pm, Daniel Berteaud wrote: > - Le 1 Oct 20, à 11:15, Fabian Grünbichler f.gruenbich...@proxmox.com a > écrit : > >> On September 30, 2020 4:09 pm, Daniel Berteaud wrote: >>> Without this, the first req get a response, but not the next ones as the >>> listeners stays b

Re: [pve-devel] [PATCH qemu-server 1/2] fix #3010: add 'bootorder' parameter for better control of boot devices

2020-10-01 Thread Stefan Reiter
On 9/28/20 2:18 PM, Thomas Lamprecht wrote: On 24.09.20 16:11, Stefan Reiter wrote: (also fixes #3011) Deprecates the old 'boot' and 'bootdisk' options (they still work the same, but will get removed if a user sets a 'bootorder' parameter and ignored if both are set). I'd rather re-use boot i

[pve-devel] [PATCH manager] ui: FirewallRules.js: fix #3049 wider rule number column

2020-10-01 Thread Aaron Lauterer
Allows 2 digits rule numbers to be visible in the column. Made it a bit wider than needed to account for potentially wider font rendering on different platforms. Signed-off-by: Aaron Lauterer --- www/manager6/grid/FirewallRules.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[pve-devel] applied: [PATCH-SERIES v5] fix #2649: introduce prune-backups property for storages supporting backups

2020-10-01 Thread Thomas Lamprecht
On 29.09.20 10:37, Fabian Ebner wrote: > Make use of the new 'prune-backups' storage property with vzdump. > > Changes from v4: > * drop already applied patches > * rebase on current master > * fix typo > * add newline to error message > > Fabian Ebner (2): > Allow prune-backu

[pve-devel] applied: [PATCH manager] ui: FirewallRules.js: fix #3049 wider rule number column

2020-10-01 Thread Thomas Lamprecht
On 01.10.20 14:18, Aaron Lauterer wrote: > Allows 2 digits rule numbers to be visible in the column. Made it a bit > wider than needed to account for potentially wider font rendering on > different platforms. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/grid/FirewallRules.js | 2 +- >

Re: [pve-devel] [PATCH manager] ui: FirewallRules.js: fix #3049 wider rule number column

2020-10-01 Thread Thomas Lamprecht
On 01.10.20 14:18, Aaron Lauterer wrote: > Allows 2 digits rule numbers to be visible in the column. Made it a bit > wider than needed to account for potentially wider font rendering on > different platforms. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/grid/FirewallRules.js | 2 +- >

Re: [pve-devel] [PATCH manager] ui: FirewallRules.js: fix #3049 wider rule number column

2020-10-01 Thread Aaron Lauterer
On 10/1/20 5:10 PM, Thomas Lamprecht wrote: On 01.10.20 14:18, Aaron Lauterer wrote: Allows 2 digits rule numbers to be visible in the column. Made it a bit wider than needed to account for potentially wider font rendering on different platforms. Signed-off-by: Aaron Lauterer --- www/mana