Re: [pve-devel] [PATCH v8 pve-network 09/25] api2: increase version on apply/reload only

On 28.09.20 07:13, Alexandre DERUMIER wrote: > I'll send a patch today or tomorrow (works fine with the ./running-config > generated file) Would it help if I apply the v8 stuff until the patch which drops the version increase? > > I'm currently polishing the gui to diplay changes in grids. coo

Re: [pve-devel] [PATCH v8 pve-network 09/25] api2: increase version on apply/reload only

>>Would it help if I apply the v8 stuff until the patch which drops the >>version increase? I can already send a first patch (pve-cluster && pve-network) for handling /sdn/.running-version. Then I have another patch for pve-network api && pve-manager which need to be polished, mainly for d

[pve-devel] [PATCH V5 pve-cluster 4/5] add sdn/dns.cfg

--- data/PVE/Cluster.pm | 1 + data/src/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 2d2ca38..56d97bc 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -72,6 +72,7 @@ my $observed = { 'sdn/controllers.cfg' => 1,

[pve-devel] [PATCH V5 pve-cluster 1/5] add sdn/subnets.cfg

--- data/PVE/Cluster.pm | 1 + data/src/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 210ea85..42f5f9f 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -69,6 +69,7 @@ my $observed = { 'sdn/vnets.cfg' => 1, 's

[pve-devel] [PATCH V5 pve-cluster 0/5] sdn : add subnets management

Following pve-network Alexandre Derumier (5): add sdn/subnets.cfg add sdn/ipams.cfg add priv/ipam.db add sdn/dns.cfg rename sdn/.version to sdn/.running-config data/PVE/Cluster.pm | 6 +- data/src/status.c | 6 +- 2 files changed, 10 insertions(+), 2 deletions(-) -- 2.20.1

[pve-devel] [PATCH V5 pve-cluster 2/5] add sdn/ipams.cfg

--- data/PVE/Cluster.pm | 1 + data/src/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 42f5f9f..434bff8 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -70,6 +70,7 @@ my $observed = { 'sdn/zones.cfg' => 1, 's

[pve-devel] [PATCH V5 pve-cluster 3/5] add priv/ipam.db

--- data/PVE/Cluster.pm | 1 + data/src/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 434bff8..2d2ca38 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -56,6 +56,7 @@ my $observed = { 'priv/tfa.cfg' => 1, 'pr

[pve-devel] [PATCH V5 pve-cluster 5/5] rename sdn/.version to sdn/.running-config

--- data/PVE/Cluster.pm | 2 +- data/src/status.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 56d97bc..8ed1db5 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -73,7 +73,7 @@ my $observed = { 'sdn/subnet

[pve-devel] [PATCH v2 qemu-server 1/2] fix VM clone from snapshot with cloudinit disk

All volumes contained in $vollist are activated. In this case a snapshot of the volume. For cloudinit disks no snapshots are created so don't add it to the list of volumes to activate as it otherwise fails with no logical volume found. Signed-off-by: Mira Limbeck --- v2: unchanged PVE/API2/Qemu

[pve-devel] [PATCH v2 qemu-server 2/2] fix clone_disk failing for nonexistent cloudinit disk

After migration or a rollback the cloudinit disk might not be allocated, so volume_size_info() fails. As we override the value anyway for cloudinit and efi disks simply move the volume_size_info() call into the 'else' branch. Signed-off-by: Mira Limbeck --- v2: changed subject PVE/QemuServer.pm

[pve-devel] [PATCH v9 pve-network 04/26] zones: simple|evpn: add gateway ip from subnets to vnet

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones.pm | 4 +++- PVE/Network/SDN/Zones/EvpnPlugin.pm | 11 --- PVE/Network/SDN/Zones/Plugin.pm | 2 +- PVE/Network/SDN/Zones/QinQPlugin.pm | 2 +- PVE/Network/SDN/Zones/SimplePlugin.pm | 11 --- PVE/

[pve-devel] [PATCH v9 pve-network 02/26] vnets: add subnets

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/VnetPlugin.pm | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/PVE/Network/SDN/VnetPlugin.pm b/PVE/Network/SDN/VnetPlugin.pm index 384358c..47ca50b 100644 --- a/PVE/Network/SDN/VnetPlugin.pm +++ b/PV

[pve-devel] [PATCH v9 pve-network 09/26] api2: increase version on apply/reload only

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 3 +++ PVE/API2/Network/SDN/Controllers.pm | 6 -- PVE/API2/Network/SDN/Subnets.pm | 3 --- PVE/API2/Network/SDN/Vnets.pm | 3 --- PVE/API2/Network/SDN/Zones.pm | 6 -- 5 files changed, 3 insertion

[pve-devel] [PATCH v9 pve-network 21/26] dns: fix reverse dns

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 12 +++ PVE/Network/SDN/SubnetPlugin.pm | 1 + PVE/Network/SDN/Subnets.pm| 50 ++- 3 files changed, 40 insertions(+), 23 deletions(-) diff --git a/PVE/Network/SDN/Dns/Powe

[pve-devel] [PATCH v9 pve-network 17/26] ipam : pveplugin : fix find_next_free_ip

skip network && broadcast address Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams/PVEPlugin.pm | 11 ++- debian/control | 1 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/PVE/Network/SDN/Ipams/PVEPlugin.pm b/PVE/Network/SDN/Ipams/PVEPl

[pve-devel] [PATCH v9 pve-network 12/26] vnets: find_free_ip : add ipversion detection

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Vnets.pm | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/PVE/Network/SDN/Vnets.pm b/PVE/Network/SDN/Vnets.pm index d474037..0de3fd5 100644 --- a/PVE/Network/SDN/Vnets.pm +++ b/PVE/Network

[pve-devel] [PATCH v9 pve-network 16/26] Fix vnet gateway for routed setup + /32 pointopoint subnet

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/SubnetPlugin.pm | 6 -- PVE/Network/SDN/Zones/EvpnPlugin.pm | 10 -- PVE/Network/SDN/Zones/SimplePlugin.pm | 13 +++-- test/generateconfig.pl| 3 ++- 4 files changed, 25 insertions(+), 7 deletions(

[pve-devel] [PATCH v9 pve-network 11/26] add pve internal ipam plugin

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Ipams.pm | 1 + PVE/API2/Network/SDN/Subnets.pm| 4 +- PVE/Network/SDN/Ipams.pm | 2 + PVE/Network/SDN/Ipams/Makefile | 2 +- PVE/Network/SDN/Ipams/NetboxPlugin.pm | 4 +- PVE/Network/SDN/

[pve-devel] [PATCH v9 pve-network 19/26] zones: evpn|simple: add snat iptables rules

(use snat instead masquerade for performance) Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/EvpnPlugin.pm | 18 ++ PVE/Network/SDN/Zones/SimplePlugin.pm | 12 2 files changed, 30 insertions(+) diff --git a/PVE/Network/SDN/Zones/EvpnPlugin.pm b/PVE/N

[pve-devel] [PATCH v9 pve-network 13/26] vnets: add add_ip

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Vnets.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/Network/SDN/Vnets.pm b/PVE/Network/SDN/Vnets.pm index 0de3fd5..07bc9ff 100644 --- a/PVE/Network/SDN/Vnets.pm +++ b/PVE/Network/SDN/Vnets.pm @@

[pve-devel] [PATCH v9 pve-network 05/26] zone: add vnet_update_hook

move verify_tag code in this hook add mac address generation for simple && evpn plugin Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Vnets.pm | 4 ++-- PVE/Network/SDN/Zones/EvpnPlugin.pm | 19 +++ PVE/Network/SDN/Zones/Plugin.pm | 5 +++-- PVE/Netw

[pve-devel] [PATCH v9 pve-network 18/26] add vnet to subnets && remove subnetlist from vnet

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Subnets.pm | 31 +- PVE/Network/SDN/SubnetPlugin.pm | 59 --- PVE/Network/SDN/Subnets.pm| 34 +-- PVE/Network/SDN/VnetPlugin.pm | 23 --- PVE/Network/

[pve-devel] [PATCH v9 pve-network 07/26] subnet: fix on_delete_hook

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/SubnetPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Network/SDN/SubnetPlugin.pm b/PVE/Network/SDN/SubnetPlugin.pm index c555314..ea47684 100644 --- a/PVE/Network/SDN/SubnetPlugin.pm +++ b/PVE/Network/S

[pve-devel] [PATCH v9 pve-network 06/26] vnets: subnets: use cidr

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/SubnetPlugin.pm | 3 ++- PVE/Network/SDN/VnetPlugin.pm | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/Network/SDN/SubnetPlugin.pm b/PVE/Network/SDN/SubnetPlugin.pm index 1b790a6..c555314 100644 --- a/PVE/Network/

[pve-devel] [PATCH v9 pve-network 03/26] add subnets verifications hooks

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Subnets.pm | 5 - PVE/API2/Network/SDN/Vnets.pm | 9 +++-- PVE/Network/SDN/SubnetPlugin.pm | 15 +++ PVE/Network/SDN/VnetPlugin.pm | 8 +--- 4 files changed, 31 insertions(+), 6 deletions(-) diff --git a/PV

[pve-devel] [PATCH v9 pve-network 08/26] api2: subnet create: convert cidr to subnetid

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Subnets.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Network/SDN/Subnets.pm b/PVE/API2/Network/SDN/Subnets.pm index 3ef1d11..d18cf90 100644 --- a/PVE/API2/Network/SDN/Subnets.pm +++ b/PVE/API2/Network

[pve-devel] [PATCH v9 pve-network 00/26] add subnet plugin

This patch series add basic subnets managements. Subnets will be use for multiple things: - defined gateway ip on vnets - enable snat on a subnet - add cloudnit|dhcp default network configs (gateway, static routes, nameservers,searchdomain,) - add ipam management. (ip registrations to externa

[pve-devel] [PATCH v9 pve-network 23/26] zones: evpn : fix raise exception

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/EvpnPlugin.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Network/SDN/Zones/EvpnPlugin.pm b/PVE/Network/SDN/Zones/EvpnPlugin.pm index b89f4b1..d5ee56b 100644 --- a/PVE/Network/SDN/Zones/EvpnPlugin.pm +++ b/PVE/Network/SDN/Zo

[pve-devel] [PATCH v9 pve-network 25/26] don't allow subnets on vlanware vnet

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/SubnetPlugin.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Network/SDN/SubnetPlugin.pm b/PVE/Network/SDN/SubnetPlugin.pm index 341e9e0..8a216b6 100644 --- a/PVE/Network/SDN/SubnetPlugin.pm +++ b/PVE/Network/SDN/SubnetPlugin.pm @@

[pve-devel] [PATCH v9 pve-network 22/26] subnets: move api to /sdn/vnet//subnets && make vnet option not optionnal

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 7 --- PVE/API2/Network/SDN/Subnets.pm | 23 +-- PVE/API2/Network/SDN/Vnets.pm | 6 ++ PVE/Network/SDN/SubnetPlugin.pm | 2 +- 4 files changed, 24 insertions(+), 14 deletions(-) diff --git a/

[pve-devel] [PATCH v9 pve-network 26/26] generate sdn/.running-config on apply

This is the source configuration for generate local configuration /sdn/*.cfg are pending configs Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 2 +- PVE/Network/SDN.pm| 57 +++ PVE/Network/SDN/Controllers.pm| 1

[pve-devel] [PATCH v9 pve-network 24/26] subnet: make ipam not optionnal and use pve ipam as default

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Subnets.pm | 2 ++ PVE/Network/SDN/Ipams.pm| 2 ++ PVE/Network/SDN/SubnetPlugin.pm | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Network/SDN/Subnets.pm b/PVE/API2/Network/SDN/Subnets.pm index ab411

[pve-devel] [PATCH v9 pve-network 15/26] add dns plugin

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 7 + PVE/API2/Network/SDN/Dns.pm | 242 ++ PVE/API2/Network/SDN/Makefile | 2 +- PVE/Network/SDN/Dns.pm| 57 ++ PVE/Network/SDN/Dns/Makefile |

[pve-devel] [PATCH v9 pve-network 14/26] vnets: add del_ip + rework add_ip/find_free_ip

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams.pm | 12 PVE/Network/SDN/Subnets.pm | 60 ++ PVE/Network/SDN/Vnets.pm | 47 ++--- 3 files changed, 75 insertions(+), 44 deletions(-) diff --git a/PVE/Network/SDN/I

[pve-devel] [PATCH v9 pve-network 20/26] subnet: disable route option for now and add dns domain format

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/SubnetPlugin.pm | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/PVE/Network/SDN/SubnetPlugin.pm b/PVE/Network/SDN/SubnetPlugin.pm index 84303d1..6237867 100644 --- a/PVE/Network/SDN/SubnetPlugin.pm +++ b/

[pve-devel] [PATCH v9 pve-network 01/26] add subnet plugin

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 7 + PVE/API2/Network/SDN/Makefile | 2 +- PVE/API2/Network/SDN/Subnets.pm | 219 PVE/Network/SDN/Makefile| 2 +- PVE/Network/SDN/SubnetPlugin.pm | 115 + PVE/N

[pve-devel] [PATCH v9 pve-network 10/26] add ipams plugins

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm| 7 + PVE/API2/Network/SDN/Ipams.pm | 241 + PVE/API2/Network/SDN/Makefile | 2 +- PVE/API2/Network/SDN/Subnets.pm| 47 - PVE/Network/SDN/Ipams.pm

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

On September 25, 2020 6:29 pm, Alexandre DERUMIER wrote: > here a new hang: > > http://odisoweb1.odiso.net/test4/ okay, so at least we now know something strange inside pmxcfs is going on, and not inside corosync - we never reach the part where the broken node (again #13 in this hang!) sends ou

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

>>but, just to make sure, could you reproduce the issue once more, and >>then (with debug symbols installed) run >> >>$ gdb -ex 'set pagination 0' -ex 'thread apply all bt' --batch -p $(pidof >>pmxcfs) >> >>on all nodes at the same time? this should minimize the fallout and show >>us whether the t

[pve-devel] [PATCH v2 storage] ZFS: mount subvols in activate_volume

Makes it possible to clone and start a container whose ZFS subvols are not yet mounted for some reason. If a subvol cannot be mounted, there's a better error now: zfs error: cannot mount '/myzpool/subvol-103-disk-0': directory is not empty Previously, cloning would quietly do an "empty" clone, and

Re: [pve-devel] [PATCH qemu-server 1/2] fix #3010: add 'bootorder' parameter for better control of boot devices

On 24.09.20 16:11, Stefan Reiter wrote: > (also fixes #3011) > > Deprecates the old 'boot' and 'bootdisk' options (they still work the > same, but will get removed if a user sets a 'bootorder' parameter and > ignored if both are set). I'd rather re-use boot instead of adding a new property. Move

[pve-devel] [PATCH pve_flutter_frontend 1/3] add class for Proxmox corporate identity colors

Signed-off-by: Aaron Lauterer --- lib/main.dart | 3 ++- lib/utils/promox_colors.dart | 10 ++ lib/widgets/pve_guest_overview_header.dart | 3 ++- lib/widgets/pve_node_overview.dart | 3 ++- 4 files changed, 16 insertions(+), 3 deletio

[pve-devel] [PATCH pve_flutter_frontend 0/3] Add first welcome screen

This patch series introduces a "first welcome screen" shown on first start. Additionally, a class that stores the proxmox corporate identity (CI) colors is introduced. Feedback regarding content and design is welcome. Aaron Lauterer (3): add class for Proxmox corporate identity colors add Pr

Re: [pve-devel] [PATCH manager 2/2] ui: improve boot order editor with 'bootorder' support

On 24.09.20 16:11, Stefan Reiter wrote: > The new 'bootorder' property can express many more scenarios than the > old 'boot'/'bootdisk' ones. Update the editor so it can handle it. > > Features a grid with all supported boot devices which can be reordered > using drag-and-drop, as well as toggled

[pve-devel] [PATCH pve_flutter_frontend 2/3] add Proxmox symbol logo white orange

Signed-off-by: Aaron Lauterer --- .../2.0x/Proxmox-logo-symbol-white-orange.png | Bin 0 -> 18270 bytes .../3.0x/Proxmox-logo-symbol-white-orange.png | Bin 0 -> 44381 bytes .../images/Proxmox-logo-symbol-white-orange.png | Bin 0 -> 9199 bytes pubspec.yaml

[pve-devel] [PATCH pve_flutter_frontend 3/3] Add first welcome screen

Signed-off-by: Aaron Lauterer --- Same patch without temp png files. Thanks @Dominik for noticing .../ssl_validate/login_manager_screen.png | Bin 0 -> 20389 bytes .../login_manager_screen_settings.png | Bin 0 -> 37362 bytes lib/main.dart | 14 +- l

[pve-devel] [PATCH qemu 4/5] PVE-Backup: Use more coroutines and don't block on finishing

proxmox_backup_co_finish is already async, but previously we would wait for the coroutine using block_on_coroutine_fn(). Avoid this by scheduling pvebackup_co_complete_stream (and thus pvebackup_co_cleanup) as a real coroutine when calling from pvebackup_complete_cb. This is ok, since complete_stre

[pve-devel] [PATCH qemu 2/5] PVE: Add sequential job transaction support

Signed-off-by: Stefan Reiter --- include/qemu/job.h | 12 job.c | 24 2 files changed, 36 insertions(+) diff --git a/include/qemu/job.h b/include/qemu/job.h index 32aabb1c60..f7a6a0926a 100644 --- a/include/qemu/job.h +++ b/include/qemu/job.h @@

[pve-devel] [PATCH qemu-server 5/5] vzdump: log 'finishing' state

...and avoid printing 100% status twice Signed-off-by: Stefan Reiter --- PVE/VZDump/QemuServer.pm | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 7297795..575abb3 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/P

[pve-devel] [PATCH qemu 3/5] PVE-Backup: Use a transaction to synchronize job states

By using a JobTxn, we can sync dirty bitmaps only when *all* jobs were successful - meaning we don't need to remove them when the backup fails, since QEMU's BITMAP_SYNC_MODE_ON_SUCCESS will now handle that for us. To keep the rate-limiting and IO impact from before, we use a sequential transaction

[pve-devel] [PATCH pve-qemu 1/5] Add transaction patches and fix for blocking finish

With the transaction patches, patch 0026-PVE-Backup-modify-job-api.patch is no longer necessary, so drop it and rebase all following patches on top. Signed-off-by: Stefan Reiter --- The following three patches marked "qemu" in the email chain are the same as the ones being added here, for easier

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

Here a new test http://odisoweb1.odiso.net/test5 This has occured at corosync start node1: - start corosync : 17:30:19 node2: /etc/pve locked -- Current time : 17:30:24 I have done backtrace of all nodes at same time with parallel ssh at 17:35:22 and a coredump of all nodes

[pve-devel] applied: [PATCH v2 storage] ZFS: mount subvols in activate_volume

On 28.09.20 11:48, Fabian Ebner wrote: > Makes it possible to clone and start a container whose > ZFS subvols are not yet mounted for some reason. If a > subvol cannot be mounted, there's a better error now: > zfs error: cannot mount '/myzpool/subvol-103-disk-0': directory is not empty > > Previou

Re: [pve-devel] [RFC zfsonlinux 1/1] Add systemd-unit for importing specific pools

On 16.09.20 14:14, Stoiko Ivanov wrote: > [ --8<-- snip --8<-- ] > +diff --git a/etc/systemd/system/zfs-imp...@.service.in > b/etc/systemd/system/zfs-imp...@.service.in > +new file mode 100644 > +index 0..2db9fdaab > +--- /dev/null > b/etc/systemd/system/zfs-imp...@.service.in > +@@ -

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

also for test5, I have restarted corosync on node1 at 17:54:05, this have unlocked /etc/pve on other nodes I have submitted logs too : "corosync-restart-nodeX.log" - Mail original - De: "aderumier" À: "Proxmox VE development discussion" Envoyé: Lundi 28 Septembre 2020 17:59:20 Objet:

[pve-devel] applied: [Patch v3 access-control] fix #2947 login name for the LDAP/AD realm can be case-insensitive

On 08.09.20 14:09, Wolfgang Link wrote: > This is an optional for LDAP and AD realm. > The default behavior is case-sensitive. > > Signed-off-by: Wolfgang Link > --- > v1 -> v2:* naming of paramenter > * use grep instead of a loop, to avoid login errors > wi