Re: [pve-devel] [RFC PATCH qemu-server 1/8] tests: cfg2cmd: pin QEMU version

2025-03-06 Thread Fiona Ebner
Am 06.03.25 um 13:07 schrieb Dominik Csapak: > On 3/6/25 13:00, Fiona Ebner wrote: >> Am 06.03.25 um 11:44 schrieb Dominik Csapak: >>> @@ -528,3 +533,19 @@ if (my $file = shift) { >>>   } >>>     done_testing(); >> >> Nit: Since the check below can die, I'd put it at the very beginning >> rather th

Re: [pve-devel] [RFC PATCH qemu-server 1/8] tests: cfg2cmd: pin QEMU version

2025-03-06 Thread Dominik Csapak
On 3/6/25 13:00, Fiona Ebner wrote: Am 06.03.25 um 11:44 schrieb Dominik Csapak: but warn when we're out of date compared to the installed one, and die when we're one major (+1 minor) release behind. (the warning is not very visible when running tests or when building) We don't want to depend o

Re: [pve-devel] [RFC PATCH qemu-server 1/8] tests: cfg2cmd: pin QEMU version

2025-03-06 Thread Fiona Ebner
Am 06.03.25 um 11:44 schrieb Dominik Csapak: > but warn when we're out of date compared to the installed one, and die > when we're one major (+1 minor) release behind. > (the warning is not very visible when running tests or when building) > > We don't want to depend on the installed QEMU version