Re: [pve-devel] [PATCH v4 pve-storage 1/5] qcow2: add external snapshot support

2025-04-05 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >   > @@ -716,7 +721,11 @@ sub filesystem_path { >   > my $dir = $class->get_subdir($scfg, $vtype); >   > -    $dir .= "/$vmid" if $vtype eq 'images'; > +    if ($scfg->{snapext} && $snapname) { > + $name = $class->get_snap_volname($volname, $snapname); > +    } else { >

Re: [pve-devel] [PATCH v4 pve-storage 1/5] qcow2: add external snapshot support

2025-04-02 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > > > > > > and > > > probably $backing should not be an arbitrary path, but something > > > that > > > is resolved locally? > > I'll send the $snapname as param instead >>see my comments on the qemu-server side, I think it would be even >>better if we could just get rid

Re: [pve-devel] [PATCH v4 pve-storage 1/5] qcow2: add external snapshot support

2025-04-02 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 02.04.2025 > 10:01 CEST geschrieben: > > > >   > > @@ -716,7 +721,11 @@ sub filesystem_path { > >   > > my $dir = $class->get_subdir($scfg, $vtype); > >   > > -    $dir .= "/$vmid" if $vtype eq 'images'; > > +    if ($scfg->{snapext} && $snapname) { > > + $na

Re: [pve-devel] [PATCH v4 pve-storage 1/5] qcow2: add external snapshot support

2025-04-01 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 11.03.2025 11:28 CET geschrieben: some sort of description here would be great ;) > --- > src/PVE/Storage.pm | 4 +- > src/PVE/Storage/DirPlugin.pm | 1 + > src/PVE/Storage/Plugin.pm| 232 +-- > 3 fil