Re: [pve-devel] [PATCH v2 qemu-server 1/1] implement external snapshot

2024-10-25 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 23.10.2024 > 16:31 CEST geschrieben: > > > >>if we want the current volume to keep its name, and the snapshot > >>volume to actually contain *that* snapshot's data, we need some sort > >>of rename dance here as well.. i.e., rename the current volume to > >>have t

Re: [pve-devel] [PATCH v2 qemu-server 1/1] implement external snapshot

2024-10-23 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- ok, I think it could be possible to use blockdev-reopen to rename current filename https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg04455.html example: take snapshot : snap1 on vm-disk-100-disk-0.qcow2 - create a hardlink: ln vm-disk-100-disk-0.qcow2 vm-disk-100-disk

Re: [pve-devel] [PATCH v2 qemu-server 1/1] implement external snapshot

2024-10-23 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>if we want the current volume to keep its name, and the snapshot >>volume to actually contain *that* snapshot's data, we need some sort >>of rename dance here as well.. i.e., rename the current volume to >>have the snapshot volume name, then snapshot it back into the >>"curr

Re: [pve-devel] [PATCH v2 qemu-server 1/1] implement external snapshot

2024-10-23 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 30.09.2024 13:31 CEST geschrieben: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 108 -- > 1 file changed, 95 insertions(+), 13 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/Qemu