Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-18 Thread Fabian Grünbichler
On April 18, 2024 9:22 am, Fiona Ebner wrote: > Am 17.04.24 um 15:07 schrieb Dominik Csapak: >> On 4/17/24 12:52, Fiona Ebner wrote: >>> Am 16.04.24 um 15:18 schrieb Dominik Csapak:    we currently extract into the import storage in a directory named:    `.tmp__` which should not cla

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-18 Thread Fiona Ebner
Am 18.04.24 um 09:22 schrieb Fiona Ebner: diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index f8ea93d..bc073ef 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -2189,4 +2189,63 @@ sub get_import_metadata {   return $plugin->get_import_metadata($sc

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-18 Thread Fiona Ebner
Am 17.04.24 um 15:07 schrieb Dominik Csapak: > On 4/17/24 12:52, Fiona Ebner wrote: >> Am 16.04.24 um 15:18 schrieb Dominik Csapak: >>> >>>    we currently extract into the import storage in a directory named: >>>    `.tmp__` which should not clash with concurrent >>>    operations (though we do ex

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-17 Thread Fabian Grünbichler
> Dominik Csapak hat am 17.04.2024 16:07 CEST > geschrieben: > On 4/17/24 15:52, Fabian Grünbichler wrote: > > On April 17, 2024 3:10 pm, Dominik Csapak wrote: > >> On 4/17/24 14:45, Fabian Grünbichler wrote: > >>> On April 16, 2024 3:18 pm, Dominik Csapak wrote: > +sub cleanup_extracted_ima

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-17 Thread Dominik Csapak
On 4/17/24 15:52, Fabian Grünbichler wrote: On April 17, 2024 3:10 pm, Dominik Csapak wrote: On 4/17/24 14:45, Fabian Grünbichler wrote: On April 16, 2024 3:18 pm, Dominik Csapak wrote: +sub cleanup_extracted_image { same for this? +my ($source) = @_; + +if ($source =~ m|^(/.+/\.tm

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-17 Thread Fabian Grünbichler
On April 17, 2024 3:10 pm, Dominik Csapak wrote: > On 4/17/24 14:45, Fabian Grünbichler wrote: >> On April 16, 2024 3:18 pm, Dominik Csapak wrote: >>> +sub cleanup_extracted_image { >> >> same for this? >> >>> +my ($source) = @_; >>> + >>> +if ($source =~ m|^(/.+/\.tmp_[0-9]+_[0-9]+)/[^/]

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-17 Thread Fabian Grünbichler
On April 17, 2024 3:07 pm, Dominik Csapak wrote: > On 4/17/24 12:52, Fiona Ebner wrote: >> Am 16.04.24 um 15:18 schrieb Dominik Csapak: >>> since we want to handle ova files (which are only ovf+vmdks bundled in a >>> tar file) for import, add code that handles that. >>> >>> we introduce a valid vol

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-17 Thread Dominik Csapak
On 4/17/24 14:45, Fabian Grünbichler wrote: On April 16, 2024 3:18 pm, Dominik Csapak wrote: since we want to handle ova files (which are only ovf+vmdks bundled in a tar file) for import, add code that handles that. we introduce a valid volname for files contained in ovas like this: storage:

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-17 Thread Dominik Csapak
On 4/17/24 12:52, Fiona Ebner wrote: Am 16.04.24 um 15:18 schrieb Dominik Csapak: since we want to handle ova files (which are only ovf+vmdks bundled in a tar file) for import, add code that handles that. we introduce a valid volname for files contained in ovas like this: storage:import/arch

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-17 Thread Fabian Grünbichler
On April 16, 2024 3:18 pm, Dominik Csapak wrote: > since we want to handle ova files (which are only ovf+vmdks bundled in a > tar file) for import, add code that handles that. > > we introduce a valid volname for files contained in ovas like this: > > storage:import/archive.ova/disk-1.vmdk > >

Re: [pve-devel] [PATCH storage 3/9] plugin: dir: handle ova files for import

2024-04-17 Thread Fiona Ebner
Am 16.04.24 um 15:18 schrieb Dominik Csapak: > since we want to handle ova files (which are only ovf+vmdks bundled in a > tar file) for import, add code that handles that. > > we introduce a valid volname for files contained in ovas like this: > > storage:import/archive.ova/disk-1.vmdk > > by b