Re: [pve-devel] [PATCH pve-storage 3/5] lvmplugin: add qcow2 snapshot

2025-05-14 Thread DERUMIER, Alexandre via pve-devel
ile over xfs|ext|nfs...) I'm really sorry about this, I really need to implement some unit tests , but didn't have time yet :/ Message initial De: Alexandre Derumier À: Fabian Grünbichler , Proxmox VE development discussion Objet: Re: [pve-devel] [PATCH pve-storage 3/5] lvmp

Re: [pve-devel] [PATCH pve-storage 3/5] lvmplugin: add qcow2 snapshot

2025-05-13 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>It's work for me if the vm if offline, I think this is the problem >>with >>the size defined in bytes or kb, depend of the code path if the vm is >>offline or online. (I don't remember exactly where, I need to check) m, I just have retested on my side, online or offline

Re: [pve-devel] [PATCH pve-storage 3/5] lvmplugin: add qcow2 snapshot

2025-05-13 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- the overhead and LV size messages I patched in for debugging purposes.. >>something with the overhead calculation must be wrong? if I make the >>overhead twice as much, it works.. It's work for me if the vm if offline, I think this is the problem with the size defined in by

Re: [pve-devel] [PATCH pve-storage 3/5] lvmplugin: add qcow2 snapshot

2025-05-13 Thread Fabian Grünbichler
I started playing around with this today (finally ;)) but immediately ran into an issue.. VM is running, LVM storage configured, adding a new 32G disk to the VM with format=qcow2: update VM 106: -scsi1 extsnap:32,format=qcow2,discard=on,ssd=on,iothread=on qcow2 overhead: 4096 LV size: 33558528

Re: [pve-devel] [PATCH pve-storage 3/5] lvmplugin: add qcow2 snapshot

2025-05-09 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 22.04.2025 13:51 CEST geschrieben: > we format lvm logical volume with qcow2 to handle snapshot chain. > > like for qcow2 file, when a snapshot is taken, the current lvm volume > is renamed to snap volname, and a new current lvm volume is created > wi