Re: [pve-devel] [PATCH pve-cluster 1/1] notify: add common_template_data

2025-03-28 Thread Lukas Wagner
On 2025-03-28 10:38, Thomas Lamprecht wrote: > Am 28.03.25 um 09:28 schrieb Lukas Wagner: >> We of course can cache the FQDN, but realistically speaking, this is only >> called once per >> notification being sent, thus any real-world performance impact is >> absolutely tiny. > > Not so sure abo

Re: [pve-devel] [PATCH pve-cluster 1/1] notify: add common_template_data

2025-03-28 Thread Thomas Lamprecht
Am 28.03.25 um 09:28 schrieb Lukas Wagner: > We of course can cache the FQDN, but realistically speaking, this is only > called once per > notification being sent, thus any real-world performance impact is absolutely > tiny. Not so sure about that in general, e.g. sending out notifications could

Re: [pve-devel] [PATCH pve-cluster 1/1] notify: add common_template_data

2025-03-28 Thread Lukas Wagner
On 2025-03-27 16:31, Thomas Lamprecht wrote: > Am 27.03.25 um 15:23 schrieb Lukas Wagner: >> This commit add the `common_template_data` sub to PVE::Notify, >> providing a convenient way to get a hash with properties that >> should be accessible from all templates, namely hostname, fqdn >> and c

Re: [pve-devel] [PATCH pve-cluster 1/1] notify: add common_template_data

2025-03-27 Thread Thomas Lamprecht
Am 27.03.25 um 15:23 schrieb Lukas Wagner: > This commit add the `common_template_data` sub to PVE::Notify, > providing a convenient way to get a hash with properties that > should be accessible from all templates, namely hostname, fqdn > and cluster-name. > > Signed-off-by: Lukas Wagner > --- >