Re: [pve-devel] [PATCH proxmox v2 02/12] notify: add api for webhook targets

2024-07-22 Thread Lukas Wagner
On 2024-07-17 17:35, Max Carrara wrote: >> + >> +assert_eq!(secrets[1].name, "token".to_string()); >> +assert_eq!(secrets[1].value, Some(encode("secret"))); >> +assert_eq!(secrets[0].name, "token2".to_string()); >> +assert_eq!(secrets[0].value, Some(encode("newse

Re: [pve-devel] [PATCH proxmox v2 02/12] notify: add api for webhook targets

2024-07-17 Thread Max Carrara
On Fri Jul 12, 2024 at 1:27 PM CEST, Lukas Wagner wrote: > All in all pretty similar to other endpoint APIs. > One thing worth noting is how secrets are handled. We never ever > return the values of previously stored secrets in get_endpoint(s) > calls, but only a list of the names of all secrets. T