Re: [pve-devel] [PATCH] Add UI option for boot optional mapped usb device

Hi, On 12/13/24 09:34, Dominik Csapak wrote: On 12/13/24 01:23, Tyst Marin wrote: I'm still not really all that convinced that Map.Modify is better suited over VM.Config.HWType/ Mapping.Use. Mainly as it seems reasonable to expect the requirement/nonrequirement to still be a hw level config to

Re: [pve-devel] [PATCH] Add UI option for boot optional mapped usb device

I'm still not really all that convinced that Map.Modify is better suited over VM.Config.HWType/Mapping.Use. Mainly as it seems reasonable to expect the requirement/nonrequirement to still be a hw level config to the vm and that the map should only have the role of saying which device for the curren

Re: [pve-devel] [PATCH] Add UI option for boot optional mapped usb device

On 12/13/24 01:23, Tyst Marin wrote: I'm still not really all that convinced that Map.Modify is better suited over VM.Config.HWType/ Mapping.Use. Mainly as it seems reasonable to expect the requirement/nonrequirement to still be a hw level config to the vm and that the map should only have the r

Re: [pve-devel] [PATCH] Add UI option for boot optional mapped usb device

On 12/4/24 22:50, Tyst Marin wrote: Hey Dominik, Hi, Appreciate the info and context you provided. I just sent the cla to off...@proxmox.com so hopefully that's good now(my bad for missing that). Hopefully the below answers at least some part of your questions.

Re: [pve-devel] [PATCH] Add UI option for boot optional mapped usb device

Hey Dominik, Appreciate the info and context you provided. I just sent the cla to off...@proxmox.com so hopefully that's good now(my bad for missing that). Hopefully the below answers at least some part of your questions. You are correct in that I'd like to optionally have the same behavior that

Re: [pve-devel] [PATCH] Add UI option for boot optional mapped usb device

Hi, thanks for wanting to contribute! First, did you already see https://pve.proxmox.com/wiki/Developer_Documentation ? (especially the CLA part at the end?) Just a few high level comments/questions to the approach (did not look too much at the code yet). Please correct me if I'm wrong, but