Re: [pve-devel] vncpropxy question

2022-07-01 Thread Dominik Csapak
On 7/1/22 08:39, Dietmar Maurer wrote: addendum: 'it doesn't do anything here' is not completely correct for 'regular' vm displays it just does not set the ticket which breaks the connection I think this ("break the connection") is important, because otherwise it would allow unecrypted VNC tr

Re: [pve-devel] vncpropxy question

2022-06-30 Thread Dietmar Maurer
> addendum: > > 'it doesn't do anything here' is not completely correct > for 'regular' vm displays it just does not set the ticket which > breaks the connection I think this ("break the connection") is important, because otherwise it would allow unecrypted VNC traffic over the network. I guess

Re: [pve-devel] vncpropxy question

2022-06-30 Thread Thomas Lamprecht
On 30/06/2022 13:50, Dominik Csapak wrote: > > we could even go a step further and remove support for terminals > over vnc completely, since we have support for that in the > browser with xterm.js since quite some time and spiceterm, which can make some sense to keep to provide a single client th

Re: [pve-devel] vncpropxy question

2022-06-30 Thread Dominik Csapak
On 6/30/22 13:25, Dominik Csapak wrote: On 6/30/22 13:02, Dietmar Maurer wrote: in qemu-server, I wonder why we set $ENV{LC_PVE_TICKET} conditionally? Does not make any sense to me, because it make all other connection failing... diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 99b426e.

Re: [pve-devel] vncpropxy question

2022-06-30 Thread Dominik Csapak
On 6/30/22 13:02, Dietmar Maurer wrote: in qemu-server, I wonder why we set $ENV{LC_PVE_TICKET} conditionally? Does not make any sense to me, because it make all other connection failing... diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 99b426e..c6a3ac1 100644 --- a/PVE/API2/Qemu.pm ++

[pve-devel] vncpropxy question

2022-06-30 Thread Dietmar Maurer
in qemu-server, I wonder why we set $ENV{LC_PVE_TICKET} conditionally? Does not make any sense to me, because it make all other connection failing... diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 99b426e..c6a3ac1 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2102,7 +2102,7 @@