Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-26 Thread Fiona Ebner
Am 26.07.24 um 14:02 schrieb Max Carrara: > On Fri Jul 26, 2024 at 11:52 AM CEST, Fiona Ebner wrote: >> Am 25.07.24 um 17:32 schrieb Max Carrara: >>> On Thu Jul 25, 2024 at 3:11 PM CEST, Fiona Ebner wrote: >> >> I don't quite get your point about not needing to update the call sites. >> If you chan

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-26 Thread Max Carrara
On Fri Jul 26, 2024 at 11:52 AM CEST, Fiona Ebner wrote: > Am 25.07.24 um 17:32 schrieb Max Carrara: > > On Thu Jul 25, 2024 at 3:11 PM CEST, Fiona Ebner wrote: > >> Am 25.07.24 um 11:48 schrieb Max Carrara: > >>> The same goes for backup provider plugins - IMO namespacing them > >>> like e

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-26 Thread Fiona Ebner
Am 25.07.24 um 17:32 schrieb Max Carrara: > On Thu Jul 25, 2024 at 3:11 PM CEST, Fiona Ebner wrote: >> Am 25.07.24 um 11:48 schrieb Max Carrara: >>> The same goes for backup provider plugins - IMO namespacing them >>> like e.g. `PVE::Backup::Provider::Plugin::Foo` where `Foo` is a >>> (

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-25 Thread Max Carrara
On Thu Jul 25, 2024 at 3:11 PM CEST, Fiona Ebner wrote: > Am 25.07.24 um 11:48 schrieb Max Carrara: > > On Tue Jul 23, 2024 at 11:56 AM CEST, Fiona Ebner wrote: > >> Signed-off-by: Fiona Ebner > > > > Some overall thoughts: > > > > 1. I'm really, really happy to see documentation in this module

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-25 Thread Fiona Ebner
Am 25.07.24 um 15:11 schrieb Fiona Ebner: > Am 25.07.24 um 11:48 schrieb Max Carrara: >> For the specific types we can always then provide helper functions that >> handle common cases that implementors can use. >> >> Extending on my namespace idea above, those helpers could then land in >> e.g. `PV

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-25 Thread Fiona Ebner
Am 25.07.24 um 11:48 schrieb Max Carrara: > On Tue Jul 23, 2024 at 11:56 AM CEST, Fiona Ebner wrote: >> Signed-off-by: Fiona Ebner > > Some overall thoughts: > > 1. I'm really, really happy to see documentation in this module here, > that's fantastic! :) > > While the contents of the d

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-25 Thread Max Carrara
On Tue Jul 23, 2024 at 11:56 AM CEST, Fiona Ebner wrote: > The new_backup_provider() method can be used by storage plugins for > external backup providers. If the method returns a provider, Proxmox > VE will use callbacks to that provider for backups and restore instead > of using its usual backup/

[pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-23 Thread Fiona Ebner
The new_backup_provider() method can be used by storage plugins for external backup providers. If the method returns a provider, Proxmox VE will use callbacks to that provider for backups and restore instead of using its usual backup/restore mechanisms. API age and version are both bumped. The ba