Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-09 Thread Thomas Lamprecht
Am 09/09/2024 um 09:52 schrieb Fiona Ebner: > Am 09.09.24 um 09:48 schrieb Fabian Grünbichler: >> given that I also use `apt upgrade` from time to time (habit from being an >> unstable user ;)), and that it might alienate power users coming from >> Debian, I'd prefer this to be a non-interactive

Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-09 Thread Fiona Ebner
Am 09.09.24 um 09:48 schrieb Fabian Grünbichler: >> Thomas Lamprecht hat am 06.09.2024 18:58 CEST >> geschrieben: >> Am 06/09/2024 um 12:40 schrieb Fiona Ebner: >>> Many people will use 'upgrade' instead of 'full-upgrade' or >>> 'dist-upgrade' (e.g. [0][1]) despite the documentation explicitly

Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-09 Thread Fabian Grünbichler
> Thomas Lamprecht hat am 06.09.2024 18:58 CEST > geschrieben: > Am 06/09/2024 um 12:40 schrieb Fiona Ebner: > > Many people will use 'upgrade' instead of 'full-upgrade' or > > 'dist-upgrade' (e.g. [0][1]) despite the documentation explicitly > > mentioning 'dist-upgrade' [3]. Proxmox VE uses d

Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-06 Thread Thomas Lamprecht
Am 06/09/2024 um 12:40 schrieb Fiona Ebner: > Many people will use 'upgrade' instead of 'full-upgrade' or > 'dist-upgrade' (e.g. [0][1]) despite the documentation explicitly > mentioning 'dist-upgrade' [3]. Proxmox VE uses different packaging > guarantees than Debian and using 'upgrade' can lead to

Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-06 Thread Thomas Lamprecht
Am 06/09/2024 um 14:16 schrieb Alexander Zeidler: > On Fri Sep 6, 2024 at 12:40 PM CEST, Fiona Ebner wrote: >> (DPkg::Pre-Invoke is also too late). Since this is just an additional >> safety warning to guide new users, it should still be good enough. > >> + if ($line && $line =~ m/^CommandLine::A

Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-06 Thread Thomas Lamprecht
Am 06/09/2024 um 13:01 schrieb Dominik Csapak: > just to mention it (i think it's not widely known): > > 'apt upgrade' behaves slightly different than 'apt-get upgrade' > > while the former also installs new packages if necessary, the latter > doesn't, so an 'apt upgrade' will maybe work ok in mo

Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-06 Thread Alexander Zeidler
On Fri Sep 6, 2024 at 12:40 PM CEST, Fiona Ebner wrote: > (DPkg::Pre-Invoke is also too late). Since this is just an additional > safety warning to guide new users, it should still be good enough. > + if ($line && $line =~ m/^CommandLine::AsString=apt(-get)?%20upgrade$/) { > +$log->("!! WARNI

Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-06 Thread Dominik Csapak
just to mention it (i think it's not widely known): 'apt upgrade' behaves slightly different than 'apt-get upgrade' while the former also installs new packages if necessary, the latter doesn't, so an 'apt upgrade' will maybe work ok in most sitations. I guess we want to filter it out nonetheless

Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-06 Thread Fiona Ebner
Sorry, messed up the subject-prefix, since I copy-pasted it in the .git/config and forgot to change. This is for proxmox-ve of course. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

2024-09-06 Thread Fiona Ebner
Many people will use 'upgrade' instead of 'full-upgrade' or 'dist-upgrade' (e.g. [0][1]) despite the documentation explicitly mentioning 'dist-upgrade' [3]. Proxmox VE uses different packaging guarantees than Debian and using 'upgrade' can lead to a broken system [2]. The match is kept simple, to