Re: [pve-devel] [RFC firewall] implement fail2ban in firewall

2021-10-11 Thread Oguz Bektas
hi, > > that has zero to do with thinking and evaluating about just doing it ourself > here > though? As there's still an additional dependency with an extra daemon > running that > may not even interact correctly with how we operate the iptables... fail2ban already does all of this, is suppor

Re: [pve-devel] [RFC firewall] implement fail2ban in firewall

2021-08-25 Thread Thomas Lamprecht
On 25/08/2021 11:34, Oguz Bektas wrote: > On Tue, Aug 24, 2021 at 08:58:10PM +0200, Thomas Lamprecht wrote: >> E.g., did you think about checking the log just directly here, after all we >> run >> every 10s anyway, so one could just directly parse the daemon log and add the >> rules directly here,

Re: [pve-devel] [RFC firewall] implement fail2ban in firewall

2021-08-25 Thread Oguz Bektas
hi, thank you for the review :) On Tue, Aug 24, 2021 at 08:58:10PM +0200, Thomas Lamprecht wrote: > On 23/08/2021 16:07, Oguz Bektas wrote: > > only as POC/RFC > > > > some thoughts/discussions about the methods/decisions you made would get here. > > E.g., did you think about checking the log

Re: [pve-devel] [RFC firewall] implement fail2ban in firewall

2021-08-24 Thread Thomas Lamprecht
On 23/08/2021 16:07, Oguz Bektas wrote: > only as POC/RFC > some thoughts/discussions about the methods/decisions you made would get here. E.g., did you think about checking the log just directly here, after all we run every 10s anyway, so one could just directly parse the daemon log and add the

[pve-devel] [RFC firewall] implement fail2ban in firewall

2021-08-23 Thread Oguz Bektas
only as POC/RFC Signed-off-by: Oguz Bektas --- known issues: - see FIXME in generate_fail2ban_config. when update/compile is called the fail2ban service will be restarted, that leads to reload every 10s (also the jail conf file is re-written, which i'd like to avoid) - no API integration yet