Re: [pve-devel] [RFC] towards automated integration testing

2023-10-18 Thread Lukas Wagner
On 10/17/23 18:28, Thomas Lamprecht wrote: Am 17/10/2023 um 14:33 schrieb Lukas Wagner: On 10/17/23 08:35, Thomas Lamprecht wrote:  From top of my head I'd rather do some attribute based dependency annotation, so that one can depend on single tests, or whole fixture on others single tests or

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-17 Thread Thomas Lamprecht
Am 17/10/2023 um 14:33 schrieb Lukas Wagner: > On 10/17/23 08:35, Thomas Lamprecht wrote: >>  From top of my head I'd rather do some attribute based dependency >> annotation, so that one can depend on single tests, or whole fixture >> on others single tests or whole fixture. >> > > The more though

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-17 Thread Lukas Wagner
On 10/17/23 08:35, Thomas Lamprecht wrote: Is the order of test-cases guaranteed by toml parsing, or how are intra- fixture dependencies ensured? Good point. With rollbacks in between test cases it probably does not matter much, but on 'real hardware' with no rollback this could definitely

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-17 Thread Thomas Lamprecht
Am 16/10/2023 um 17:18 schrieb Lukas Wagner: > On 10/16/23 13:20, Stefan Hanreich wrote: >> I can imagine having to setup VMs inside the Test Setup as well for >> doing various tests. Doing this manually every time could be quite >> cumbersome / hard to automate. Do you have a mechanism in mind to

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-16 Thread Thomas Lamprecht
Am 16/10/2023 um 17:33 schrieb Lukas Wagner: >> Or is this some part that takes place in the test, i.e., a >> generalization of product to test and supplementary tool/app that helps >> on that test? > > It was intended to be a 'general VM/CT base thingy' that can be > instantiated and managed by t

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-16 Thread Lukas Wagner
Thanks for the summary from our discussion and the additional feedback! On 10/16/23 15:57, Thomas Lamprecht wrote: - create some sort of test report As Stefan mentioned, test-output can be good to have. Our buildbot instance provides that, and while I don't look at them in 99% of the builds

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-16 Thread Lukas Wagner
Thank you for the feedback! On 10/16/23 13:20, Stefan Hanreich wrote: On 10/13/23 15:33, Lukas Wagner wrote: - Additionally, it should be easy to run these integration tests locally on a developer's workstation in order to write new test cases, as well as troubleshooting and debugging ex

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-16 Thread Thomas Lamprecht
A few things, most of which we talked off-list already anyway. We should eye if we can integrate existing regression testing in there too, i.e.: - The qemu autotest that Stefan Reiter started and Fiona still uses, here we should drop the in-git tracked backup that the test VM is restored from

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-16 Thread Stefan Hanreich
On 10/13/23 15:33, Lukas Wagner wrote: > - Additionally, it should be easy to run these integration tests locally > on a developer's workstation in order to write new test cases, as well > as troubleshooting and debugging existing test cases. The local > test environment should match the

[pve-devel] [RFC] towards automated integration testing

2023-10-13 Thread Lukas Wagner
Hello, I am currently doing the groundwork that should eventually enable us to write automated integration tests for our products. Part of that endeavor will be to write a custom test runner, which will - setup a specified test environment - execute test cases in that environment - create