Re: [pve-devel] [PATCH v7 qemu-server] Add API for import wizards

2021-04-01 Thread Fabian Grünbichler
On April 1, 2021 12:19 pm, Dominic Jäger wrote: > On Wed, Mar 31, 2021 at 05:12:28PM +0200, Fabian Grünbichler wrote: >> this is starting to shape up nicely. as promised, I now took a stab at >> (roughly!) integrating this into our regular flow (see diff below): >> >> >> - we could likely dr

Re: [pve-devel] [PATCH v7 qemu-server] Add API for import wizards

2021-04-01 Thread Dominic Jäger
On Wed, Mar 31, 2021 at 05:12:28PM +0200, Fabian Grünbichler wrote: > this is starting to shape up nicely. as promised, I now took a stab at > (roughly!) integrating this into our regular flow (see diff below): > > > - we could likely drop the separate import_disk API call, and let the >

Re: [pve-devel] [PATCH v7 qemu-server] Add API for import wizards

2021-03-31 Thread Fabian Grünbichler
this is starting to shape up nicely. as promised, I now took a stab at (roughly!) integrating this into our regular flow (see diff below): - IMPORT_DISK_RE now uses -1, as 0 actually can be mismatched by NEW_DISK_RE - the actual import happens in create_disks - only the basic checks (match of "

[pve-devel] [PATCH v7 qemu-server] Add API for import wizards

2021-03-26 Thread Dominic Jäger
Extend qm importdisk/importovf functionality to the API. Signed-off-by: Dominic Jäger --- v6->v7: Feedback by Fabian G - Introduce a regex for the import syntax :0 - Use parameter list instead of hash for import helper - More parsing, less string magic - More VM config digest checking - Create a