Re: [pve-devel] [PATCH v6 storage 1/1] add disk reassign feature

2021-04-15 Thread Thomas Lamprecht
On 15.04.21 14:09, Fabian Ebner wrote: >> IMHO it would be nice though to change the structure of the storage plugins >> a bit. E.g. instead of assuming dir/file storages for Plugin.pm, having a >> basic abstraction specifically for any directory/file based storage which >> handles all the commo

Re: [pve-devel] [PATCH v6 storage 1/1] add disk reassign feature

2021-04-15 Thread Thomas Lamprecht
On 15.04.21 13:53, Aaron Lauterer wrote: > Just adding the functionality on the top level Plugin.pm could have some > potential ugly side effects for 3rd party plugins that do not yet handle that > call themselves. So to be on the safe side, by default we rather fail right > there (was discussed a

Re: [pve-devel] [PATCH v6 storage 1/1] add disk reassign feature

2021-04-15 Thread Fabian Ebner
Am 15.04.21 um 13:53 schrieb Aaron Lauterer: On 4/15/21 1:31 PM, Fabian Ebner wrote: Am 15.04.21 um 13:07 schrieb Fabian Ebner: We often have a generic implementation in Plugin.pm for filesystem-based storages (maybe erroring out if there is no $scfg->{path}). Is there a reason not to use su

Re: [pve-devel] [PATCH v6 storage 1/1] add disk reassign feature

2021-04-15 Thread Aaron Lauterer
On 4/15/21 1:31 PM, Fabian Ebner wrote: Am 15.04.21 um 13:07 schrieb Fabian Ebner: We often have a generic implementation in Plugin.pm for filesystem-based storages (maybe erroring out if there is no $scfg->{path}). Is there a reason not to use such an approach, i.e. making file_reassign_volume

Re: [pve-devel] [PATCH v6 storage 1/1] add disk reassign feature

2021-04-15 Thread Fabian Ebner
Am 15.04.21 um 13:07 schrieb Fabian Ebner: We often have a generic implementation in Plugin.pm for filesystem-based storages (maybe erroring out if there is no $scfg->{path}). Is there a reason not to use such an approach, i.e. making file_reassign_volume the default reassign_volume implementat

Re: [pve-devel] [PATCH v6 storage 1/1] add disk reassign feature

2021-04-15 Thread Fabian Ebner
We often have a generic implementation in Plugin.pm for filesystem-based storages (maybe erroring out if there is no $scfg->{path}). Is there a reason not to use such an approach, i.e. making file_reassign_volume the default reassign_volume implementation in Plugin.pm? This would avoid some fra

Re: [pve-devel] [PATCH v6 storage 1/1] add disk reassign feature

2021-04-13 Thread Dominic Jäger
Needs a rebase since the rbd patches On Fri, Apr 02, 2021 at 12:19:19PM +0200, Aaron Lauterer wrote: > +sub reassign_volume { > +my ($class, $scfg, $storeid, $volname, $target_vmid) = @_; > + > +my $base;; > +(undef, $volname, undef, $base) = $class->parse_volname($volname); > + > +

[pve-devel] [PATCH v6 storage 1/1] add disk reassign feature

2021-04-02 Thread Aaron Lauterer
Functionality has been added for the following storage types: * dir based ones * directory * NFS * CIFS * gluster * ZFS * (thin) LVM * Ceph A new feature `reassign` has been introduced to mark which storage plugin supports the feature. Version API and AGE have been bumped. Signe