On Fri, Feb 12, 2021 at 10:03:50AM +0100, Fabian Grünbichler wrote:
> >> > +my $store_conf = PVE::Storage::config();
> >>
> >> it probably makes sense to pass this in as parameter, all call sites
> >> probably have it already ;)
> >
> > I just noticed that I have it in importdisk, but unused
On February 11, 2021 11:32 am, Dominic Jäger wrote:
> Thank you for looking so carefully!
>
> On Wed, Feb 10, 2021 at 10:40:56AM +0100, Fabian Grünbichler wrote:
>>
>> On February 5, 2021 11:04 am, Dominic Jäger wrote:
>> > Extend qm importdisk/importovf functionality to the API.
>> >
>> > @@ -
Thank you for looking so carefully!
On Wed, Feb 10, 2021 at 10:40:56AM +0100, Fabian Grünbichler wrote:
>
> On February 5, 2021 11:04 am, Dominic Jäger wrote:
> > Extend qm importdisk/importovf functionality to the API.
> >
> > @@ -4325,4 +4324,378 @@ __PACKAGE__->register_method({
> > retu
high level review: this is starting to take shape :)
I wonder whether it doesn't make sense to add proper permissions
already? most of it is handled in PVE::Storage::check_volume_access
or check_storage_access in this API module already.. the latter could be
extended to handle the new special s
Extend qm importdisk/importovf functionality to the API.
qm can be adapted to use this later.
Signed-off-by: Dominic Jäger
---
Biggest v3->v4 changes:
* New code instead of bloating update_vm_api
* Don't change anything in the existing schema, use new parameter "diskimages"
* Because this can hap
