Re: [pve-devel] [PATCH v3 qemu-server 09/10] migrate: add remote migration handling

2022-01-19 Thread Fabian Grünbichler
On January 11, 2022 9:19 am, Thomas Lamprecht wrote: > On 04.01.22 17:44, Roland wrote:   +sub phase2_start_remote_cluster { +    my ($self, $vmid, $params) = @_; + +    die "insecure migration to remote cluster not implemented\n" +    if $params->{migrate_opts}->{type} ne

Re: [pve-devel] [PATCH v3 qemu-server 09/10] migrate: add remote migration handling

2022-01-11 Thread Thomas Lamprecht
On 04.01.22 17:44, Roland wrote: >>>   +sub phase2_start_remote_cluster { >>> +    my ($self, $vmid, $params) = @_; >>> + >>> +    die "insecure migration to remote cluster not implemented\n" >>> +    if $params->{migrate_opts}->{type} ne 'websocket'; >>> + >>> +    my $remote_vmid = $self->{opts}-

Re: [pve-devel] [PATCH v3 qemu-server 09/10] migrate: add remote migration handling

2022-01-04 Thread Roland
  +sub phase2_start_remote_cluster { +    my ($self, $vmid, $params) = @_; + +    die "insecure migration to remote cluster not implemented\n" +    if $params->{migrate_opts}->{type} ne 'websocket'; + +    my $remote_vmid = $self->{opts}->{remote}->{vmid}; + +    my $res = PVE::Tunnel::write_tun

Re: [pve-devel] [PATCH v3 qemu-server 09/10] migrate: add remote migration handling

2022-01-04 Thread Fabian Ebner
Two comments inline: Am 22.12.21 um 14:52 schrieb Fabian Grünbichler: remote migration uses a websocket connection to a task worker running on the target node instead of commands via SSH to control the migration. this websocket tunnel is started earlier than the SSH tunnel, and allows adding UNI

[pve-devel] [PATCH v3 qemu-server 09/10] migrate: add remote migration handling

2021-12-22 Thread Fabian Grünbichler
remote migration uses a websocket connection to a task worker running on the target node instead of commands via SSH to control the migration. this websocket tunnel is started earlier than the SSH tunnel, and allows adding UNIX-socket forwarding over additional websocket connections on-demand. the