Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-19 Thread Lukas Wagner
On 7/18/23 16:37, Thomas Lamprecht wrote: Am 18/07/2023 um 14:34 schrieb Dominik Csapak: * the backup edit window is rather tall at this point, and if we assume a  minimum   screen size of 1280x720 there is not quite enough space when you subtract   the (typical) os bar and browser window deco

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-19 Thread Lukas Wagner
On 7/19/23 14:11, Wolfgang Bumiller wrote: The String -> &[u8] modification in the parse method may be a follow-up or a v4 - depending on how we proceed with applying this the whole thing. Discussed this with Thomas yesterday - I'll post a v4 once all reviews are done. Though I'll leave some th

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-19 Thread Wolfgang Bumiller
The proxmox-perl-rs part can be considered Acked-by: Wolfgang Bumiller The String -> &[u8] modification in the parse method may be a follow-up or a v4 - depending on how we proceed with applying this the whole thing. ___ pve-devel mailing list pve-de

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-19 Thread Wolfgang Bumiller
On Wed, Jul 19, 2023 at 10:40:09AM +0200, Lukas Wagner wrote: > Hi again, > > On 7/18/23 14:34, Dominik Csapak wrote: > > * i found one bug, but not quite sure yet where it comes from exactly, > >   putting in emojis into a field (e.g. a comment or author) it's accepted, > >   but editing a diff

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-19 Thread Lukas Wagner
Hi again, On 7/18/23 14:34, Dominik Csapak wrote: * i found one bug, but not quite sure yet where it comes from exactly,   putting in emojis into a field (e.g. a comment or author) it's accepted,   but editing a different entry fails with: --->8--- could not serialize configuration: writing '

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-18 Thread Thomas Lamprecht
Am 18/07/2023 um 14:34 schrieb Dominik Csapak: > * the backup edit window is rather tall at this point, and if we assume a  > minimum >   screen size of 1280x720 there is not quite enough space when you subtract >   the (typical) os bar and browser window decoration, maybe a 'notification' >   tab 

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-18 Thread Lukas Wagner
On 7/18/23 15:58, Dominik Csapak wrote: I already have patches laying around that implement the additional filter matchers, but decided to not include them in the patch series yet. Before the new matchers are merged, I would need to 'stabilize' the properties associate with every single not

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-18 Thread Dominik Csapak
On 7/18/23 15:14, Lukas Wagner wrote: On 7/18/23 14:34, Dominik Csapak wrote: gave the series a quick spin, review of the gui patches comes later ;) a few high level comments from a user perspective: * the node fencing/replication edit windows always shows the warning that it shouldn't be   

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-18 Thread Wolfgang Bumiller
The `proxmox.git` part here so far is Acked-by: Wolfgang Bumiller Requested changes can happen as follow-ups. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-18 Thread Lukas Wagner
On 7/18/23 14:34, Dominik Csapak wrote: gave the series a quick spin, review of the gui patches comes later ;) a few high level comments from a user perspective: * the node fencing/replication edit windows always shows the warning that it shouldn't be   disabled, that should imo only be there

Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-18 Thread Dominik Csapak
gave the series a quick spin, review of the gui patches comes later ;) a few high level comments from a user perspective: * the node fencing/replication edit windows always shows the warning that it shouldn't be disabled, that should imo only be there if i select 'never' ? (conversely, the

[pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

2023-07-17 Thread Lukas Wagner
# Overview The purpose of this patch series is to overhaul the existing mail notification infrastructure in Proxmox VE. The series replaces calls to 'sendmail' with calls to a new, configurable notification module. The module was designed to support multiple notification endpoints, 'sendmail' usin