Re: [pve-devel] [PATCH v3 container 1/1] Add device passthrough

2023-11-13 Thread Filip Schauer
Patch v4 available: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060022.html On 10/11/2023 11:44, Wolfgang Bumiller wrote: On Tue, Nov 07, 2023 at 02:46:42PM +0100, Filip Schauer wrote: Add a dev[n] argument to the container config to pass devices through to a container. A devic

Re: [pve-devel] [PATCH v3 container 1/1] Add device passthrough

2023-11-10 Thread Wolfgang Bumiller
On Tue, Nov 07, 2023 at 02:46:42PM +0100, Filip Schauer wrote: > Add a dev[n] argument to the container config to pass devices through to > a container. A device can be passed by its path. Additionally the access > mode, uid and gid can be specified through their respective properties. > > Signed-

Re: [pve-devel] [PATCH v3 container 1/1] Add device passthrough

2023-11-08 Thread Dominik Csapak
did not properly review this, but what caught my attention was that you don't define any permissions for this new property? by default new options in pve-container only need 'VM.Config.Options' but IMHO this should be root only for now? (unless we can use mappings where we can use those permissio

[pve-devel] [PATCH v3 container 1/1] Add device passthrough

2023-11-07 Thread Filip Schauer
Add a dev[n] argument to the container config to pass devices through to a container. A device can be passed by its path. Additionally the access mode, uid and gid can be specified through their respective properties. Signed-off-by: Filip Schauer --- src/PVE/LXC.pm| 29 +-