Re: [pve-devel] [PATCH v2 docs] qm: add guest agent section

2020-12-17 Thread Thomas Lamprecht
just a small comment on top of the other reviewers stuff. On 17/12/2020 13:13, Aaron Lauterer wrote: > +Proxmox VE will issue a trim command to the guest after the following use {pve} for Proxmox VE > +operations that have the potential to write out zeros to the storage: > + > +* moving a disk t

Re: [pve-devel] [PATCH v2 docs] qm: add guest agent section

2020-12-17 Thread Stoiko Ivanov
Thanks for getting this documented! LGTM as it currently is! (All comments are purely suggestions - feel free to ignore them) One thing I would emphasize a bit more (e.g. by adding it as list items in the initial paragraph) is that getting all the guest agent goodness needs 2 prerequisites: * ins

Re: [pve-devel] [PATCH v2 docs] qm: add guest agent section

2020-12-17 Thread Oguz Bektas
hi, lgtm, except maybe you should also mention that one needs to start/enable the qemu-ga service in the VM for it to work. (not all distributions do this automatically) On Thu, Dec 17, 2020 at 01:13:35PM +0100, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > v1 -> v2: implemented

[pve-devel] [PATCH v2 docs] qm: add guest agent section

2020-12-17 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v1 -> v2: implemented suggested changes from Dylan. Thx for that. Additionally to the previous series [0] which changes the phrasing, it would be nice to have a dedicated Qemu Guest Agent section in the docs. [0] https://lists.proxmox.com/pipermail/pve-devel/202