Re: [pve-devel] [PATCH v2 12/12] ui: qemu: hardware: add eject button for cdroms

2025-01-23 Thread Daniel Herzig
Hi Friedrich, thanks for looking into this, this comes right in time, as I've so far finished v3 of the backend-part. Friedrich Weber writes: > Hi, I have two small things that I noticed skimming the series (inline). > > On 13/01/2025 09:56, Daniel Herzig wrote: >> Eject by setting file to none

Re: [pve-devel] [PATCH v2 12/12] ui: qemu: hardware: add eject button for cdroms

2025-01-23 Thread Friedrich Weber
Hi, I have two small things that I noticed skimming the series (inline). On 13/01/2025 09:56, Daniel Herzig wrote: > Eject by setting file to none. > > Signed-off-by: Daniel Herzig > --- > www/manager6/qemu/HardwareView.js | 43 +++ > 1 file changed, 43 insertions(+)

Re: [pve-devel] [PATCH v2 12/12] ui: qemu: hardware: add eject button for cdroms

2025-01-17 Thread Daniel Herzig
Daniel Kral writes: > On 1/13/25 09:56, Daniel Herzig wrote: >> Eject by setting file to none. > > That's a great addition to the WebGUI! > > One small thing: What about also allow ejecting physical CDROMs? :) > Let me think about this :) ___ pve-deve

Re: [pve-devel] [PATCH v2 12/12] ui: qemu: hardware: add eject button for cdroms

2025-01-16 Thread Daniel Kral
On 1/13/25 09:56, Daniel Herzig wrote: Eject by setting file to none. That's a great addition to the WebGUI! One small thing: What about also allow ejecting physical CDROMs? :) Else consider this: Reviewed-by: Daniel Kral Tested-by: Daniel Kral ___

[pve-devel] [PATCH v2 12/12] ui: qemu: hardware: add eject button for cdroms

2025-01-13 Thread Daniel Herzig
Eject by setting file to none. Signed-off-by: Daniel Herzig --- www/manager6/qemu/HardwareView.js | 43 +++ 1 file changed, 43 insertions(+) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 59e670db..5d1c18a5 100644 --- a/www/