Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2025-01-14 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > Feel free to cleanup this patch and submit it to qemu devs, you are a > better C developper than me ^_^ >>I can try to look into it, but could you give some more details how >>exactly the issue manifests? What parameters are you using for >>block-commit, how does the gra

Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2025-01-13 Thread Fiona Ebner
Am 10.01.25 um 10:32 schrieb DERUMIER, Alexandre: >>> Maybe it could even be a bug then?  > > Yes, it's a bug. I just think that libvirt currently only implement > block-commit with disk blockdev on topnode. > > throttle group are not currently implement in libvirt (but I have seen > some commi

Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2025-01-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>Maybe it could even be a bug then?  Yes, it's a bug. I just think that libvirt currently only implement block-commit with disk blockdev on topnode. throttle group are not currently implement in libvirt (but I have seen some commit to add support recently), they still use

Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2025-01-10 Thread Fiona Ebner
Am 10.01.25 um 08:55 schrieb DERUMIER, Alexandre: > Message initial > De: Fabian Grünbichler > À: Proxmox VE development discussion > Cc: Alexandre Derumier , Fiona > Ebner > Objet: Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit- > replaces optio

Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2025-01-09 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Message initial De: Fabian Grünbichler À: Proxmox VE development discussion Cc: Alexandre Derumier , Fiona Ebner Objet: Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit- replaces option patch Date: 08/01/2025 14:27:02 > Alexandre Derumier

Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2025-01-08 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 16.12.2024 10:12 CET geschrieben: > This is needed for external snapshot live commit, > when the top blocknode is not the fmt-node. > (in our case, the throttle-group node is the topnode) so this is needed to workaround a limitation in block-commit?

[pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- This is needed for external snapshot live commit, when the top blocknode is not the fmt-node. (in our case, the throttle-group node is the topnode) Signed-off-by: Alexandre Derumier --- ...052-block-commit-add-replaces-option.patch | 137 ++ debian/patches/s