Re: [pve-devel] [PATCH storage 1/2] smartctl: remove to-be-replaced disk_tests

2021-05-10 Thread Dominik Csapak
hi, sorry for the long wait on a review, but better late than never ;) so one high level comments: why do you remove all disk tests ?? they did not only test the smart output, but also the usage, ssd/hdd detection, vendor/model etc... i understand that you do not have the original disks for th

Re: [pve-devel] [PATCH storage 1/2] smartctl: remove to-be-replaced disk_tests

2021-05-10 Thread Oguz Bektas
On Mon, May 10, 2021 at 02:15:37PM +0200, Dominik Csapak wrote: > hi, > > sorry for the long wait on a review, but better > late than never ;) > > so one high level comments: > > why do you remove all disk tests ?? > they did not only test the smart output, but also the > usage, ssd/hdd detectio

[pve-devel] [PATCH storage 1/2] smartctl: remove to-be-replaced disk_tests

2021-04-01 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- test/disk_tests/cciss/cciss!c0d0/device/model | 1 - .../disk_tests/cciss/cciss!c0d0/device/vendor | 1 - .../cciss/cciss!c0d0/queue/rotational | 1 - test/disk_tests/cciss/cciss!c0d0/size | 1 - test/disk_tests/cciss/cciss!c0d0_udevadm