Re: [pve-devel] [PATCH storage] Remove the .notes file when a backup is deleted

2022-05-11 Thread Fabian Ebner
Commit title should include "fixes #3972" Please note that there's also an archive_remove() function in Storage.pm which is called when pruning. That (and I'd say archive_info() too) should be extended to also handle the notes file. Am 10.05.22 um 14:09 schrieb Daniel Tschlatscher: > When a VM or

[pve-devel] [PATCH storage] Remove the .notes file when a backup is deleted

2022-05-10 Thread Daniel Tschlatscher
When a VM or Container was deleted, the .notes file was not removed, therefore, over time the dump folder would get polluted with notes of backups that no longer existed. As backup names contain a timestamp and as the notes cannot be reused because of this, I think it is safe to just delete them ju