Re: [pve-devel] [PATCH qemu-server 4/4] cpu config: Unify the default value for 'kvm'

2024-02-23 Thread Filip Schauer
On 22/02/2024 10:35, Fiona Ebner wrote: Yes, I also think the change is fine. But breaking ARM64 guests on a x86_64 host would not be fine. The point is CPU hotplug already doesn't work here, so the commit message should be adapted to mention that. I saw you completely removed the commit message

Re: [pve-devel] [PATCH qemu-server 4/4] cpu config: Unify the default value for 'kvm'

2024-02-22 Thread Fiona Ebner
Am 21.02.24 um 16:39 schrieb Filip Schauer: > On 19/02/2024 15:47, Fiona Ebner wrote: >> On an x86_64 host, for guests using a different architecture (i.e. >> aarch64), hot-plugging is already broken, because we try to hotplug a >> CPU of type "$cpu-x86_64-cpu,XYZ" which won't work anyways: >> >> v

Re: [pve-devel] [PATCH qemu-server 4/4] cpu config: Unify the default value for 'kvm'

2024-02-21 Thread Filip Schauer
On 19/02/2024 15:47, Fiona Ebner wrote: On an x86_64 host, for guests using a different architecture (i.e. aarch64), hot-plugging is already broken, because we try to hotplug a CPU of type "$cpu-x86_64-cpu,XYZ" which won't work anyways: vcpus: hotplug problem - VM 130 qmp command 'device_add' fa

Re: [pve-devel] [PATCH qemu-server 4/4] cpu config: Unify the default value for 'kvm'

2024-02-19 Thread Fiona Ebner
Am 19.12.23 um 10:40 schrieb Filip Schauer: > Make the default value for 'kvm' consistent and take into account > whether the VM will run on the same CPU architecture as the host. This > is a breaking change for VMs with a different CPU architecture running > on an x86_64 host, since in this case t

[pve-devel] [PATCH qemu-server 4/4] cpu config: Unify the default value for 'kvm'

2023-12-19 Thread Filip Schauer
Make the default value for 'kvm' consistent and take into account whether the VM will run on the same CPU architecture as the host. This is a breaking change for VMs with a different CPU architecture running on an x86_64 host, since in this case the default CPU type for CPU hotplug switches from 'k