Re: [pve-devel] [PATCH qemu-server 3/6] template: mark efidisk as read-only

2021-06-07 Thread Fabian Grünbichler
On June 7, 2021 11:29 am, Stefan Reiter wrote: > High-level: If you make the $read_only_str contain the entire > ",readonly=on" stanza, you can just leave it blank by default and avoid > updating all the test cases. yeah, but once you add a few of those the resulting code gets rather messy/ugly

Re: [pve-devel] [PATCH qemu-server 3/6] template: mark efidisk as read-only

2021-06-07 Thread Stefan Reiter
High-level: If you make the $read_only_str contain the entire ",readonly=on" stanza, you can just leave it blank by default and avoid updating all the test cases. On 6/4/21 11:47 AM, Fabian Grünbichler wrote: otherwise backups of templates using UEFI fail with storages like LVM thin, where the

[pve-devel] [PATCH qemu-server 3/6] template: mark efidisk as read-only

2021-06-04 Thread Fabian Grünbichler
otherwise backups of templates using UEFI fail with storages like LVM thin, where the volumes are not writable. disk controllers like IDE and SATA that don't support being read-only are still broken for UEFI. Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm