On Wed, Jul 09, 2025 at 06:21:51PM +0200, Alexandre Derumier via pve-devel
wrote:
> From: Alexandre Derumier
> To: pve-devel@lists.proxmox.com
> Subject: [PATCH qemu-server 3/4] qcow2: add external snapshot support
> Date: Wed, 9 Jul 2025 18:21:51 +0200
> Message-Id: <20250709162202.2952597-7-al
--- Begin Message ---
> + rename($src_file_blockdev->{filename},
> $target_file_blockdev->{filename});
>>
>>^ This seems out of place. This does not make sense for all storages
>>and
>>should already have happened via PVE::Storage::rename_snapshot(), no?
>>You don't want to literally rename
On Wed, Jul 09, 2025 at 06:21:51PM +0200, Alexandre Derumier via pve-devel
wrote:
> From: Alexandre Derumier
> To: pve-devel@lists.proxmox.com
> Subject: [PATCH qemu-server 3/4] qcow2: add external snapshot support
> Date: Wed, 9 Jul 2025 18:21:51 +0200
> Message-Id: <20250709162202.2952597-7-al
--- Begin Message ---
fixme:
- add test for internal (was missing) && external qemu snapshots
- is it possible to use blockjob transactions for commit && steam
for atomatic disk commit ?
Signed-off-by: Alexandre Derumier
---
src/PVE/QemuConfig.pm | 4 +-
src/PVE/QemuServer.pm
