Re: [pve-devel] [PATCH qemu-server] don't default to O_DIRECT on btrfs without nocow

2021-06-24 Thread Wolfgang Bumiller
> On 06/24/2021 4:58 PM Wolfgang Bumiller wrote: > > > otherwise it'll produce a whole lot of checksum errors Just a quick note that this can be more refined. For one: it would be nice to have a `volume_has_feature` for this, but for instance the directory storage plugin might not be able t

[pve-devel] [PATCH qemu-server] don't default to O_DIRECT on btrfs without nocow

2021-06-24 Thread Wolfgang Bumiller
otherwise it'll produce a whole lot of checksum errors and while this would be nice as a storage feature check, it's hard to be 100% accurate there anyway since a directory storage can point anywhere, like for instance a btrfs directory, causing the same issue... Signed-off-by: Wolfgang Bumiller