Re: [pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-05-21 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > Do you see an usecase ? I think we don't you have any user cli > command > to list snapshots in differents plugins currently ? > if later we add replication on external snapshots, we shouldn't > return > internal snapshot list in this case. >>a bit torn on this - while i

Re: [pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-05-20 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 19.05.2025 > 15:01 CEST geschrieben: > > > > + #if first snapshot,as it should be bigger,  we merge child, and > > rename the snapshot to child > > + if(!$parentsnap) { > > +     print "commit: merge content of $childpath into $snappath\n"; > > +     $cmd = ['/usr

Re: [pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-05-20 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 19.05.2025 > 14:08 CEST geschrieben: > > > > > sub free_image { > > my ($class, $storeid, $scfg, $volname, $isBase, $format) = @_; > >   > > @@ -980,6 +994,51 @@ sub free_image { > >  # TODO taken from PVE/QemuServer/Drive.pm, avoiding duplication > > would b

Re: [pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-05-19 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > sub free_image { > my ($class, $storeid, $scfg, $volname, $isBase, $format) = @_; >   > @@ -980,6 +994,51 @@ sub free_image { >  # TODO taken from PVE/QemuServer/Drive.pm, avoiding duplication > would be nice >  my @checked_qemu_img_formats = qw(raw qcow qcow2 qed vmd

Re: [pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-05-19 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > + #if first snapshot,as it should be bigger,  we merge child, and > rename the snapshot to child > + if(!$parentsnap) { > +     print "commit: merge content of $childpath into $snappath\n"; > +     $cmd = ['/usr/bin/qemu-img', 'commit', $childpath]; > +     eval { run_comman

Re: [pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-05-14 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 22.04.2025 13:51 CEST geschrieben: > add a snapext option to enable the feature > > When a snapshot is taken, the current volume is renamed to snap volname > and a current image is created with the snap volume as backing file > > Signed-off-by: Alex

Re: [pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-05-09 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 22.04.2025 13:51 CEST geschrieben: > add a snapext option to enable the feature > > When a snapshot is taken, the current volume is renamed to snap volname > and a current image is created with the snap volume as backing file > > Signed-off-by: Alex

[pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-04-22 Thread Alexandre Derumier via pve-devel
--- Begin Message --- add a snapext option to enable the feature When a snapshot is taken, the current volume is renamed to snap volname and a current image is created with the snap volume as backing file Signed-off-by: Alexandre Derumier --- src/PVE/Storage.pm | 5 +- src/PVE/Stora