Re: [pve-devel] [PATCH pve-storage 09/10] lvmplugin: add qcow2 snapshot

2025-07-09 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > + > +    # we can simply reformat the current lvm volume to avoid > +    # a long safe remove.(not needed here, as the allocated space > +    # is still the same owner) > +    eval { lvm_qcow2_format($class, $storeid, $scfg, $volname, > $format, $snap) }; >>what if the volu

Re: [pve-devel] [PATCH pve-storage 09/10] lvmplugin: add qcow2 snapshot

2025-07-09 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > +    my $backing_path = $class->path($scfg, $name, $storeid, > $backing_snap) if $backing_snap; >>also, this should probably encode a relative path so that renaming >>the VG and >>adapting the storage.cfg entry works without breaking the back >>reference? About relative

Re: [pve-devel] [PATCH pve-storage 09/10] lvmplugin: add qcow2 snapshot

2025-07-04 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 04.07.2025 08:45 CEST geschrieben: > we format lvm logical volume with qcow2 to handle snapshot chain. > > like for qcow2 file, when a snapshot is taken, the current lvm volume > is renamed to snap volname, and a new current lvm volume is created > w

[pve-devel] [PATCH pve-storage 09/10] lvmplugin: add qcow2 snapshot

2025-07-03 Thread Alexandre Derumier via pve-devel
--- Begin Message --- we format lvm logical volume with qcow2 to handle snapshot chain. like for qcow2 file, when a snapshot is taken, the current lvm volume is renamed to snap volname, and a new current lvm volume is created with the snap volname as backing file Signed-off-by: Alexandre Derumier