Re: [pve-devel] [PATCH pve-manager 6/7] fabrics: Add main FabricView

2025-04-05 Thread Gabriel Goller
On 02.04.2025 11:50, Christoph Heiss wrote: Some comments inline - did the review mostly in tandem with testing the UI, to get a better context. On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote: [..] diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js index 74728c8320e9..

Re: [pve-devel] [PATCH pve-manager 6/7] fabrics: Add main FabricView

2025-04-02 Thread Friedrich Weber
Hi, two comments inline: On 28/03/2025 18:13, Gabriel Goller wrote: > TreeView that shows all the fabrics and nodes in a hierarchical > structure. It also shows all the pending changes from the > running-config. > > We decided against including all the interfaces (as children of nodes) > because

Re: [pve-devel] [PATCH pve-manager 6/7] fabrics: Add main FabricView

2025-04-02 Thread Christoph Heiss
Some comments inline - did the review mostly in tandem with testing the UI, to get a better context. On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote: [..] > diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js > index 74728c8320e9..68f7be8d6042 100644 > --- a/www/manager6/dc

[pve-devel] [PATCH pve-manager 6/7] fabrics: Add main FabricView

2025-03-28 Thread Gabriel Goller
TreeView that shows all the fabrics and nodes in a hierarchical structure. It also shows all the pending changes from the running-config. We decided against including all the interfaces (as children of nodes) because otherwise the indentation would be too much. So to keep it simple, we removed the