Re: [pve-devel] [PATCH pve-firewall 1/2] Manually construct guest config path

2023-11-12 Thread Thomas Lamprecht
Am 10/11/2023 um 14:26 schrieb Stefan Lendl: > Thomas Lamprecht writes: >> This won't work as now cfs_read_file only works by luck, if at all, as the >> cfs_read_file needs the cfs_register_file that happens in PVE::QemuServer >> so that the parser is actually available... >> >> I'd much rather se

Re: [pve-devel] [PATCH pve-firewall 1/2] Manually construct guest config path

2023-11-10 Thread Stefan Lendl
The issue arises because firewall depends on qemu-server but qemu-server depends on SDN. So if I try to include firewall from SDN, it will not work. I have looked at Firewall for quite some time now. Some functions in Firewall.pm depend on QemuServer mainly for the parse_net function. I tried to

Re: [pve-devel] [PATCH pve-firewall 1/2] Manually construct guest config path

2023-11-08 Thread Thomas Lamprecht
Am 08/11/2023 um 12:35 schrieb Stefan Lendl: > Remove require QemuConfig from Firewall.pm > We only use it to construct the guest config paths. > Fixes circular include when accessing Firewall::Aliases from > pve-network. > This won't work as now cfs_read_file only works by luck, if at all, as th

[pve-devel] [PATCH pve-firewall 1/2] Manually construct guest config path

2023-11-08 Thread Stefan Lendl
Remove require QemuConfig from Firewall.pm We only use it to construct the guest config paths. Fixes circular include when accessing Firewall::Aliases from pve-network. Signed-off-by: Stefan Lendl --- src/PVE/Firewall.pm | 34 +++--- 1 file changed, 7 insertions(+), 2