Re: [pve-devel] [PATCH pve-firewall] allow non zero ip address host bits

2022-11-08 Thread Thomas Lamprecht
Am 08/11/2022 um 15:15 schrieb Stefan Hrdlicka: >> Could another option be that we normalize CIDRs on entry, i.e., mask out >> the end? I mean,. would not help existing setups, but at least future >> proof it a bit for new systems if there's another call site that will >> trip on this (maybe normal

Re: [pve-devel] [PATCH pve-firewall] allow non zero ip address host bits

2022-11-08 Thread Stefan Hrdlicka
On 10/28/22 11:28, Thomas Lamprecht wrote:> Some issue due to weird and unmentioned dependence on $noerr and > while at it some small comment and commit message style nits that > I might have either ignored or "fixed" up myself other way. > > On 25/10/2022 16:31, Stefan Hrdlicka wrote: >> The

Re: [pve-devel] [PATCH pve-firewall] allow non zero ip address host bits

2022-10-28 Thread Thomas Lamprecht
Some issue due to weird and unmentioned dependence on $noerr and while at it some small comment and commit message style nits that I might have either ignored or "fixed" up myself other way. On 25/10/2022 16:31, Stefan Hrdlicka wrote: > They can already be set directly via the cluster.fw file. N

[pve-devel] [PATCH pve-firewall] allow non zero ip address host bits

2022-10-25 Thread Stefan Hrdlicka
They can already be set directly via the cluster.fw file. Net::IP is just a bit more picky with what it allows: For example: error: 192.168.1.155/24 correct: 192.168.1.0/24 also improves #3554 Signed-off-by: Stefan Hrdlicka --- src/PVE/Firewall.pm | 8 1 file changed, 8 insertion