Re: [pve-devel] [PATCH pve-common] JSONSchema: Increase vmid option minimum to 100

2020-12-15 Thread Thomas Lamprecht
On 15.12.20 09:11, Dominic Jäger wrote: > On Mon, Dec 14, 2020 at 01:33:25PM +0100, Fabian Grünbichler wrote: >> I think the argument is that the associated format already enforces that >> the ID is >= 100, so that the API allows less has no practical effect >> except confusing users that read th

Re: [pve-devel] [PATCH pve-common] JSONSchema: Increase vmid option minimum to 100

2020-12-15 Thread Dominic Jäger
On Mon, Dec 14, 2020 at 01:33:25PM +0100, Fabian Grünbichler wrote: > I think the argument is that the associated format already enforces that > the ID is >= 100, so that the API allows less has no practical effect > except confusing users that read the man page/help output/api dump. This is exa

Re: [pve-devel] [PATCH pve-common] JSONSchema: Increase vmid option minimum to 100

2020-12-14 Thread Fabian Grünbichler
On December 14, 2020 12:52 pm, Thomas Lamprecht wrote: > On 14.12.20 11:20, Dominic Jäger wrote: >> The API standard_option pve-vmid always checks the format pve-vmid. The >> format >> pve-vmid requires the vmid to be >=100. This is correct, because IDs 1-99 are >> reserved. >> >> To display this

Re: [pve-devel] [PATCH pve-common] JSONSchema: Increase vmid option minimum to 100

2020-12-14 Thread Thomas Lamprecht
On 14.12.20 11:20, Dominic Jäger wrote: > The API standard_option pve-vmid always checks the format pve-vmid. The format > pve-vmid requires the vmid to be >=100. This is correct, because IDs 1-99 are > reserved. > > To display this correctly in the API documentation (API viewer, qm man pages), >

[pve-devel] [PATCH pve-common] JSONSchema: Increase vmid option minimum to 100

2020-12-14 Thread Dominic Jäger
The API standard_option pve-vmid always checks the format pve-vmid. The format pve-vmid requires the vmid to be >=100. This is correct, because IDs 1-99 are reserved. To display this correctly in the API documentation (API viewer, qm man pages), we have to set the minimum to 100 in the API standar