Re: [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation

2025-03-05 Thread Gabriel Goller
[snip] +#[derive(Serialize, Deserialize, Debug, Default)] +pub struct FabricConfig { +openfabric: Option, +ospf: Option, +} + +impl FabricConfig { +pub fn new(raw_openfabric: &str, raw_ospf: &str) -> Result { +let openfabric = +openfabric::internal::OpenFabricConfig

Re: [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation

2025-03-05 Thread Wolfgang Bumiller
On Tue, Mar 04, 2025 at 06:30:50PM +0100, Gabriel Goller wrote: > On 28.02.2025 14:57, Thomas Lamprecht wrote: > > Am 14.02.25 um 14:39 schrieb Gabriel Goller: > > > This adds the intermediate, type-checked fabrics config. This one is > > > parsed from the SectionConfig and can be converted into th

Re: [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation

2025-03-04 Thread Gabriel Goller
On 28.02.2025 14:57, Thomas Lamprecht wrote: Am 14.02.25 um 14:39 schrieb Gabriel Goller: This adds the intermediate, type-checked fabrics config. This one is parsed from the SectionConfig and can be converted into the Frr-Representation. The short description of the patch is good, but I would

Re: [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation

2025-03-04 Thread Stefan Hanreich
On 2/14/25 14:39, Gabriel Goller wrote: > This adds the intermediate, type-checked fabrics config. This one is > parsed from the SectionConfig and can be converted into the > Frr-Representation. > > Co-authored-by: Stefan Hanreich > Signed-off-by: Gabriel Goller > --- > proxmox-ve-config/Car

Re: [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation

2025-02-28 Thread Gabriel Goller
On 28.02.2025 14:57, Thomas Lamprecht wrote: Am 14.02.25 um 14:39 schrieb Gabriel Goller: This adds the intermediate, type-checked fabrics config. This one is parsed from the SectionConfig and can be converted into the Frr-Representation. The short description of the patch is good, but I would

Re: [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation

2025-02-28 Thread Thomas Lamprecht
Am 14.02.25 um 14:39 schrieb Gabriel Goller: > This adds the intermediate, type-checked fabrics config. This one is > parsed from the SectionConfig and can be converted into the > Frr-Representation. The short description of the patch is good, but I would like to see more rationale here about choo

[pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation

2025-02-14 Thread Gabriel Goller
This adds the intermediate, type-checked fabrics config. This one is parsed from the SectionConfig and can be converted into the Frr-Representation. Co-authored-by: Stefan Hanreich Signed-off-by: Gabriel Goller --- proxmox-ve-config/Cargo.toml | 10 +- proxmox-ve-config/debian