Re: [pve-devel] [PATCH proxmox-firewall 3/3] tests: add Ping macro to tests

2025-03-13 Thread Hannes Laimer
Tested these changes, I could reproduce the described problem, and after applying the patches the macros only matches the correct ICMP packets, not all. so consider this: Tested-by: Hannes Laimer On 04.02.25 10:57, Stefan Hanreich wrote: Rules using the Ping macro were wrongly generated due to

[pve-devel] [PATCH proxmox-firewall 3/3] tests: add Ping macro to tests

2025-02-04 Thread Stefan Hanreich
Rules using the Ping macro were wrongly generated due to the ICMP macros using the wrong format for specifying ICMP type. The test cases did not include any macros utilizing the ICMP protocol. Add them to catch any errors related to ICMP parsing in the future. Signed-off-by: Stefan Hanreich --- D