Re: [pve-devel] [PATCH manager 2/2] Close #1295: Make apt notifications configurable

2021-04-08 Thread Dietmar Maurer
> Is there a reason why we assume that users without subscription do not want > such notifications? > > As far as I see it, if we change it to > > $dccfg->{notify_updates} // 1 > Then (until they change something) > - users with active subscription should _continue_ to get notifications > - enterp

Re: [pve-devel] [PATCH manager 2/2] Close #1295: Make apt notifications configurable

2021-04-08 Thread Thomas Lamprecht
On 08.04.21 11:21, Dominic Jäger wrote: > On Wed, Apr 07, 2021 at 10:51:43AM +0200, Thomas Lamprecht wrote: >> On 07.04.21 10:30, Dominic Jäger wrote: >>> -# We assume that users with subscriptions want informations >>> -# about new packages. >>> -my $notify = ($info && $info->{status} eq 'Active')

Re: [pve-devel] [PATCH manager 2/2] Close #1295: Make apt notifications configurable

2021-04-08 Thread Dominic Jäger
On Wed, Apr 07, 2021 at 10:51:43AM +0200, Thomas Lamprecht wrote: > On 07.04.21 10:30, Dominic Jäger wrote: > > -# We assume that users with subscriptions want informations > > -# about new packages. > > -my $notify = ($info && $info->{status} eq 'Active') ? 1 : 0; > > +my $notify = $dccfg->{notify

Re: [pve-devel] [PATCH manager 2/2] Close #1295: Make apt notifications configurable

2021-04-07 Thread Thomas Lamprecht
On 07.04.21 10:30, Dominic Jäger wrote: > This way all users, including subscription users, can decide if they want to > receive notifications mails from pveupdate or not. Disabling notifications is > desirable if available updates are monitored externally, for example. > > Signed-off-by: Dominic

[pve-devel] [PATCH manager 2/2] Close #1295: Make apt notifications configurable

2021-04-07 Thread Dominic Jäger
This way all users, including subscription users, can decide if they want to receive notifications mails from pveupdate or not. Disabling notifications is desirable if available updates are monitored externally, for example. Signed-off-by: Dominic Jäger --- bin/pveupdate | 4 +---