Re: [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting

2023-09-20 Thread Thomas Lamprecht
Am 20/09/2023 um 15:42 schrieb Maximiliano Sandoval: > Thomas Lamprecht writes: > >> @maximiliano: how does ceph react if oe sets this currently? >> I.e., does it silently accepts unknown config keys, or does it break >> something? > > Running > > ceph config set global osd_pg_bits 42 > >

Re: [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting

2023-09-20 Thread Maximiliano Sandoval
Thomas Lamprecht writes: > @maximiliano: how does ceph react if one sets this currently? > I.e., does it silently accepts unknown config keys, or does it break > something? Running ceph config set global osd_pg_bits 42 results in Error EINVAL: unrecognized config option 'osd_pg_bits

Re: [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting

2023-09-20 Thread Thomas Lamprecht
Am 20/09/2023 um 14:10 schrieb Dominik Csapak: > sadly removing these parameters would be a breaking change > @maximiliano: how does ceph react if one sets this currently? I.e., does it silently accepts unknown config keys, or does it break something? Because if it's the latter we can assume tha

Re: [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting

2023-09-20 Thread Dominik Csapak
sadly removing these parameters would be a breaking change i'd rather mark it deprecatedand non-functional in the description and remove the functionality then on the next major release, we can announce the breaking change and remove the parameter On 9/7/23 11:49, Maximiliano Sandoval wrote: T

[pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting

2023-09-07 Thread Maximiliano Sandoval
This setting was removed in [1] as part of the v13.0.2 tag. [1] https://github.com/ceph/ceph/commit/e6acf2d1d528a2395947d446a57bec04a3a002dc Signed-off-by: Maximiliano Sandoval --- I did a grep search across multiple projects and I was not able to find more uses of this option. A second pair of